SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Remove redundant span tags for activity and workflow incidents

Browse source 
The tags "activity.incidents" and "workflow.incidents" were removed as they are unnecessary and provide no additional value. This change simplifies the middleware implementation while retaining essential telemetry data.
This commit is contained in:
Sipke Schoorstra 2025-03-17 15:05:24 +01:00
parent 2d485d253d
commit 9b0aa9d922
No known key found for this signature in database
GPG key ID: 5C10502B28A4268F
2 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs
View file

@ -49,7 +49,6 @@ public class OpenTelemetryTracingActivityExecutionMiddleware(ActivityMiddlewareD
{
span.AddEvent(new("faulted"));
span.SetStatus(ActivityStatusCode.Error);
span.SetTag("activity.incidents", true);
var errorSpanHandlerContext = new ErrorSpanContext(span, context.Exception);
var errorSpanHandler = context.GetServices<IErrorSpanHandler>()

1
src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs
View file

@ -91,7 +91,6 @@ public class OpenTelemetryTracingWorkflowExecutionMiddleware(WorkflowMiddlewareD
if (context.Incidents.Any())
{
span.SetTag("workflow.incidents", true);
span.SetTag("workflow.incidents.count", context.Incidents.Count);
foreach (var incident in context.Incidents)