SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Remove redundant status setting in telemetry middleware.

Browse source 
The `SetStatus(ActivityStatusCode.Ok)` calls were unnecessary as the default behavior already sets the appropriate status. This cleanup simplifies the code and avoids redundant operations, improving maintainability.
This commit is contained in:
Sipke Schoorstra 2025-03-17 15:01:37 +01:00
parent af63b1b59a
commit 2d485d253d
No known key found for this signature in database
GPG key ID: 5C10502B28A4268F
2 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs
View file

@ -61,17 +61,14 @@ public class OpenTelemetryTracingActivityExecutionMiddleware(ActivityMiddlewareD
else if (context.Status == ActivityStatus.Canceled)
{
span.AddEvent(new("canceled"));
span.SetStatus(ActivityStatusCode.Ok);
}
else if (context.Status == ActivityStatus.Completed)
{
span.AddEvent(new("completed"));
span.SetStatus(ActivityStatusCode.Ok);
}
else if (context.Status == ActivityStatus.Pending)
{
span.AddEvent(new("pending"));
span.SetStatus(ActivityStatusCode.Ok);
}
}
}

3
src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs
View file

@ -79,17 +79,14 @@ public class OpenTelemetryTracingWorkflowExecutionMiddleware(WorkflowMiddlewareD
else if (context.SubStatus == WorkflowSubStatus.Finished)
{
span.AddEvent(new("finished"));
span.SetStatus(ActivityStatusCode.Ok);
}
else if (context.SubStatus == WorkflowSubStatus.Cancelled)
{
span.AddEvent(new("canceled"));
span.SetStatus(ActivityStatusCode.Ok);
}
else if (context.SubStatus == WorkflowSubStatus.Suspended)
{
span.AddEvent(new("suspended"));
span.SetStatus(ActivityStatusCode.Ok);
}
if (context.Incidents.Any())