From 9b0aa9d9220ac35840a772f212aa2f654d3ca516 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Mon, 17 Mar 2025 15:05:24 +0100 Subject: [PATCH] Remove redundant span tags for activity and workflow incidents The tags "activity.incidents" and "workflow.incidents" were removed as they are unnecessary and provide no additional value. This change simplifies the middleware implementation while retaining essential telemetry data. --- .../OpenTelemetryTracingActivityExecutionMiddleware.cs | 1 - .../OpenTelemetryTracingWorkflowExecutionMiddleware.cs | 1 - 2 files changed, 2 deletions(-) diff --git a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs index 8a7c6243b..6115f7e2d 100644 --- a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs +++ b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs @@ -49,7 +49,6 @@ public class OpenTelemetryTracingActivityExecutionMiddleware(ActivityMiddlewareD { span.AddEvent(new("faulted")); span.SetStatus(ActivityStatusCode.Error); - span.SetTag("activity.incidents", true); var errorSpanHandlerContext = new ErrorSpanContext(span, context.Exception); var errorSpanHandler = context.GetServices() diff --git a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs index 30babe692..837226655 100644 --- a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs +++ b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs @@ -91,7 +91,6 @@ public class OpenTelemetryTracingWorkflowExecutionMiddleware(WorkflowMiddlewareD if (context.Incidents.Any()) { - span.SetTag("workflow.incidents", true); span.SetTag("workflow.incidents.count", context.Incidents.Count); foreach (var incident in context.Incidents)