SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Remove redundant status handling in tracing middleware

Browse source 
This commit eliminates unused status checks ("running" and "pending") from OpenTelemetry tracing middlewares. The changes simplify the codebase and improve maintainability by removing unnecessary logic.
This commit is contained in:
Sipke Schoorstra 2025-03-15 20:07:15 +01:00
parent 39932a6f09
commit 5f74a83a77
No known key found for this signature in database
GPG key ID: 5C10502B28A4268F
2 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs
View file

@ -63,11 +63,6 @@ public class OpenTelemetryTracingActivityExecutionMiddleware(ActivityMiddlewareD
span.AddEvent(new("canceled"));
span.SetStatus(ActivityStatusCode.Ok);
}
else if (context.Status == ActivityStatus.Running)
{
span.AddEvent(new("running"));
span.SetStatus(ActivityStatusCode.Ok);
}
else if (context.Status == ActivityStatus.Completed)
{
span.AddEvent(new("completed"));

7
src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs
View file

@ -22,8 +22,6 @@ namespace Elsa.OpenTelemetry.Middleware;
[UsedImplicitly]
public class OpenTelemetryTracingWorkflowExecutionMiddleware(WorkflowMiddlewareDelegate next, ISystemClock systemClock) : WorkflowExecutionMiddleware(next)
{
private readonly JsonSerializerOptions? _incidentSerializerOptions = new JsonSerializerOptions().WithConverters(new TypeJsonConverter(WellKnownTypeRegistry.CreateDefault()));
/// <inheritdoc />
public override async ValueTask InvokeAsync(WorkflowExecutionContext context)
{
@ -78,11 +76,6 @@ public class OpenTelemetryTracingWorkflowExecutionMiddleware(WorkflowMiddlewareD
span.AddEvent(new("suspended"));
span.SetStatus(ActivityStatusCode.Ok);
}
else if (context.SubStatus == WorkflowSubStatus.Pending)
{
span.AddEvent(new("pending"));
span.SetStatus(ActivityStatusCode.Ok);
}
if (context.Incidents.Any())
{