From 5f74a83a7784750a716d8eff2ba4fa2edb45bc23 Mon Sep 17 00:00:00 2001
From: Sipke Schoorstra <sipkeschoorstra@outlook.com>
Date: Sat, 15 Mar 2025 20:07:15 +0100
Subject: [PATCH] Remove redundant status handling in tracing middleware

This commit eliminates unused status checks ("running" and "pending") from OpenTelemetry tracing middlewares. The changes simplify the codebase and improve maintainability by removing unnecessary logic.
---
 .../OpenTelemetryTracingActivityExecutionMiddleware.cs     | 5 -----
 .../OpenTelemetryTracingWorkflowExecutionMiddleware.cs     | 7 -------
 2 files changed, 12 deletions(-)

diff --git a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs
index 18b9ac477..5cdd23085 100644
--- a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs
+++ b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs
@@ -63,11 +63,6 @@ public class OpenTelemetryTracingActivityExecutionMiddleware(ActivityMiddlewareD
             span.AddEvent(new("canceled"));
             span.SetStatus(ActivityStatusCode.Ok);
         }
-        else if (context.Status == ActivityStatus.Running)
-        {
-            span.AddEvent(new("running"));
-            span.SetStatus(ActivityStatusCode.Ok);
-        }
         else if (context.Status == ActivityStatus.Completed)
         {
             span.AddEvent(new("completed"));
diff --git a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs
index ed30d65e1..cb209a0c0 100644
--- a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs
+++ b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs
@@ -22,8 +22,6 @@ namespace Elsa.OpenTelemetry.Middleware;
 [UsedImplicitly]
 public class OpenTelemetryTracingWorkflowExecutionMiddleware(WorkflowMiddlewareDelegate next, ISystemClock systemClock) : WorkflowExecutionMiddleware(next)
 {
-    private readonly JsonSerializerOptions? _incidentSerializerOptions = new JsonSerializerOptions().WithConverters(new TypeJsonConverter(WellKnownTypeRegistry.CreateDefault()));
-
     /// <inheritdoc />
     public override async ValueTask InvokeAsync(WorkflowExecutionContext context)
     {
@@ -78,11 +76,6 @@ public class OpenTelemetryTracingWorkflowExecutionMiddleware(WorkflowMiddlewareD
             span.AddEvent(new("suspended"));
             span.SetStatus(ActivityStatusCode.Ok);
         }
-        else if (context.SubStatus == WorkflowSubStatus.Pending)
-        {
-            span.AddEvent(new("pending"));
-            span.SetStatus(ActivityStatusCode.Ok);
-        }
 
         if (context.Incidents.Any())
         {