From 2d485d253d3cdb98c178c30feab15070b3814c87 Mon Sep 17 00:00:00 2001
From: Sipke Schoorstra <sipkeschoorstra@outlook.com>
Date: Mon, 17 Mar 2025 15:01:37 +0100
Subject: [PATCH] Remove redundant status setting in telemetry middleware.

The `SetStatus(ActivityStatusCode.Ok)` calls were unnecessary as the default behavior already sets the appropriate status. This cleanup simplifies the code and avoids redundant operations, improving maintainability.
---
 .../OpenTelemetryTracingActivityExecutionMiddleware.cs         | 3 ---
 .../OpenTelemetryTracingWorkflowExecutionMiddleware.cs         | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs
index 5cdd23085..8a7c6243b 100644
--- a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs
+++ b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingActivityExecutionMiddleware.cs
@@ -61,17 +61,14 @@ public class OpenTelemetryTracingActivityExecutionMiddleware(ActivityMiddlewareD
         else if (context.Status == ActivityStatus.Canceled)
         {
             span.AddEvent(new("canceled"));
-            span.SetStatus(ActivityStatusCode.Ok);
         }
         else if (context.Status == ActivityStatus.Completed)
         {
             span.AddEvent(new("completed"));
-            span.SetStatus(ActivityStatusCode.Ok);
         }
         else if (context.Status == ActivityStatus.Pending)
         {
             span.AddEvent(new("pending"));
-            span.SetStatus(ActivityStatusCode.Ok);
         }
     }
 }
diff --git a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs
index a379dc384..30babe692 100644
--- a/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs
+++ b/src/modules/Elsa.OpenTelemetry/Middleware/OpenTelemetryTracingWorkflowExecutionMiddleware.cs
@@ -79,17 +79,14 @@ public class OpenTelemetryTracingWorkflowExecutionMiddleware(WorkflowMiddlewareD
         else if (context.SubStatus == WorkflowSubStatus.Finished)
         {
             span.AddEvent(new("finished"));
-            span.SetStatus(ActivityStatusCode.Ok);
         }
         else if (context.SubStatus == WorkflowSubStatus.Cancelled)
         {
             span.AddEvent(new("canceled"));
-            span.SetStatus(ActivityStatusCode.Ok);
         }
         else if (context.SubStatus == WorkflowSubStatus.Suspended)
         {
             span.AddEvent(new("suspended"));
-            span.SetStatus(ActivityStatusCode.Ok);
         }
 
         if (context.Incidents.Any())