openpencil/tests/engine/clipboard/figma/html.test.ts
Danila Poyarkov c47b5f8d1d
fix(fig): read, render, and write Figma slots (#850)
* fix(fig): read, render, and write Figma slots

Instances of a component with a slot showed the component's default
content instead of their own, and saving to .fig dropped slot properties,
their settings, and every instance's content.

Figma stores an instance's slot content as a frame on the internal canvas
and assigns the slot property that frame's GUID. The reader follows the
assignment while expanding the slot frame and pulls content frames into
the dependency closure without making them layers. The scene graph gains
a SLOT property type with its settings, a SLOT_CONTENT binding, and the
rule that an assigned slot's content belongs to the instance, which
component sync now leaves alone. The writer emits content frames on the
internal canvas and binds slot frames through the parameter map, as
Figma does.

The occurrence and diagnostic types move from the interpreter to
instance-overrides/occurrence.ts to keep it under the size limit.

* fix(fig): keep slot content through swaps and missing content frames

A slot assignment whose content frame the archive lacks no longer refuses
the document: the reader reports it through onMissingSlotContent, like a
missing component, and the slot keeps its component's content.

Swapping an instance's component, which variant switches do, now carries
the instance's own slot content to the new component's slot of the same
name instead of dropping it, as Figma does.

Component sync reads which slot a frame is from the component, whose
bindings instance copies do not receive. Clipboard export numbers slot
content after the other records on its dependency canvas, and the reader
and writer share Figma's default slot value.

* docs: note slot content kept across variant switches

* fix(fig): pair clipboard text by record and drop dangling slot assignments

The Figma clipboard paired text records with source text nodes by
traversal order, but instance-owned slot content is written after the
selected layers, so slotted text and the text after it swapped shaping
data. Records are now paired with their nodes through their GUIDs.

An instance assignment whose slot content frame is missing is dropped
along with the reported diagnostic, so the slot keeps following its
component instead of looking instance-owned.

* ci: pull the slots fixture for unit tests

* test: use GUID and Array.from in the slot tests

* refactor(fig): group occurrence types and paths in one folder

occurrence.ts and occurrence-path.ts became sibling prefixes when the
occurrence types moved out of the interpreter; they now live in
instance-overrides/occurrence/ as types.ts and path.ts.
2026-10-04 00:45:10 +04:00

284 lines
9.6 KiB
TypeScript

import { beforeAll, describe, expect, it } from 'bun:test'
import {
buildFigmaClipboardHTML,
importClipboardNodes,
initCodec,
parseFigmaClipboard,
SceneGraph
} from '@open-pencil/core'
import { slotPropertyId } from '@open-pencil/scene-graph'
import { expectDefined } from '#tests/helpers/assert'
function expectFigmaEditableTextDefaults(
textNode: NonNullable<Awaited<ReturnType<typeof parseFigmaClipboard>>>['nodes'][number]
) {
expect(textNode.textUserLayoutVersion).toBe(5)
expect(textNode.textExplicitLayoutVersion).toBe(1)
expect(textNode.textBidiVersion).toBe(1)
expect(textNode.textAutoResize).toBe('NONE')
expect(textNode.lineHeight).toEqual({ value: 100, units: 'PERCENT' })
expect(textNode.letterSpacing).toEqual({ value: 0, units: 'PIXELS' })
expect(textNode.fontVariantCommonLigatures).toBe(true)
expect(textNode.fontVariantContextualLigatures).toBe(true)
expect(textNode.textDecorationSkipInk).toBe(true)
expect(textNode.emojiImageSet).toBe('APPLE')
}
describe('buildFigmaClipboardHTML', () => {
beforeAll(async () => {
await initCodec()
})
it('encodes a simple frame without throwing', async () => {
const graph = new SceneGraph()
const page = graph.getPages()[0]
const frame = graph.createNode('FRAME', page.id, {
name: 'Card',
x: 0,
y: 0,
width: 300,
height: 200,
fills: [{ type: 'SOLID', color: { r: 1, g: 1, b: 1, a: 1 }, opacity: 1, visible: true }]
})
const html = await buildFigmaClipboardHTML([frame], graph)
expect(html).toContain('figmeta')
expect(html).toContain('figma')
})
it('writes slot content and pairs every text record with its own text', async () => {
const graph = new SceneGraph()
const page = graph.getPages()[0]
const card = graph.createNode('COMPONENT', page.id, {
name: 'Card',
width: 200,
height: 100,
componentPropertyDefinitions: [
{ id: 'card:body', name: 'Body', type: 'SLOT', defaultValue: '' }
]
})
graph.createNode('FRAME', card.id, {
name: 'Body',
width: 200,
height: 100,
componentPropertyReferences: [{ propertyId: 'card:body', field: 'SLOT_CONTENT' }]
})
const instance = expectDefined(graph.createInstance(card.id, page.id), 'instance')
const slot = expectDefined(
graph.getChildren(instance.id).find((child) => slotPropertyId(child)),
'slot'
)
const style = { fontFamily: 'Inter', fontWeight: 400, fontSize: 16, width: 200, height: 24 }
graph.createNode('TEXT', slot.id, { ...style, name: 'Slotted', text: 'In the slot' })
graph.updateNode(instance.id, { componentPropertyAssignments: { 'card:body': '' } })
const after = graph.createNode('TEXT', page.id, { ...style, name: 'After', text: 'Hi' })
const parsed = await parseFigmaClipboard(
expectDefined(await buildFigmaClipboardHTML([instance, after], graph), 'html')
)
const records = parsed?.nodes ?? []
const content = records.filter((node) => node.isSlotContent === true)
expect(content.map((node) => node.name)).toEqual(['Body'])
for (const name of ['Slotted', 'After']) {
const text = expectDefined(
records.find((node) => node.name === name),
name
)
const characters = text.textData?.characters ?? ''
expect(text.derivedTextData?.logicalIndexToCharacterOffsetMap?.length).toBe(
characters.length + 1
)
}
})
it('encodes text nodes with style runs', async () => {
const graph = new SceneGraph()
const page = graph.getPages()[0]
const text = graph.createNode('TEXT', page.id, {
name: 'Styled',
x: 0,
y: 0,
width: 200,
height: 24,
text: 'Hello World',
fontFamily: 'Inter',
fontWeight: 400,
fontSize: 16,
styleRuns: [
{ start: 0, length: 5, style: { fontWeight: 700 } },
{ start: 6, length: 5, style: { fontWeight: 400, italic: true } }
]
})
const html = await buildFigmaClipboardHTML([text], graph)
expect(html).toContain('figmeta')
const parsed = await parseFigmaClipboard(html)
const textNode = parsed?.nodes.find((node) => node.type === 'TEXT')
if (!textNode) throw new Error('Expected text node')
expectFigmaEditableTextDefaults(textNode)
expect(textNode.derivedTextData?.glyphs).toBeDefined()
expect(textNode.derivedTextData?.baselines?.length).toBeGreaterThan(0)
expect(textNode.derivedTextData?.logicalIndexToCharacterOffsetMap?.length).toBe(
text.text.length + 1
)
expect(textNode.derivedTextData?.derivedLines).toEqual([{ directionality: 'LTR' }])
})
it('encodes fallback derived text metrics when outline fonts are unavailable', async () => {
const graph = new SceneGraph()
const page = graph.getPages()[0]
graph.createNode('TEXT', page.id, {
name: 'Title',
x: 0,
y: 0,
width: 552,
height: 70,
text: 'Analytics Overview',
fontFamily: 'Missing Preview Font',
fontWeight: 700,
fontSize: 56,
lineHeight: 67,
textAutoResize: 'HEIGHT'
})
const html = await buildFigmaClipboardHTML(graph.getChildren(page.id), graph)
const parsed = await parseFigmaClipboard(html)
const textNode = parsed?.nodes.find((node) => node.type === 'TEXT')
const baseline = textNode?.derivedTextData?.baselines?.[0]
expect(textNode?.textUserLayoutVersion).toBe(5)
expect(textNode?.textAutoResize).toBe('NONE')
expect(textNode?.derivedTextData?.glyphs?.length).toBe('Analytics Overview'.length)
expect(baseline?.width).toBe(552)
expect(baseline?.lineHeight).toBe(67)
expect(textNode?.derivedTextData?.layoutSize).toEqual({ x: 552, y: 70 })
})
it('encodes auto-layout frames', async () => {
const graph = new SceneGraph()
const page = graph.getPages()[0]
const frame = graph.createNode('FRAME', page.id, {
name: 'Row',
x: 0,
y: 0,
width: 400,
height: 100,
layoutMode: 'HORIZONTAL',
itemSpacing: 16,
paddingTop: 12,
paddingRight: 12,
paddingBottom: 12,
paddingLeft: 12,
primaryAxisSizing: 'HUG',
counterAxisSizing: 'FIXED'
})
graph.createNode('RECTANGLE', frame.id, {
name: 'Child',
x: 0,
y: 0,
width: 50,
height: 50
})
const html = await buildFigmaClipboardHTML([frame], graph)
expect(html).toContain('figmeta')
})
it('preserves source metadata while importing instance overrides', async () => {
const source = new SceneGraph()
const sourcePage = source.getPages()[0]
const component = source.createNode('COMPONENT', sourcePage.id, { name: 'Button' })
source.createNode('TEXT', component.id, { name: 'Label', text: 'Effective label' })
const instance = source.createNode('INSTANCE', sourcePage.id, {
name: 'Button instance',
componentId: component.id
})
source.populateInstanceChildren(instance.id, component.id)
const html = await buildFigmaClipboardHTML([component, instance], source)
const parsed = await parseFigmaClipboard(expectDefined(html, 'Figma clipboard html'))
const clipboard = expectDefined(parsed, 'Figma clipboard')
const target = new SceneGraph()
const targetPage = target.getPages()[0]
importClipboardNodes(clipboard.nodes, target, targetPage.id)
const importedInstance = [...target.getAllNodes()].find(
(node) => node.type === 'INSTANCE' && node.name === 'Button instance'
)
const importedLabel = importedInstance
? [...target.getAllNodes()].find(
(node) => node.type === 'TEXT' && node.parentId === importedInstance.id
)
: undefined
expect(importedInstance).toBeDefined()
expect(importedLabel?.text).toBe('Effective label')
expect(importedLabel?.source.editedFields).toEqual([])
})
it('roundtrips: encode then decode back', async () => {
const graph = new SceneGraph()
const page = graph.getPages()[0]
const frame = graph.createNode('FRAME', page.id, {
name: 'Analytics Overview',
x: 0,
y: 0,
width: 300,
height: 200,
layoutMode: 'VERTICAL',
itemSpacing: 8,
paddingTop: 20,
paddingRight: 20,
paddingBottom: 20,
paddingLeft: 20,
fills: [{ type: 'SOLID', color: { r: 1, g: 1, b: 1, a: 1 }, opacity: 1, visible: true }],
cornerRadius: 12
})
graph.createNode('TEXT', frame.id, {
name: 'Title',
x: 0,
y: 0,
width: 260,
height: 24,
text: 'Analytics Overview',
fontFamily: 'Inter',
fontWeight: 600,
fontSize: 18
})
graph.createNode('TEXT', frame.id, {
name: 'Subtitle',
x: 0,
y: 0,
width: 260,
height: 40,
text: 'Track your key metrics and performance indicators in real time.',
fontFamily: 'Inter',
fontWeight: 400,
fontSize: 14
})
const html = await buildFigmaClipboardHTML([frame], graph)
expect(html).not.toBeNull()
const parsed = await parseFigmaClipboard(expectDefined(html, 'Figma clipboard html'))
const clipboard = expectDefined(parsed, 'Figma clipboard')
expect(clipboard.nodes.length).toBeGreaterThan(0)
const graph2 = new SceneGraph()
const page2 = graph2.getPages()[0]
const created = importClipboardNodes(clipboard.nodes, graph2, page2.id)
expect(created).toHaveLength(1)
const imported = expectDefined(graph2.getNode(created[0]), 'imported clipboard node')
expect(imported.name).toBe('Analytics Overview')
expect(imported.cornerRadius).toBe(12)
const children = graph2.getChildren(imported.id)
expect(children).toHaveLength(2)
expect(children[0].text).toBe('Analytics Overview')
expect(children[1].text).toContain('Track your key metrics')
})
})