d2e380ea9d
* fix(core): draw gradient and image strokes as the paint they are A stroke carried the paint vocabulary already, but nothing read it: the .fig reader sent every stroke paint through resolvedPaintColor, which returns black for a gradient or image, the renderer set a flat color on strokePaint, and the writer emitted a SOLID paint. Strokes now go through the same conversion fills do in both directions, and applyGradientFill and applyImageFill take the target Paint so a stroke reuses the fill shader path instead of growing a second one. forVisibleStrokes is the single place every stroke draw passes through, so the shader is set and cleared there rather than threaded through each draw helper. Closes #797 for rendering and .fig; authoring a gradient stroke from the stroke panel is still to come. * feat(app): author gradient and image strokes from the stroke panel StrokeSection opened a solid-only colour picker and synthesised a fake fill for the swatch, so a stroke could never be anything but one flat colour. It now opens FillPicker like the fill panel does, and applyStrokePaint keeps the stroke's weight, align, cap, join and dashes across a paint change. Completes #797. * fix(core): let a gradient stroke reach vector outlines and arrowheads A vector stroke draws its outline as a filled shape with fillPaint, a dashed one strokes the path, and arrowheads are filled shapes of their own; each cleared the shader first, so a gradient or image stroke on a vector drew black. The stroke pass now configures both paints and owns clearing them, and those helpers keep what it set. Resolve each gradient stop against the stroke's own colour binding rather than the stop's position, which looked up another stroke's. Reported in review of #868. * fix(core): release the shaders a paint no longer owns Every gradient and image shader was handed to a paint and then leaked: the paint takes its own reference, so the caller's handle has to go or WASM memory grows with each redraw. Only the diamond branch did this. A gradient stroke now configures two paints, which doubled the leak. Reported in review of #868. * test(render): model a shader handle the caller deletes The pattern shader double returned a plain string, so deleting the handle the paint no longer owns threw instead of passing.
50 lines
1.9 KiB
TypeScript
50 lines
1.9 KiB
TypeScript
import { expect, test, type Page } from '@playwright/test'
|
|
|
|
import { CanvasHelper } from '#tests/helpers/canvas'
|
|
import { propertyItems, propertySection } from '#tests/helpers/properties'
|
|
|
|
async function selectedStroke(page: Page) {
|
|
return page.evaluate(() => {
|
|
const store = window.openPencil?.getStore?.()
|
|
if (!store) throw new Error('OpenPencil store not initialized')
|
|
const id = [...store.state.selectedIds][0]
|
|
return store.graph.getNode(id)?.strokes?.[0] ?? null
|
|
})
|
|
}
|
|
|
|
/** Until the stroke panel opened the fill picker, a stroke could only ever be one flat color. */
|
|
test('a stroke can be made a gradient and taken back to solid', async ({ page }) => {
|
|
const canvas = new CanvasHelper(page)
|
|
await page.goto('/')
|
|
await canvas.waitForInit()
|
|
|
|
await canvas.drawRect(120, 120, 180, 120)
|
|
await propertySection(page, 'Stroke').getByRole('button', { name: 'Add stroke' }).click()
|
|
await canvas.waitForRender()
|
|
expect(await selectedStroke(page)).toMatchObject({ type: 'SOLID' })
|
|
|
|
await propertyItems(page, 'strokes')
|
|
.first()
|
|
.getByRole('button', { name: 'Stroke', exact: true })
|
|
.click()
|
|
await expect(page.getByTestId('fill-picker-tab-gradient')).toBeVisible()
|
|
|
|
await page.getByTestId('fill-picker-tab-gradient').click()
|
|
await canvas.waitForRender()
|
|
|
|
const gradient = await selectedStroke(page)
|
|
expect(gradient?.type).toBe('GRADIENT_LINEAR')
|
|
expect(gradient?.gradientStops?.length).toBeGreaterThan(1)
|
|
// The stroke keeps its geometry across the paint change.
|
|
expect(gradient).toMatchObject({ weight: 1, align: 'CENTER' })
|
|
|
|
await page.getByTestId('fill-picker-tab-solid').click()
|
|
await canvas.waitForRender()
|
|
|
|
// Switching back keeps the stops, as it does for a fill, so the gradient returns on re-pick.
|
|
const solid = await selectedStroke(page)
|
|
expect(solid?.type).toBe('SOLID')
|
|
expect(solid).toMatchObject({ weight: 1, align: 'CENTER' })
|
|
canvas.assertNoErrors()
|
|
})
|