openpencil/tests/e2e/chat/streaming/jsx.spec.ts
Victor Wads 690c1247e4
feat(collab): show MCP agents, follow streamed JSX, and follow your agents as they work (#725)
* feat(MCP): follow agent activity in canvas

* feat(collab): show MCP, ACP, and harness sessions as agents

MCP clients worked on the document unseen: only the built-in chat had a
presence, and following agent activity meant a separate setting that
moved the viewport after every MCP tool. Each MCP session now shows as
an agent with a callsign in its owner's color, like the chat: the MCP
server forwards the session and the client's name with each tool call,
the app's own ACP and Pi harness chats mark their sessions with a
header, and the agent points at the layers each call reads or changes
on their page. It rests after a quiet spell, leaves when its session
ends or the server disconnects, and collaborators see it through
awareness. Following it works like following anyone else, from the
avatars, so the default-on follow setting and its viewport fitting go.

Co-authored-by: Victor Wads <victor@wads.dev>

* feat(ai): move the chat's agent through JSX as it streams

While the built-in chat streamed a render call, its preview grew on the
canvas but the agent stood still until the tool finished. The preview
now reports, after each update, the element that appeared last and the
bounds of what the JSX builds; the agent's cursor follows that element
and its outline traces the preview, for collaborators too, until the
tool runs and the agent outlines the real layers. Peers' outlines are
validated and capped like their selections.

Co-authored-by: Victor Wads <victor@wads.dev>

* feat(collab): glide cursors and the followed view instead of jumping

People's and agents' cursors jumped to each new point, which with
throttled awareness and an agent streaming JSX made them stutter, and
following re-centered the view in one jump on every update. Cursors now
ease to each new point from wherever they are drawn, and following pans
and zooms the view there the same way, stopping in place when you take
over. With animations off or reduced motion, both move at once. Each
cursor carries an id so it keeps its glide between updates.

Co-authored-by: Victor Wads <victor@wads.dev>

* test(collab): cover MCP agents and the streaming agent in the browser

Test runs send MCP requests through the bridge's own command handler, so
a browser test can show an MCP session as an agent to the editor and to
a collaborator without a separate server. The streaming JSX test checks
that the chat's agent cursor and outline follow the newest element.

Co-authored-by: Victor Wads <victor@wads.dev>

* docs: describe agent sessions, streaming cursors, and gliding follow

Co-authored-by: Victor Wads <victor@wads.dev>

* fix(ai): keep the streaming agent's name off the text it writes

The chat's agent sat at the newest streamed element's top-left corner,
so its name label covered the text being written. It now sits at the
element's trailing corner, where content grows.

Co-authored-by: Victor Wads <victor@wads.dev>

* fix(collab): end only a closed connection's own MCP sessions

When the app's connection to the MCP server closed, every MCP session's
agent left, including sessions that never came over that connection,
such as a second editor's. The bridge now remembers the sessions each
connection carried and ends only those.

Co-authored-by: Victor Wads <victor@wads.dev>

* feat(ai): follow your agents automatically while they work

Agents spun up from the chat or an MCP client worked out of sight and
then went idle, so people had to find what changed, and the agent skill
told agents to move the user's view and selection after every edit. A
Follow agents toggle in the AI panel's header, on by default, now has
the view follow our agents from the start of each run: whichever starts
first, then the next one at work once the followed agent rests. Leaving
the page, moving the view, Escape, or Stop following leaves that agent
alone until it rests; people are never followed this way. The skill no
longer asks agents to select and zoom to their work.

Co-authored-by: Victor Wads <victor@wads.dev>

* fix(collab): keep an MCP agent when a restarted bridge carries its session

Restarting MCP disconnects the old bridge and opens a new one at once,
but the browser reports the old socket's close only after its close
handshake. A tool call that reached the new connection in between was
undone by that close, which ended the session and removed its agent.
Sessions now record every connection their calls came over, across
bridges, and end only when the last of them closes.

The docs no longer say that following an agent keeps it from editing
out of sight: following moves your view, and the stale variables and
follow bullets the changelog's union merge brought back are removed.

Co-authored-by: Victor Wads <victor@wads.dev>

* test(collab): record what the bridge sends instead of an empty fake method

Co-authored-by: Victor Wads <victor@wads.dev>

---------

Co-authored-by: Danila Poyarkov <dev@dannote.net>
2026-10-07 10:04:58 +00:00

224 lines
8.8 KiB
TypeScript

import { CanvasHelper } from '#tests/helpers/canvas'
import { expect, test } from '#tests/helpers/chat/fixture'
import {
addPage,
documentState,
previewKey,
setupCanvas,
switchPage
} from '#tests/helpers/chat/render-preview'
import { installRenderStream } from '#tests/helpers/chat/render-stream'
const opening =
'<Frame name="Streaming card" w={280} h={180} bg="#20242f" flex="col" p={20} gap={12} rounded={16}><Text size={24} color="#ffffff">Streaming'
const closing = ' preview</Text><Rect w={240} h={36} bg="#9747ff" rounded={8}/></Frame>'
const scenario = {
jsx: opening + closing,
placement: { x: 80, y: 80 },
pauseAfter: ['>Streaming', '</Frame>']
}
test('renders streamed JSX without document mutations, then commits once with undo', async ({
configuredChat: chat
}) => {
await setupCanvas(chat.page)
const stream = await installRenderStream(chat.page, scenario)
try {
await chat.submit('Render a card')
await expect.poll(() => stream.evaluate((s) => s.ready())).toBe(true)
await stream.evaluate((s) => s.advance())
await expect.poll(() => previewKey(chat.page)).not.toBe('')
expect(await documentState(chat.page)).toEqual({ children: [], undo: false })
const canvas = new CanvasHelper(chat.page)
await canvas.waitForRender()
expect(await canvas.screenshotCanvasRegion(640, 400)).toMatchSnapshot(
'jsx-streaming-open-text.png'
)
const first = await previewKey(chat.page)
await stream.evaluate((s) => s.advance())
await expect.poll(() => previewKey(chat.page)).not.toBe(first)
await canvas.waitForRender()
expect(await canvas.screenshotCanvasRegion(640, 400)).toMatchSnapshot(
'jsx-streaming-complete-preview.png'
)
expect(await documentState(chat.page)).toEqual({ children: [], undo: false })
await chat.page.evaluate(() => {
const store = window.openPencil?.getStore?.()
if (!store) throw new Error('Editor unavailable')
store.state.panX = 30
store.state.panY = 20
store.state.zoom = 0.75
store.requestRepaint()
})
await canvas.waitForRender()
expect(await canvas.screenshotCanvasRegion(640, 400)).toMatchSnapshot(
'jsx-streaming-zoomed-preview.png'
)
await stream.evaluate((s) => s.complete())
await expect(chat.assistantMessage()).toContainText('Rendered.')
expect(await stream.evaluate((s) => s.requestCount())).toBe(2)
await expect.poll(() => previewKey(chat.page)).toBe('')
const committed = await documentState(chat.page)
expect(committed.children).toHaveLength(1)
expect(committed.undo).toBe(true)
await chat.page.evaluate(() => window.openPencil?.getStore?.().undoAction())
expect(await documentState(chat.page)).toEqual({ children: [], undo: false })
} finally {
await stream.evaluate((s) => s.dispose())
await stream.dispose()
}
})
test('preserves a replacement target until completion and restores it on undo', async ({
configuredChat: chat
}) => {
await setupCanvas(chat.page)
const originalId = await chat.page.evaluate(() => {
const store = window.openPencil?.getStore?.()
if (!store) throw new Error('Editor unavailable')
const node = store.graph.createNode('FRAME', store.state.currentPageId, {
name: 'Placeholder',
x: 80,
y: 80,
width: 280,
height: 180
})
store.requestRender()
return node.id
})
const stream = await installRenderStream(chat.page, {
...scenario,
placement: { replace_id: originalId, x: 80, y: 80 }
})
try {
await chat.submit('Replace the placeholder')
await expect.poll(() => stream.evaluate((s) => s.ready())).toBe(true)
await stream.evaluate((s) => s.advance())
await expect.poll(() => previewKey(chat.page)).not.toBe('')
expect(await documentState(chat.page)).toEqual({ children: [originalId], undo: false })
await stream.evaluate((s) => s.complete())
await expect(chat.assistantMessage()).toContainText('Rendered.')
expect((await documentState(chat.page)).children).not.toContain(originalId)
await chat.page.evaluate(() => window.openPencil?.getStore?.().undoAction())
expect(await documentState(chat.page)).toEqual({ children: [originalId], undo: false })
} finally {
await stream.evaluate((s) => s.dispose())
await stream.dispose()
}
})
test('keeps the run and its preview on their page while the user views another', async ({
configuredChat: chat
}) => {
await setupCanvas(chat.page)
const pages = await addPage(chat.page, 'Other')
const stream = await installRenderStream(chat.page, scenario)
try {
await chat.submit('Render a card')
await expect.poll(() => stream.evaluate((s) => s.ready())).toBe(true)
await stream.evaluate((s) => s.advance())
await expect.poll(() => previewKey(chat.page)).not.toBe('')
await switchPage(chat.page, pages.added)
expect(await previewKey(chat.page)).toBe('')
await expect(chat.page.getByTestId('chat-stop-button')).toBeVisible()
// Away from the run's page: the chat says where it works, and the page list marks it.
const location = chat.page.getByTestId('chat-run-location')
await expect(location).toContainText('is working on “Page 1”')
await expect(
chat.page
.getByTestId('pages-row')
.filter({ hasText: 'Page 1' })
.getByTestId('presence-markers')
).toBeVisible()
await location.getByRole('button', { name: 'Go to page' }).click()
await expect.poll(() => previewKey(chat.page)).not.toBe('')
await expect(location).toHaveCount(0)
await switchPage(chat.page, pages.added)
await stream.evaluate((s) => s.complete())
await expect(chat.assistantMessage()).toContainText('Rendered.')
expect((await documentState(chat.page, pages.current)).children).toHaveLength(1)
expect((await documentState(chat.page, pages.added)).children).toHaveLength(0)
expect(
await chat.page.evaluate(() => window.openPencil?.getStore?.().state.currentPageId)
).toBe(pages.added)
} finally {
await stream.evaluate((s) => s.dispose())
await stream.dispose()
}
})
for (const outcome of ['cancel', 'error', 'disconnect'] as const) {
test(`removes speculative JSX on ${outcome} without committing it`, async ({
configuredChat: chat
}) => {
await setupCanvas(chat.page)
const stream = await installRenderStream(chat.page, {
...scenario,
outcome: outcome === 'error' ? 'provider-error' : 'render'
})
try {
await chat.submit('Render a card')
await expect.poll(() => stream.evaluate((s) => s.ready())).toBe(true)
await stream.evaluate((s) => s.advance())
await expect.poll(() => previewKey(chat.page)).not.toBe('')
if (outcome === 'cancel') await chat.page.getByTestId('chat-stop-button').click()
else if (outcome === 'error') await stream.evaluate((s) => s.complete())
else await stream.evaluate((s) => s.fail())
await expect.poll(() => previewKey(chat.page)).toBe('')
expect(await documentState(chat.page)).toEqual({ children: [], undo: false })
} finally {
await stream.evaluate((s) => s.dispose())
await stream.dispose()
}
})
}
test("the chat's agent moves through the streamed elements and outlines them", async ({
configuredChat: chat
}) => {
await setupCanvas(chat.page)
const stream = await installRenderStream(chat.page, scenario)
const agentCursor = () =>
chat.page.evaluate(() => {
const cursor = window.openPencil
?.getStore?.()
.state.presenceCursors.find((entry) => entry.kind === 'agent')
return cursor
? {
x: cursor.x,
y: cursor.y,
outlines: cursor.outline?.length ?? 0,
selection: cursor.selection
}
: null
})
try {
await chat.submit('Render a card')
await expect.poll(() => stream.evaluate((s) => s.ready())).toBe(true)
await stream.evaluate((s) => s.advance())
await expect.poll(() => previewKey(chat.page)).not.toBe('')
// The text streams first: the cursor sits at its trailing corner, inside the outlined card,
// so the agent's name does not cover the text being written.
await expect.poll(agentCursor).toMatchObject({ outlines: 2 })
const onText = await agentCursor()
expect(onText?.x).toBeGreaterThan(100)
expect(onText?.y).toBeGreaterThan(100)
await stream.evaluate((s) => s.advance())
// The last element to appear is the button bar below the text.
await expect.poll(async () => (await agentCursor())?.y).toBeGreaterThan(130)
await stream.evaluate((s) => s.complete())
await expect(chat.assistantMessage()).toContainText('Rendered.')
// Once the tool ran, the agent outlines the real layer instead of the preview.
await expect.poll(async () => (await agentCursor())?.outlines ?? 0).toBe(0)
} finally {
await stream.evaluate((s) => s.dispose())
await stream.dispose()
}
})