Three oxlint JS plugin rules in lint/plugin.js:
- no-inline-named-types: configurable shape→name map catches inline
{ x: number; y: number } etc. and suggests Vector, Color, GUID,
Rect, Matrix from @open-pencil/core
- no-structuredclone-scene-arrays: flags structuredClone on
fills/strokes/effects — use typed copy helpers instead
- no-math-random: bans Math.random() in favor of crypto
Fixed 40 violations across 13 files: replaced inline type literals
with named imports, switched figma-api.ts structuredClone calls to
copyFills/copyStrokes/copyEffects.
133 lines
3.6 KiB
JavaScript
133 lines
3.6 KiB
JavaScript
const noInlineNamedTypes = {
|
|
meta: {
|
|
docs: {
|
|
description: 'Disallow inline type literals that duplicate a named type',
|
|
},
|
|
schema: [
|
|
{
|
|
type: 'object',
|
|
additionalProperties: {
|
|
type: 'string',
|
|
},
|
|
},
|
|
],
|
|
},
|
|
create(context) {
|
|
const typesOption = context.options[0]
|
|
if (!typesOption || typeof typesOption !== 'object') return {}
|
|
|
|
const shapeToName = new Map()
|
|
for (const [name, shape] of Object.entries(typesOption)) {
|
|
shapeToName.set(shape, name)
|
|
}
|
|
|
|
return {
|
|
TSTypeLiteral(node) {
|
|
const props = node.members?.filter(
|
|
(m) => m.type === 'TSPropertySignature' && m.key?.type === 'Identifier',
|
|
)
|
|
if (!props || props.length < 2) return
|
|
|
|
if (props.some((m) => m.optional)) return
|
|
|
|
const shape = props
|
|
.map((m) => {
|
|
const typeNode = m.typeAnnotation?.typeAnnotation
|
|
let typeName = 'unknown'
|
|
if (typeNode) {
|
|
switch (typeNode.type) {
|
|
case 'TSNumberKeyword': typeName = 'number'; break
|
|
case 'TSStringKeyword': typeName = 'string'; break
|
|
case 'TSBooleanKeyword': typeName = 'boolean'; break
|
|
}
|
|
}
|
|
return `${m.key.name}:${typeName}`
|
|
})
|
|
.sort()
|
|
.join(',')
|
|
|
|
const namedType = shapeToName.get(shape)
|
|
if (namedType) {
|
|
context.report({
|
|
node,
|
|
message: `Use '${namedType}' instead of inline type literal. Import from '@open-pencil/core'.`,
|
|
})
|
|
}
|
|
},
|
|
}
|
|
},
|
|
}
|
|
|
|
const noStructuredCloneSceneArrays = {
|
|
meta: {
|
|
docs: {
|
|
description:
|
|
'Disallow structuredClone on fills/strokes/effects — use typed copy helpers from copy.ts',
|
|
},
|
|
schema: [
|
|
{
|
|
type: 'array',
|
|
items: { type: 'string' },
|
|
description: 'Property names that should use typed copy helpers',
|
|
},
|
|
],
|
|
},
|
|
create(context) {
|
|
const props = new Set(context.options[0] ?? [
|
|
'fills', 'strokes', 'effects', 'styleRuns', 'fillGeometry', 'strokeGeometry',
|
|
])
|
|
return {
|
|
CallExpression(node) {
|
|
if (node.callee?.type !== 'Identifier' || node.callee.name !== 'structuredClone') return
|
|
if (node.arguments?.length !== 1) return
|
|
const arg = node.arguments[0]
|
|
if (arg.type === 'MemberExpression' && arg.property?.type === 'Identifier') {
|
|
if (props.has(arg.property.name)) {
|
|
context.report({
|
|
node,
|
|
message: `Use the typed copy helper instead of structuredClone for '${arg.property.name}'. Import from '@open-pencil/core'.`,
|
|
})
|
|
}
|
|
}
|
|
},
|
|
}
|
|
},
|
|
}
|
|
|
|
const noMathRandom = {
|
|
meta: {
|
|
docs: {
|
|
description: 'Disallow Math.random() — use crypto.getRandomValues() instead',
|
|
},
|
|
},
|
|
create(context) {
|
|
return {
|
|
CallExpression(node) {
|
|
if (
|
|
node.callee?.type === 'MemberExpression' &&
|
|
node.callee.object?.type === 'Identifier' &&
|
|
node.callee.object.name === 'Math' &&
|
|
node.callee.property?.type === 'Identifier' &&
|
|
node.callee.property.name === 'random'
|
|
) {
|
|
context.report({
|
|
node,
|
|
message: 'Use crypto.getRandomValues() instead of Math.random().',
|
|
})
|
|
}
|
|
},
|
|
}
|
|
},
|
|
}
|
|
|
|
const plugin = {
|
|
meta: { name: 'open-pencil' },
|
|
rules: {
|
|
'no-inline-named-types': noInlineNamedTypes,
|
|
'no-structuredclone-scene-arrays': noStructuredCloneSceneArrays,
|
|
'no-math-random': noMathRandom,
|
|
},
|
|
}
|
|
|
|
export default plugin
|