openpencil/scripts/ab-corpus/apply.ts
Fini bd370bd5b8 fix(ab-corpus): keep applying composite tags past per-shape failures
Codex stop-time review caught the previous commit (113bd55a) message
overstating apply.ts's behavior — I claimed "scripts/ab-corpus/apply
both catch per-shape and keep running the remaining tags" but the
loop at line 55 had no inner try/catch. A single throw from any
handleElementToolCall (e.g. the heading invalid-level reject 113bd55a
just added) would bubble up through the outer try at line 40 and
return early, dropping every remaining tag in a composite batch on
the floor — gpt-5.4's 13-tag team-people-page response would lose
tags 12-13 instead of just tag 12.

Wraps each handleElementToolCall in its own try/catch + accumulates
failures into a per-shape list. ELEMENT_TOOL_NAMES miss is also a
push-and-continue (was a return). When `failures.length > 0` we
return ok:false with a message listing every failed tag, AND the
partial PenDocument that DID land — so M3 (role coverage) can still
score the 11 tags that worked. M1 stays strict (any failure → false).

Mirrors apps/web/src/services/ai/element-tools-dispatcher::
dispatchElementToolCalls's "collect-errors-keep-going" semantics —
production already worked this way; ab-corpus now does too.

3772 vitest pass, format clean, tsc silent. Existing dry-run + live
sweeps exercise the path; a focused apply.ts unit test would need
pen-mcp setup that the harness's existing build-prompt test sidesteps,
so leaving that as a followup.
2026-04-29 09:49:55 +08:00

117 lines
4.6 KiB
TypeScript

/**
* Concrete ApplyFn implementation that routes element-tool calls and
* batch_design DSL through the real pen-mcp handlers. Lives in
* scripts/ (not a package) to keep the pen-ai-skills ↔ pen-mcp
* dependency unidirectional — the scorer in packages/pen-ai-skills
* declares the ApplyFn contract, this file implements it.
*/
import { mkdtempSync, writeFileSync, readFileSync, rmSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import type { PenDocument } from '@zseven-w/pen-types';
import type { ApplyFn, ApplyResult, ParsedOutput } from '@zseven-w/pen-ai-skills';
import {
ELEMENT_TOOL_NAMES,
handleBatchDesign,
handleElementToolCall,
invalidateCache,
} from '@zseven-w/pen-mcp';
const EMPTY = JSON.stringify({ version: '1.0.0', children: [] });
/**
* Apply a parsed output to a fresh, disposable .op file. The scorer
* reads the resulting PenDocument back and does not need the file to
* persist — we clean up per call.
*
* On success: `ok: true` + `doc: PenDocument`.
* On failure (handler throws OR writes no root): `ok: false` +
* `error: <message>` + `doc: null`. Throws are caught so a single
* bad run never halts the whole corpus sweep.
*/
export const applyToFreshDoc: ApplyFn = async (parsed: ParsedOutput): Promise<ApplyResult> => {
if (parsed.kind === 'garbage') {
return { ok: false, error: `unparseable: ${parsed.reason}`, doc: null };
}
const tmpDir = mkdtempSync(join(tmpdir(), 'ab-corpus-apply-'));
const fp = join(tmpDir, 'doc.op');
writeFileSync(fp, EMPTY, 'utf-8');
try {
if (parsed.kind === 'tool_calls') {
// Apply every call into the same fresh doc, in emit order.
// Composite prompts route here with N≥2 calls; obvious prompts
// typically with N=1. Per-shape try/catch keeps the batch going
// past a single bad tag — matches production
// (apps/web/src/services/ai/element-tools-dispatcher::dispatchElementToolCalls)
// and prevents one invented arg (e.g. an unknown heading level
// on tag 12 of 13, seen on gpt-5.4 in ab-v4) from dropping the
// other 12 valid tags on the floor. M1 stays strict: any failure
// → ok:false; the partial PenDocument is returned so M3 (role
// coverage) can still score against whatever did land.
const failures: string[] = [];
for (let i = 0; i < parsed.calls.length; i += 1) {
const call = parsed.calls[i];
const tagLabel = `call ${i + 1}/${parsed.calls.length} (${call.name})`;
if (!ELEMENT_TOOL_NAMES.has(call.name)) {
failures.push(`${tagLabel}: unknown element tool`);
continue;
}
try {
await handleElementToolCall(call.name, { ...call.arguments, filePath: fp });
} catch (err) {
const msg = err instanceof Error ? err.message : String(err);
failures.push(`${tagLabel}: ${msg}`);
}
}
if (failures.length > 0) {
let partialDoc: PenDocument | null = null;
try {
const candidate = JSON.parse(readFileSync(fp, 'utf-8')) as PenDocument;
const topLevel = (candidate.children ??
candidate.pages?.[0]?.children ??
[]) as unknown[];
if (topLevel.length > 0) partialDoc = candidate;
} catch {
// File unreadable or empty (e.g. every tag failed before
// the first element-tool wrote anything) — surface null.
}
return {
ok: false,
error: `${failures.length}/${parsed.calls.length} tag(s) failed: ${failures.join('; ')}`,
doc: partialDoc,
};
}
} else {
const result = await handleBatchDesign({
operations: parsed.dsl,
filePath: fp,
postProcess: false,
});
if (result.errors && result.errors.length > 0) {
const summary = result.errors.map((e) => `${e.line.slice(0, 60)}: ${e.error}`).join('; ');
return { ok: false, error: `batch_design errors: ${summary}`, doc: null };
}
}
const doc = JSON.parse(readFileSync(fp, 'utf-8')) as PenDocument;
const topLevel = (doc.children ?? doc.pages?.[0]?.children ?? []) as unknown[];
if (topLevel.length === 0) {
return { ok: false, error: 'apply produced no root nodes', doc: null };
}
return { ok: true, error: '', doc };
} catch (err) {
return {
ok: false,
error: err instanceof Error ? err.message : String(err),
doc: null,
};
} finally {
invalidateCache(fp);
try {
rmSync(tmpDir, { recursive: true, force: true });
} catch {
// Best-effort cleanup; leaving a tmp file behind is harmless.
}
}
};