bd370bd5b8
Codex stop-time review caught the previous commit (113bd55a) message overstating apply.ts's behavior — I claimed "scripts/ab-corpus/apply both catch per-shape and keep running the remaining tags" but the loop at line 55 had no inner try/catch. A single throw from any handleElementToolCall (e.g. the heading invalid-level reject 113bd55a just added) would bubble up through the outer try at line 40 and return early, dropping every remaining tag in a composite batch on the floor — gpt-5.4's 13-tag team-people-page response would lose tags 12-13 instead of just tag 12. Wraps each handleElementToolCall in its own try/catch + accumulates failures into a per-shape list. ELEMENT_TOOL_NAMES miss is also a push-and-continue (was a return). When `failures.length > 0` we return ok:false with a message listing every failed tag, AND the partial PenDocument that DID land — so M3 (role coverage) can still score the 11 tags that worked. M1 stays strict (any failure → false). Mirrors apps/web/src/services/ai/element-tools-dispatcher:: dispatchElementToolCalls's "collect-errors-keep-going" semantics — production already worked this way; ab-corpus now does too. 3772 vitest pass, format clean, tsc silent. Existing dry-run + live sweeps exercise the path; a focused apply.ts unit test would need pen-mcp setup that the harness's existing build-prompt test sidesteps, so leaving that as a followup. |
||
|---|---|---|
| .. | ||
| ab-corpus | ||
| bundle-skill.ts | ||
| ensure-agent-native.cjs | ||
| patch-srvx-bun.ts | ||
| publish-beta.sh | ||
| unpublish.sh | ||