* fix: match Figma when dragging, drawing, duplicating, and pasting Checked against Figma desktop 126 with real pointer input. A dragged layer lands in the topmost unlocked frame, section, component, or instance under the cursor, following rotation and clipping, and leaves its frame as soon as the cursor does; groups, boolean operations, component sets, and locked frames never take a drop, and a layer stays in its group unless it lands on another frame. Space keeps parents, Shift locks an axis, and Control drops into auto layout as an absolute-positioned layer. Locked layers stay put. New shapes go into the frame under the start point, frames and sections take in the unlocked siblings they fully cover, duplicates land in place (top-level frames to the right), and paste keeps the copied position, centering an axis that does not fit the selected frame. * fix: match Figma for drag edge cases with components, groups, and auto layout A second round of checks against Figma desktop 126, replaying the same pointer input in both editors. A component set takes back only its own variants, and components never go into other components. Groups and booleans refit their children after a move or nudge, and a group whose last layer leaves is removed. Pressing inside a selected frame, group, or component set drags it instead of the layer under the cursor. Auto layout children dragged out land where they are dropped, drawing inside auto layout adds to the end of the flow, and wrapped frames insert on the line under the cursor. Duplicates keep their names, and a main component duplicates as an instance with Cmd+D or Alt-drag; a multi-layer duplicate stays in place, and a lone frame in a section counts as top-level. * fix(core): refuse new shapes in the locked part of an instance createShape redirected a refused parent through acceptingParent while keeping coordinates in the original parent's space, and still inserted the layer when the slot claim failed. It now takes the given parent, claims a slot when needed, and throws when the parent refuses children; drawing skips such parents before creating anything.
190 lines
6.3 KiB
TypeScript
190 lines
6.3 KiB
TypeScript
import { describe, expect, test } from 'bun:test'
|
|
|
|
import { createEditor } from '@open-pencil/core/editor'
|
|
|
|
import { handleMoveMove, handleMoveUp, MOVE_DRAG_START_THRESHOLD_PX } from '#vue/shared/input/move'
|
|
import { createSelectionMoveDrag } from '#vue/shared/input/select/move'
|
|
import type { DragMove } from '#vue/shared/input/types'
|
|
|
|
function setupMoveDrag(): {
|
|
editor: ReturnType<typeof createEditor>
|
|
drag: DragMove
|
|
nodeId: string
|
|
} {
|
|
const editor = createEditor()
|
|
const pageId = editor.state.currentPageId
|
|
const node = editor.graph.createNode('RECTANGLE', pageId, {
|
|
name: 'Box',
|
|
x: 10,
|
|
y: 20,
|
|
width: 100,
|
|
height: 80
|
|
})
|
|
editor.select([node.id])
|
|
const drag = createSelectionMoveDrag(10, 20, 100, 200, editor, false)
|
|
if (drag.type !== 'move') throw new Error('Expected move drag')
|
|
return { editor, drag, nodeId: node.id }
|
|
}
|
|
|
|
describe('selection move drag threshold', () => {
|
|
test('does not move selected nodes for click jitter below threshold', () => {
|
|
const { editor, drag, nodeId } = setupMoveDrag()
|
|
|
|
handleMoveMove(drag, 11, 21, 100 + MOVE_DRAG_START_THRESHOLD_PX - 1, 200, editor)
|
|
handleMoveUp(drag, editor)
|
|
|
|
const node = editor.graph.getNode(nodeId)
|
|
expect(node?.x).toBe(10)
|
|
expect(node?.y).toBe(20)
|
|
expect(drag.dragStarted).toBe(false)
|
|
})
|
|
|
|
test('moves selected nodes once pointer movement exceeds threshold', () => {
|
|
const { editor, drag, nodeId } = setupMoveDrag()
|
|
|
|
handleMoveMove(drag, 16, 27, 100 + MOVE_DRAG_START_THRESHOLD_PX + 1, 200, editor)
|
|
handleMoveUp(drag, editor)
|
|
|
|
const node = editor.graph.getNode(nodeId)
|
|
expect(node?.x).toBe(16)
|
|
expect(node?.y).toBe(27)
|
|
expect(drag.dragStarted).toBe(true)
|
|
})
|
|
|
|
test('preserves fractional movement when pixel snapping is disabled', () => {
|
|
const { editor, drag, nodeId } = setupMoveDrag()
|
|
editor.state.snappingPreferences = { geometry: true, objects: false, pixelGrid: false }
|
|
|
|
handleMoveMove(drag, 16.25, 27.75, 110, 200, editor)
|
|
handleMoveUp(drag, editor)
|
|
|
|
expect(editor.graph.getNode(nodeId)).toMatchObject({ x: 16.25, y: 27.75 })
|
|
})
|
|
|
|
test('snaps movement to whole pixels when pixel snapping is enabled', () => {
|
|
const { editor, drag, nodeId } = setupMoveDrag()
|
|
editor.state.snappingPreferences = { geometry: true, objects: false, pixelGrid: true }
|
|
|
|
handleMoveMove(drag, 16.25, 27.75, 110, 200, editor)
|
|
handleMoveUp(drag, editor)
|
|
|
|
expect(editor.graph.getNode(nodeId)).toMatchObject({ x: 16, y: 28 })
|
|
})
|
|
|
|
test('Control bypasses object and pixel snapping during movement', () => {
|
|
const { editor, drag, nodeId } = setupMoveDrag()
|
|
|
|
handleMoveMove(drag, 16.25, 27.75, 110, 200, editor, { ctrlKey: true })
|
|
handleMoveUp(drag, editor)
|
|
|
|
expect(editor.graph.getNode(nodeId)).toMatchObject({ x: 16.25, y: 27.75 })
|
|
expect(editor.state.snapGuides).toEqual([])
|
|
})
|
|
|
|
test('Control bypasses object and pixel snapping inside a rotated parent', () => {
|
|
const editor = createEditor()
|
|
const pageId = editor.state.currentPageId
|
|
const frame = editor.graph.createNode('FRAME', pageId, {
|
|
x: 200,
|
|
y: 150,
|
|
width: 300,
|
|
height: 300,
|
|
rotation: 30
|
|
})
|
|
const moving = editor.graph.createNode('RECTANGLE', frame.id, {
|
|
x: 20,
|
|
y: 40,
|
|
width: 50,
|
|
height: 50
|
|
})
|
|
editor.select([moving.id])
|
|
const drag = createSelectionMoveDrag(0, 0, 0, 0, editor, false)
|
|
if (drag.type !== 'move') throw new Error('Expected move drag')
|
|
|
|
handleMoveMove(drag, 74, 43, 100, 100, editor, { ctrlKey: true })
|
|
|
|
const angle = (-30 * Math.PI) / 180
|
|
expect(drag.appliedDx).toBeCloseTo(74 * Math.cos(angle) - 43 * Math.sin(angle), 3)
|
|
expect(drag.appliedDy).toBeCloseTo(74 * Math.sin(angle) + 43 * Math.cos(angle), 3)
|
|
expect(editor.state.snapGuides).toEqual([])
|
|
})
|
|
|
|
test('converts world movement into a rotated parent coordinate space', () => {
|
|
const editor = createEditor()
|
|
const pageId = editor.state.currentPageId
|
|
const frame = editor.graph.createNode('FRAME', pageId, {
|
|
x: 200,
|
|
y: 150,
|
|
width: 300,
|
|
height: 300,
|
|
rotation: 30
|
|
})
|
|
const moving = editor.graph.createNode('RECTANGLE', frame.id, {
|
|
x: 20,
|
|
y: 40,
|
|
width: 50,
|
|
height: 50
|
|
})
|
|
editor.select([moving.id])
|
|
editor.state.snappingPreferences = { geometry: true, objects: false, pixelGrid: false }
|
|
const drag = createSelectionMoveDrag(0, 0, 0, 0, editor, false)
|
|
if (drag.type !== 'move') throw new Error('Expected move drag')
|
|
|
|
handleMoveMove(drag, 74, 43, 100, 100, editor)
|
|
|
|
expect(editor.state.snapGuides).toEqual([])
|
|
const angle = (-30 * Math.PI) / 180
|
|
expect(drag.appliedDx).toBeCloseTo(74 * Math.cos(angle) - 43 * Math.sin(angle), 3)
|
|
expect(drag.appliedDy).toBeCloseTo(74 * Math.sin(angle) + 43 * Math.cos(angle), 3)
|
|
})
|
|
|
|
test('stores rounded preview displacement when targeting auto-layout', () => {
|
|
const editor = createEditor()
|
|
const pageId = editor.state.currentPageId
|
|
const moving = editor.graph.createNode('RECTANGLE', pageId, {
|
|
x: 10.25,
|
|
y: 20.25,
|
|
width: 20,
|
|
height: 20
|
|
})
|
|
editor.graph.createNode('FRAME', pageId, {
|
|
x: 100,
|
|
y: 100,
|
|
width: 200,
|
|
height: 100,
|
|
layoutMode: 'HORIZONTAL'
|
|
})
|
|
editor.select([moving.id])
|
|
const drag = createSelectionMoveDrag(10.25, 20.25, 0, 0, editor, false)
|
|
if (drag.type !== 'move') throw new Error('Expected move drag')
|
|
|
|
handleMoveMove(drag, 150.6, 130.7, 10, 10, editor)
|
|
|
|
expect(drag.appliedDx).toBeCloseTo(140.75)
|
|
expect(drag.appliedDy).toBeCloseTo(110.75)
|
|
expect(editor.graph.getNode(moving.id)).toMatchObject({ x: 151, y: 131 })
|
|
})
|
|
|
|
test('removes duplicate created for alt-click without movement', () => {
|
|
const editor = createEditor()
|
|
const pageId = editor.state.currentPageId
|
|
const node = editor.graph.createNode('RECTANGLE', pageId, {
|
|
name: 'Box',
|
|
x: 10,
|
|
y: 20,
|
|
width: 100,
|
|
height: 80
|
|
})
|
|
editor.select([node.id])
|
|
|
|
const drag = createSelectionMoveDrag(10, 20, 100, 200, editor, true)
|
|
if (drag.type !== 'move') throw new Error('Expected move drag')
|
|
expect(editor.graph.getChildren(pageId)).toHaveLength(2)
|
|
|
|
handleMoveUp(drag, editor)
|
|
|
|
expect(editor.graph.getChildren(pageId).map((child) => child.id)).toEqual([node.id])
|
|
expect([...editor.state.selectedIds]).toEqual([node.id])
|
|
})
|
|
})
|