69dba7002f
* fix: validate parsed JSON at untrusted boundaries with Valibot Clipboard HTML, library revisions from shared storage, MCP and automation WebSocket messages, the MCP discovery file, sidecar output and AI/MCP tool arguments were JSON.parse'd and cast to their expected types, so a malformed payload reached the document or crashed paste. They now go through v.pipe(v.string(), v.parseJson(), Schema), which reports bad JSON and a wrong shape as the same validation failure. The path_set tool rejects an invalid VectorNetwork and shares its parser with create_vector. The CLI library catalog validates its files and runs revisions through the same size, identity and content-hash checks as the app; reading image bytes as index-keyed records also stops them coming back empty. Hand-rolled typeof readers for plugin data, document metadata, caches and preferences become schemas with their behaviour preserved, and readCacheJSON takes a schema for its payload. open-pencil/no-unvalidated-json-parse rejects type assertions on JSON.parse results other than `as unknown` in src and packages/*/src. * refactor: validate parsed JSON in tests and tooling Extend open-pencil/no-unvalidated-json-parse beyond source: tests, helpers and repo tooling now parse JSON through Valibot schemas instead of asserting a type. The shared fixture reader returns a validated object; its old array annotation never matched the fixtures. * refactor: define OpenPencil plugin data in one typed registry Every plugin-data key OpenPencil writes is now a field of OPEN_PENCIL_PLUGIN_DATA in scene-graph, with the Valibot schema that reads it; readPluginData and withPluginData replace per-key constants, JSON.parse and hand-matched pluginId/key filters across fig, core, and vue. Moving OkHCL onto it fixes picking a colour rewriting the layer's other plugin data as OkHCL entries.
45 lines
1.3 KiB
TypeScript
45 lines
1.3 KiB
TypeScript
import { describe, expect, test } from 'bun:test'
|
|
|
|
import { applyDocumentMetadata } from '#fig/document/metadata'
|
|
|
|
import {
|
|
OPEN_PENCIL_PLUGIN_DATA,
|
|
OPEN_PENCIL_PLUGIN_ID,
|
|
SceneGraph
|
|
} from '@open-pencil/scene-graph'
|
|
|
|
function enabledLibraries(value: string) {
|
|
const graph = new SceneGraph()
|
|
applyDocumentMetadata(graph, {
|
|
pluginData: [
|
|
{ pluginID: OPEN_PENCIL_PLUGIN_ID, key: OPEN_PENCIL_PLUGIN_DATA.enabledLibraries.key, value }
|
|
]
|
|
})
|
|
return [...graph.enabledLibraries.values()]
|
|
}
|
|
|
|
describe('document metadata', () => {
|
|
test('restores valid enabled libraries and skips invalid entries', () => {
|
|
expect(
|
|
enabledLibraries(
|
|
JSON.stringify([
|
|
{ libraryId: 'design-system', revisionId: 'r1', enabled: true },
|
|
{ libraryId: 'icons', revisionId: 'r2', enabled: 'yes' },
|
|
{ libraryId: 'broken', revisionId: 3 },
|
|
null
|
|
])
|
|
)
|
|
).toEqual([
|
|
{ libraryId: 'design-system', revisionId: 'r1', enabled: true },
|
|
{ libraryId: 'icons', revisionId: 'r2', enabled: false }
|
|
])
|
|
})
|
|
|
|
test('ignores malformed or non-array enabled libraries', () => {
|
|
expect(enabledLibraries('{not json')).toEqual([])
|
|
expect(
|
|
enabledLibraries(JSON.stringify({ libraryId: 'design-system', revisionId: 'r1' }))
|
|
).toEqual([])
|
|
})
|
|
})
|