openpencil/tests/engine/multi-selection.test.ts
Danila Poyarkov 6545f20c53
Refactor architecture boundaries across core, app, and packages (#234)
* refactor(core): decompose editor factory and action modules

Split the monolithic editor factory and large action modules into focused
domain helpers:

- create.ts assembles context through bridge modules (clipboard,
  components, structure, undo) and delegates to graph-reads, graph-events,
  layout-runner, component-sync, and state factory
- structure.ts delegates to group, container-wrap, auto-layout-wrap,
  reorder, and state-toggle helpers
- selection.ts delegates to hit-test, overlays, container navigation,
  and read helpers
- clipboard.ts delegates to subtree-history, images, export, copy,
  fonts, and placement helpers
- shapes.ts delegates to pen actions and section-adopt
- components.ts delegates to focus and instances helpers
- alignment.ts delegates to flip-rotate helper
- text.ts uses explicit TextEditSession for snapshot comparison

New focused modules: nudge, variable-bindings, layout-mode,
page-viewports, tool-registry, color-space

Undo: history/position and history/snapshot helpers, hardened
batch/rollback with nested batch support and configurable limit

* refactor(core): split tool definitions by domain

Split the monolithic tool registry into domain-specific modules:

- read/ — selection, find, pages, fonts, components, nodes, query, jsx
- create/ — basic shapes, components, vector, JSX render
- modify/ — paint, effects, geometry, layout, state, text, update
- structure/ — basic, arrange, batch, hierarchy, replace, tree
- variables/ — bindings, collections, read, values
- vector/ — boolean, path, export, viewport
- analyze/ — colors, typography, spacing, clusters, diff, eval
- describe/ — summaries, tree, roles, layout-issues
- stock-photo/ — providers, requests, apply
- codegen/ — component-map, tokens

Split registry into core/extended tiers; refine schema and AI adapter

* refactor(core): restructure kiwi codec and instance overrides

Reorganize the Kiwi .fig codec into domain subdirectories:

- binary/ — codec, schema, protocol
- fig/ — file, import, parse (core, worker, transfer)
- node-change/ — convert, export-node, serialize, plugin-data
- instance-overrides/ — constraints, dsd, populate, props, resolve,
  symbol-overrides, symbol-props, sync, types

Vendored kiwi-schema/ left isolated

* refactor(core): split profiler, icons, IO, and add subpath exports

Profiler: speedscope-export, capture-session, hud-controller
Icons: api, svg, types, render, create-icons tool
IO: format registry and subpath exports
Canvas/color/text/vector: targeted cleanup

Add deliberate subpath exports: random, xpath, vector, color, canvas,
scene-graph, kiwi, design-jsx, io, tools, editor, layout, canvaskit,
profiler, text, lint, rpc, figma-api, constants

* refactor(vue): decompose canvas input, surface lifecycle, and controls

Canvas surface: gl-surface, kit-loader, render-loop, resize-observer

Canvas input handlers:
- move: drop-target, move-snap, duplicate-drag
- select: select-move, select-hover, select-hit
- resize: resize-rect, resize-vector, resize-start
- transform: rotation, marquee, pan, text-selection
- text-edit: navigation, clipboard, textarea lifecycle
- Shared: click-count, space-key, pan, pan-zoom, draw, raf-scheduler

Editor composition:
- commands split: actions, context, metadata, edit, selection, view
- menu-model split: command-groups, builders, types
- Gradient stop composable reuse in primitive root

Controls: fill, layout, typography, appearance, effects, stroke,
okhcl, prop-scrub, node-props, undo-batch, color-variable-binding
Variables/i18n/document/export helpers

Organize canvas, primitives, controls, editor, and variables into
cohesive module directories with package-local import aliases

Expose MenuActionNode/MenuSeparatorNode from public API

* refactor(app): split document IO, editor session, and automation bridge

Document IO: source-state, naming, writer, reload-source, reload-state,
imported-document, watch-targets, save-targets

Editor session: create, modules, types, accessors, computed, refs
Editor canvas: loader-overlay, collaboration-awareness,
context-selection, menu-actions, menu-model

Automation bridge: eval, tools, exports, files, selection, RPC fallback

AI/ACP: transport, map-update, permission, debug, chat effects/storage
Collab: awareness, graph-bindings, yjs-sync, follow, session, types
Shell keyboard: actions, bindings, clipboard, focus, nudging,
raw-events, registry, reserved, shortcuts, space-tool
Shell menu: app-menu, document-name, entry, files

Demo: colors, effects, helpers, section builders (components,
app-preview, effects, standalone, variables) — document.ts reduced
from 981 to 32 lines as pure orchestrator

Move app modules under src/app/ with organized domain structure:
editor, document, ai, collab, shell, automation, demo, tabs

* refactor(app): decompose UI components with provide/inject context

Split monolithic components using Reka UI-inspired namespace folders
with scoped provide/inject context — no prop drilling:

- CollabPanel/ — context, avatars, share, connected, join
- ColorPickerPanel/ — context, area, format, field groups, sliders
- MobileHud/ — context, action toast, tool badge, file menu, presence
- ProviderSettings/ — context, API key/type, endpoint, tokens, photos
- Toolbar/ — actions, types, desktop, mobile, tool button, flyout
- LayoutSection/ — types, auto-layout, flex, grid, padding, size, clip

Properties helpers: fill-okhcl adapter, fill-label, color-style-row
Menu: entry helpers, document-name rename, stale type removal

* refactor(mcp): split server into focused modules

- browser-rpc — WebSocket client management
- mcp-sessions — session lifecycle
- tool-output — response formatting
- tool-schema — Zod schema generation from ToolDefs
- jsx-preprocess — JSX source transformation
- result — result helpers
- tool-registration — MCP tool wiring
- auth — API key validation
- http-options — CORS/request handling
- stdio-bridge — stdio transport adapter

* refactor(cli): split analyze subcommands and shared helpers

- Analyze subcommands: clusters, colors, spacing, typography
- RPC data loading helper
- Migrate imports to targeted core subpath exports

* refactor(docs): split VitePress config and shared table component

Config helpers: sdk-sidebar, seo, labels, sidebars, locale-theme,
root-theme, locales

Shared SdkDataTable component replaces duplicated table markup in
SdkPropsTable, SdkEventsTable, and SdkSlotsTable

Update contributing and testing docs

* refactor(tauri): decompose desktop entrypoint

Split lib.rs into focused service modules:

- fig_container.rs — .fig archive/compression commands
- fonts.rs — font cache and system font enumeration
- menu.rs — native menu construction
- menu_events.rs — menu event dispatch and devtools toggle
- window.rs — main window show/focus lifecycle

* test: share domain test factories and migrate fixtures

New shared helpers:
- tests/helpers/scene.ts — makeSceneGraph factory
- tests/helpers/vector-network.ts — vertex/segment/network builders
- tests/helpers/fig-traversal.ts — all-node collection, type counts
- tests/helpers/undo.ts — undo test utilities
- tests/helpers/editor-history.ts — editor history test helpers

Migrate render, vector, fig-roundtrip, and undo tests to use shared
factories instead of inline fixture construction

* build: add structural lint rules, split vite config, update docs

Structural lint (oxlint.structure.json + lint/plugin.js):
- 20+ custom rules enforcing package boundaries, lifecycle patterns,
  naming conventions, and import discipline

Vite config split: raw-markdown, canvaskit-assets, pwa, server,
aliases, automation plugins

Remove legacy shims and utils superseded by SDK/core modules
Update AGENTS.md, CONTRIBUTING.md, eval-command docs, tsconfig

* fix(vue): normalize canvas directory casing and remove duplicate export

- Rename Canvas/ to canvas/ in git index to match #vue/canvas/* imports
  (PascalCase was correct for component primitives but canvas/ is a
  non-component domain directory)
- Remove duplicate ./random subpath export in core package.json

* fix: add #vue and #core Vite resolve aliases for dev server

* refactor(core): reduce remaining large modules

Split the remaining large core hotspots into cohesive domain modules while preserving public facades and behavior.

- Extract scene graph types, variables, node defaults, and vector-network helpers
- Decompose canvas renderer orchestration, state, paints, colors, lifecycle, labels, and delegated domain methods into renderer/ and labels/ subfolders
- Split Kiwi node-change, binary variable binding, layout, RPC, vector, JSX export, clipboard, design JSX, and Figma proxy helpers
- Replace collision-driven *Fn import aliases with namespace imports and enforce the pattern in lint

Validation:
- bun run check
- bun --filter @open-pencil/vue build
- bun run test:dupes

* fix(app): forward color input attrs

* fix(app): cover section drawing errors

* fix(editor): undo option-drag duplicates

* docs: document domain subfolder convention

* fix(app): handle undo redo on keydown

* refactor(app): dispatch shortcuts from keydown

* refactor: group prefixed domain modules

* refactor(app): use tinykeys for shortcuts

* refactor(core): group symbol override modules

* refactor(core): group fig kiwi container helper

* refactor(canvas): split overlay rendering modules

* refactor(vue): remove unused internal barrels

* fix(app): lay out demo components before instancing

* fix(app): restore demo badge spacing

* perf(canvas): split scene and overlay rendering

* refactor(vue): wrap wheel gesture lifecycle

* fix(canvas): wait for fonts before hiding loader

* docs: update unreleased changelog
2026-04-30 15:14:19 +03:00

317 lines
10 KiB
TypeScript

import { describe, test, expect } from 'bun:test'
import { SceneGraph } from '@open-pencil/core'
function pageId(graph: SceneGraph) {
return graph.getPages()[0].id
}
function rect(
graph: SceneGraph,
parentId: string,
props: { name?: string; x?: number; y?: number; width?: number; height?: number } = {}
) {
return graph.createNode('RECTANGLE', parentId, {
name: props.name ?? 'Rect',
x: props.x ?? 0,
y: props.y ?? 0,
width: props.width ?? 50,
height: props.height ?? 50
})
}
describe('flip', () => {
test('flipX defaults to false', () => {
const graph = new SceneGraph()
const node = rect(graph, pageId(graph))
expect(node.flipX).toBe(false)
expect(node.flipY).toBe(false)
})
test('flipX can be set via updateNode', () => {
const graph = new SceneGraph()
const node = rect(graph, pageId(graph))
graph.updateNode(node.id, { flipX: true })
expect(graph.getNode(node.id)!.flipX).toBe(true)
expect(graph.getNode(node.id)!.flipY).toBe(false)
})
test('flipY can be set via updateNode', () => {
const graph = new SceneGraph()
const node = rect(graph, pageId(graph))
graph.updateNode(node.id, { flipY: true })
expect(graph.getNode(node.id)!.flipX).toBe(false)
expect(graph.getNode(node.id)!.flipY).toBe(true)
})
test('flip toggles', () => {
const graph = new SceneGraph()
const node = rect(graph, pageId(graph))
graph.updateNode(node.id, { flipX: true })
expect(graph.getNode(node.id)!.flipX).toBe(true)
graph.updateNode(node.id, { flipX: false })
expect(graph.getNode(node.id)!.flipX).toBe(false)
})
})
describe('single-node alignment to parent', () => {
function setup() {
const graph = new SceneGraph()
const frame = graph.createNode('FRAME', pageId(graph), {
name: 'Container',
x: 0,
y: 0,
width: 400,
height: 300
})
const child = rect(graph, frame.id, { name: 'Child', x: 50, y: 50, width: 100, height: 80 })
return { graph, frame, child }
}
test('align left within parent', () => {
const { graph, frame, child } = setup()
graph.updateNode(child.id, { x: 0 })
expect(graph.getNode(child.id)!.x).toBe(0)
})
test('align right within parent', () => {
const { graph, frame, child } = setup()
const targetX = frame.width - child.width
graph.updateNode(child.id, { x: targetX })
expect(graph.getNode(child.id)!.x).toBe(300)
})
test('align center horizontal within parent', () => {
const { graph, frame, child } = setup()
const targetX = (frame.width - child.width) / 2
graph.updateNode(child.id, { x: targetX })
expect(graph.getNode(child.id)!.x).toBe(150)
})
test('align top within parent', () => {
const { graph, child } = setup()
graph.updateNode(child.id, { y: 0 })
expect(graph.getNode(child.id)!.y).toBe(0)
})
test('align bottom within parent', () => {
const { graph, frame, child } = setup()
const targetY = frame.height - child.height
graph.updateNode(child.id, { y: targetY })
expect(graph.getNode(child.id)!.y).toBe(220)
})
test('align center vertical within parent', () => {
const { graph, frame, child } = setup()
const targetY = (frame.height - child.height) / 2
graph.updateNode(child.id, { y: targetY })
expect(graph.getNode(child.id)!.y).toBe(110)
})
})
describe('multi-node alignment', () => {
function setup() {
const graph = new SceneGraph()
const page = pageId(graph)
const a = rect(graph, page, { name: 'A', x: 10, y: 20, width: 50, height: 30 })
const b = rect(graph, page, { name: 'B', x: 100, y: 80, width: 60, height: 40 })
const c = rect(graph, page, { name: 'C', x: 200, y: 50, width: 40, height: 50 })
return { graph, a, b, c }
}
test('align left — all nodes move to min x', () => {
const { graph, a, b, c } = setup()
const nodes = [a, b, c].map((n) => graph.getNode(n.id)!)
const abs = nodes.map((n) => graph.getAbsolutePosition(n.id))
const minX = Math.min(...abs.map((p, i) => p.x))
for (const n of nodes) {
const nodeAbs = graph.getAbsolutePosition(n.id)
graph.updateNode(n.id, { x: n.x + (minX - nodeAbs.x) })
}
expect(graph.getNode(a.id)!.x).toBe(10)
expect(graph.getNode(b.id)!.x).toBe(10)
expect(graph.getNode(c.id)!.x).toBe(10)
})
test('align right — all nodes align to max right edge', () => {
const { graph, a, b, c } = setup()
const nodes = [a, b, c].map((n) => graph.getNode(n.id)!)
const abs = nodes.map((n) => graph.getAbsolutePosition(n.id))
const maxX = Math.max(...abs.map((p, i) => p.x + nodes[i].width))
for (const n of nodes) {
const nodeAbs = graph.getAbsolutePosition(n.id)
const targetX = maxX - n.width
graph.updateNode(n.id, { x: n.x + (targetX - nodeAbs.x) })
}
expect(graph.getNode(a.id)!.x).toBe(190)
expect(graph.getNode(b.id)!.x).toBe(180)
expect(graph.getNode(c.id)!.x).toBe(200)
})
test('align top — all nodes move to min y', () => {
const { graph, a, b, c } = setup()
const nodes = [a, b, c].map((n) => graph.getNode(n.id)!)
const abs = nodes.map((n) => graph.getAbsolutePosition(n.id))
const minY = Math.min(...abs.map((p) => p.y))
for (const n of nodes) {
const nodeAbs = graph.getAbsolutePosition(n.id)
graph.updateNode(n.id, { y: n.y + (minY - nodeAbs.y) })
}
expect(graph.getNode(a.id)!.y).toBe(20)
expect(graph.getNode(b.id)!.y).toBe(20)
expect(graph.getNode(c.id)!.y).toBe(20)
})
})
describe('multi-node property merging', () => {
test('same values merge to single value', () => {
const graph = new SceneGraph()
const page = pageId(graph)
const a = rect(graph, page, { width: 100, height: 50 })
const b = rect(graph, page, { width: 100, height: 50 })
const nodes = [graph.getNode(a.id)!, graph.getNode(b.id)!]
const widths = new Set(nodes.map((n) => n.width))
expect(widths.size).toBe(1)
expect([...widths][0]).toBe(100)
})
test('different values are detected', () => {
const graph = new SceneGraph()
const page = pageId(graph)
const a = rect(graph, page, { width: 100 })
const b = rect(graph, page, { width: 200 })
const nodes = [graph.getNode(a.id)!, graph.getNode(b.id)!]
const widths = new Set(nodes.map((n) => n.width))
expect(widths.size).toBe(2)
})
test('update applies to all selected nodes', () => {
const graph = new SceneGraph()
const page = pageId(graph)
const a = rect(graph, page, { width: 100 })
const b = rect(graph, page, { width: 200 })
const c = rect(graph, page, { width: 150 })
for (const id of [a.id, b.id, c.id]) {
graph.updateNode(id, { width: 300 })
}
expect(graph.getNode(a.id)!.width).toBe(300)
expect(graph.getNode(b.id)!.width).toBe(300)
expect(graph.getNode(c.id)!.width).toBe(300)
})
test('opacity update applies uniformly', () => {
const graph = new SceneGraph()
const page = pageId(graph)
const a = rect(graph, page)
const b = rect(graph, page)
graph.updateNode(a.id, { opacity: 0.5 })
graph.updateNode(b.id, { opacity: 0.8 })
for (const id of [a.id, b.id]) {
graph.updateNode(id, { opacity: 0.75 })
}
expect(graph.getNode(a.id)!.opacity).toBe(0.75)
expect(graph.getNode(b.id)!.opacity).toBe(0.75)
})
test('fills comparison detects mixed', () => {
const graph = new SceneGraph()
const page = pageId(graph)
const a = rect(graph, page)
const b = rect(graph, page)
graph.updateNode(a.id, {
fills: [{ type: 'SOLID', color: { r: 1, g: 0, b: 0, a: 1 }, opacity: 1, visible: true }]
})
graph.updateNode(b.id, {
fills: [{ type: 'SOLID', color: { r: 0, g: 1, b: 0, a: 1 }, opacity: 1, visible: true }]
})
const nodeA = graph.getNode(a.id)!
const nodeB = graph.getNode(b.id)!
expect(JSON.stringify(nodeA.fills)).not.toBe(JSON.stringify(nodeB.fills))
})
test('fills comparison detects same', () => {
const graph = new SceneGraph()
const page = pageId(graph)
const fill = { type: 'SOLID' as const, color: { r: 1, g: 0, b: 0, a: 1 }, opacity: 1, visible: true }
const a = rect(graph, page)
const b = rect(graph, page)
graph.updateNode(a.id, { fills: [{ ...fill }] })
graph.updateNode(b.id, { fills: [{ ...fill }] })
const nodeA = graph.getNode(a.id)!
const nodeB = graph.getNode(b.id)!
expect(JSON.stringify(nodeA.fills)).toBe(JSON.stringify(nodeB.fills))
})
})
describe('flip roundtrip via kiwi', () => {
async function roundtrip(graph: SceneGraph) {
const { initCodec } = await import('#core/kiwi/binary/codec')
const { parseFigFile } = await import('#core/kiwi/fig/file')
const { exportFigFile } = await import('#core/io/formats/fig/export')
await initCodec()
const buf = await exportFigFile(graph)
return parseFigFile(buf)
}
function findChild(graph: SceneGraph, name: string) {
const pages = graph.getPages()
const children = graph.getChildren(pages[0].id)
return children.find((c) => c.name === name)
}
test('flipX preserved through export/import', async () => {
const graph = new SceneGraph()
const page = pageId(graph)
rect(graph, page, { name: 'Flipped', x: 50, y: 50, width: 100, height: 80 })
graph.updateNode(graph.getChildren(page).find((n) => n.name === 'Flipped')!.id, { flipX: true })
const imported = await roundtrip(graph)
const found = findChild(imported, 'Flipped')
expect(found).toBeTruthy()
expect(found!.flipX).toBe(true)
})
test('non-flipped node stays non-flipped', async () => {
const graph = new SceneGraph()
rect(graph, pageId(graph), { name: 'Normal', x: 100, y: 50, width: 200, height: 100 })
const imported = await roundtrip(graph)
const found = findChild(imported, 'Normal')
expect(found).toBeTruthy()
expect(found!.flipX).toBe(false)
})
test('flipX with rotation preserved', async () => {
const graph = new SceneGraph()
const page = pageId(graph)
rect(graph, page, { name: 'RotFlip', x: 0, y: 0, width: 100, height: 100 })
graph.updateNode(graph.getChildren(page).find((n) => n.name === 'RotFlip')!.id, {
flipX: true,
rotation: 45
})
const imported = await roundtrip(graph)
const found = findChild(imported, 'RotFlip')
expect(found).toBeTruthy()
expect(found!.flipX).toBe(true)
expect(Math.round(found!.rotation)).toBe(45)
})
})