openpencil/tests/engine/tools
Danila Poyarkov e2a3aa3f80
fix: validate parsed JSON at untrusted boundaries with Valibot (#855)
* fix: validate parsed JSON at untrusted boundaries with Valibot

Clipboard HTML, library revisions from shared storage, MCP and automation
WebSocket messages, the MCP discovery file, sidecar output and AI/MCP tool
arguments were JSON.parse'd and cast to their expected types, so a
malformed payload reached the document or crashed paste. They now go
through v.pipe(v.string(), v.parseJson(), Schema), which reports bad JSON
and a wrong shape as the same validation failure.

The path_set tool rejects an invalid VectorNetwork and shares its parser
with create_vector. The CLI library catalog validates its files and runs
revisions through the same size, identity and content-hash checks as the
app; reading image bytes as index-keyed records also stops them coming
back empty. Hand-rolled typeof readers for plugin data, document metadata,
caches and preferences become schemas with their behaviour preserved, and
readCacheJSON takes a schema for its payload.

open-pencil/no-unvalidated-json-parse rejects type assertions on
JSON.parse results other than `as unknown` in src and packages/*/src.

* refactor: validate parsed JSON in tests and tooling

Extend open-pencil/no-unvalidated-json-parse beyond source: tests, helpers and repo tooling now parse JSON through Valibot schemas instead of asserting a type. The shared fixture reader returns a validated object; its old array annotation never matched the fixtures.

* fix: validate clipboard geometry bytes, library images and model catalogs

Clipboard geometry blobs and library image bytes must be bytes at contiguous indexes, so out-of-range or gapped values are rejected instead of silently becoming different geometry or images; serialized library nodes must carry source metadata. The models.dev and OpenRouter responses are validated like their cached copies, and activate-tab rejects a CDP frame it cannot read instead of hanging.

* refactor: extend the JSON validation lint to .json() results

no-unvalidated-json-parse now also rejects type assertions on Response, Bun.file and shell .json() results, the same unchecked parse in another form. MCP server tests read /health through a validated readHealth helper and discovery files through parseDiscoveryInfo; the remaining tooling reads its JSON through schemas.

* test: validate the RPC request body in the CLI app export test

* test: validate CLI JSON output in the tool and app command tests

* test: compare the malformed models.dev fallback with the curated list
2026-10-04 17:01:50 +00:00
..
analyze/overlaps feat(scene-graph)!: make a stroke a paint (#864) 2026-10-04 13:38:05 +04:00
calc fix: validate parsed JSON at untrusted boundaries with Valibot (#855) 2026-10-04 17:01:50 +00:00
modify chore: format codebase 2026-05-24 12:15:29 +03:00
stock-photo fix: protect unsaved documents and defer credential access (#713) 2026-09-17 15:25:15 +03:00
xpath test(engine): move root tests into domains 2026-05-16 12:30:27 +03:00
ai-adapter.test.ts feat(ai): show what each AI edit changed in its tool call (#812) 2026-10-03 23:32:37 +04:00
cli.test.ts fix: validate parsed JSON at untrusted boundaries with Valibot (#855) 2026-10-04 17:01:50 +00:00
create.test.ts refactor(tools)!: centralize schemas and execution contracts 2026-09-15 10:55:27 +03:00
describe.test.ts feat(scene-graph)!: make a stroke a paint (#864) 2026-10-04 13:38:05 +04:00
eval-wrap.test.ts refactor(tools): use acorn AST parser for eval wrapping 2026-05-11 12:15:38 +03:00
export-image.test.ts feat(ai): add isolated visual inspection 2026-08-13 21:15:44 +03:00
input.test.ts fix(tools): preserve atomic property state and validate inputs 2026-09-15 16:47:37 +03:00
library-components.test.ts feat: add Figma-style variants and component libraries (#512) 2026-08-14 19:31:41 +03:00
modify.test.ts chore(tests): guard modify tool assertions 2026-05-06 11:20:49 +03:00
read.test.ts ci: shard unit tests by owner and cut the quick suite from 100 s to 13 s (#715) 2026-09-17 10:18:16 +03:00
registry.test.ts refactor(tools): default interface exposure to inclusion 2026-09-15 17:12:31 +03:00
structure.test.ts chore(tests): remove targeted non-null assertions 2026-05-06 03:13:58 +03:00