The PowerPoint, self-contained HTML and slide-per-page PDF exporters shipped in v0.8.3 but were reachable only from the desktop File menu, so an agent could build a deck over MCP and then had no way to hand it to anyone. Add export_deck across all three surfaces. The destination argument is outputPath, not filePath: filePath is reserved workspace-wide for the .op document a call targets and is intercepted before dispatch, so it would route the call at a document that does not exist. The tool writes a file rather than returning base64 — a deck is a multi-megabyte artifact and the caller wants something shareable — which makes it a LocalFilesystem surface, denied on the online /mcp for the same reason save_document is. The CLI resolves a relative --output against the caller's working directory, since the daemon's is not the caller's. Delivery guidance goes in the slides skill rather than deck-contract, which is already at its token budget.
198 lines
4.9 KiB
Rust
198 lines
4.9 KiB
Rust
use super::*;
|
|
use base64::Engine as _;
|
|
|
|
fn args(values: &[&str]) -> Vec<String> {
|
|
values.iter().map(|value| (*value).to_string()).collect()
|
|
}
|
|
|
|
#[test]
|
|
fn export_item_maps_to_dedicated_command() {
|
|
let parsed = parse_args(&args(&[
|
|
"export",
|
|
"--item",
|
|
"page-2",
|
|
"--output",
|
|
"/tmp/page.png",
|
|
"--format",
|
|
"png",
|
|
"--scale",
|
|
"2",
|
|
]))
|
|
.expect("parse export");
|
|
assert_eq!(
|
|
parsed.command,
|
|
Command::Export {
|
|
item_id: Some("page-2".into()),
|
|
selection: false,
|
|
output: "/tmp/page.png".into(),
|
|
format: "png".into(),
|
|
scale: Some("2".into()),
|
|
}
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn export_without_item_means_live_selection() {
|
|
let parsed = parse_args(&args(&[
|
|
"export",
|
|
"--output",
|
|
"/tmp/selected.png",
|
|
"--format",
|
|
"png",
|
|
]))
|
|
.expect("parse selection export");
|
|
assert!(matches!(
|
|
parsed.command,
|
|
Command::Export {
|
|
item_id: None,
|
|
selection: false,
|
|
..
|
|
}
|
|
));
|
|
}
|
|
|
|
#[test]
|
|
fn export_selection_flag_means_live_selection() {
|
|
let parsed = parse_args(&args(&[
|
|
"export",
|
|
"--selection",
|
|
"--output",
|
|
"/tmp/selected.png",
|
|
]))
|
|
.expect("parse --selection export");
|
|
assert!(matches!(
|
|
parsed.command,
|
|
Command::Export {
|
|
item_id: None,
|
|
selection: true,
|
|
..
|
|
}
|
|
));
|
|
}
|
|
|
|
#[test]
|
|
fn export_accepts_issue_formats_alias() {
|
|
let parsed = parse_args(&args(&[
|
|
"export",
|
|
"--item",
|
|
"page-1",
|
|
"--output",
|
|
"/tmp/page.png",
|
|
"--formats",
|
|
"png",
|
|
]))
|
|
.expect("parse --formats alias");
|
|
assert!(matches!(
|
|
parsed.command,
|
|
Command::Export { format, .. } if format == "png"
|
|
));
|
|
}
|
|
|
|
#[test]
|
|
fn export_rejects_conflicting_target_and_format_flags() {
|
|
let target = parse_args(&args(&[
|
|
"export",
|
|
"--item",
|
|
"n1",
|
|
"--selection",
|
|
"--output",
|
|
"/tmp/node.png",
|
|
]));
|
|
assert!(target
|
|
.unwrap_err()
|
|
.to_string()
|
|
.contains("--item and --selection"));
|
|
|
|
let format = parse_args(&args(&[
|
|
"export",
|
|
"--output",
|
|
"/tmp/node.png",
|
|
"--format",
|
|
"png",
|
|
"--formats",
|
|
"jpeg",
|
|
]));
|
|
assert!(format
|
|
.unwrap_err()
|
|
.to_string()
|
|
.contains("--format and --formats"));
|
|
}
|
|
|
|
#[test]
|
|
fn write_export_response_decodes_png_to_exact_path() {
|
|
let path =
|
|
std::env::temp_dir().join(format!("op-cli-export-{}-selected.png", std::process::id()));
|
|
let png = [0x89, b'P', b'N', b'G', 13, 10, 26, 10];
|
|
let response = serde_json::json!({
|
|
"itemId": "n1",
|
|
"itemType": "node",
|
|
"format": "png",
|
|
"bytes_base64": base64::engine::general_purpose::STANDARD.encode(png),
|
|
})
|
|
.to_string();
|
|
|
|
let output = export_cli::write_export_response(&response, &path).expect("write export");
|
|
assert_eq!(std::fs::read(&path).expect("read export"), png);
|
|
assert!(output.contains("\"itemType\":\"node\""), "{output}");
|
|
std::fs::remove_file(path).ok();
|
|
}
|
|
|
|
#[test]
|
|
fn write_export_response_rejects_invalid_payloads() {
|
|
let path = std::env::temp_dir().join("op-cli-export-invalid.png");
|
|
assert!(export_cli::write_export_response("not-json", &path).is_err());
|
|
assert!(export_cli::write_export_response(
|
|
r#"{"itemId":"n1","itemType":"node","format":"png","bytes_base64":"%%%"}"#,
|
|
&path,
|
|
)
|
|
.is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn export_deck_defaults_to_pptx_and_requires_an_output() {
|
|
let parsed = parse_args(&args(&["export-deck", "--output", "/tmp/deck.pptx"]))
|
|
.expect("parse export-deck");
|
|
assert!(matches!(
|
|
parsed.command,
|
|
Command::ExportDeck { ref format, .. } if format == "pptx"
|
|
));
|
|
|
|
// PowerPoint is the format users reach for by name, so it is the default;
|
|
// the other two must still be selectable.
|
|
for format in ["html", "pdf"] {
|
|
let parsed = parse_args(&args(&[
|
|
"export-deck",
|
|
"--output",
|
|
"/tmp/deck.out",
|
|
"--format",
|
|
format,
|
|
]))
|
|
.expect("parse deck format");
|
|
assert!(matches!(
|
|
parsed.command,
|
|
Command::ExportDeck { format: ref parsed_format, .. } if parsed_format == format
|
|
));
|
|
}
|
|
|
|
assert!(parse_args(&args(&["export-deck"]))
|
|
.unwrap_err()
|
|
.to_string()
|
|
.contains("--output"));
|
|
}
|
|
|
|
#[test]
|
|
fn export_deck_rejects_a_node_export_format() {
|
|
// png is valid for `op export` and meaningless for a deck; accepting it
|
|
// would reach the daemon and fail there instead of at the typo.
|
|
let error = parse_args(&args(&[
|
|
"export-deck",
|
|
"--output",
|
|
"/tmp/deck.pptx",
|
|
"--format",
|
|
"png",
|
|
]))
|
|
.unwrap_err()
|
|
.to_string();
|
|
assert!(error.contains("unsupported deck format"), "{error}");
|
|
}
|