aa86873dd7
* build: typecheck the test suites Tests were in no TypeScript program: no tsconfig included tests/** or packages/*/tests/**, and bun strips types without checking them, so a fixture could drop a required field and keep passing until something read it. @types/bun moves to the root because it was installed per package only, and #cli-tests/* joins the paths the root config already carries. * test: fix the type errors the test suites were hiding Typechecking the tests turned up 1123 errors. Most were ordinary strictness, but some were real: `NodeChange` bound to Figma's plugin typings rather than the Kiwi codec in thirteen .fig tests, materializeInstance was called with six arguments against five so the blobs and source children were dropped, CanvasKit pixels were written to a plain object that never reached WASM, and assertions were made through accessors that do not exist, so they asserted nothing. Fixtures that had quietly lost a required field now carry it, nullable results are narrowed through the existing expectDefined helper rather than assumed, and stand-ins for CanvasKit and the editor go through one named helper instead of an unexplained cast at each site. No test was deleted, skipped, or weakened, and no `any`, non-null assertion, or ts-expect-error was introduced. * docs: record what typechecking the tests established Pins the app program's global types with an assertion rather than a note, since an unpinned types list lets any root @types package decide which platform src/** is judged against. The two environment faults that look like code regressions — Vite's dependency pre-bundle outliving a package rebuild, and heavy .fig suites failing under load — go to the development docs, where an explanation belongs. * fix: align @types/bun and keep node types resolvable when extended The root manifest declared a newer @types/bun than every package, which check:monorepo rejects, and pinning the app program's types left them unresolvable from a config that extends this one out of tree. * fix: fail the test typecheck when the compiler itself fails The gate matched diagnostics by substring, so a compiler or config failure that named no test file printed a pass while having checked nothing. Diagnostics are now split by whether they name a file: an unscoped one is the run failing and stops the gate, a test file's is a finding, and a source file's stays out by design. Also drops the parameter planComponentConstruction never read, and makes the inner-shadow verification script exit non-zero when it renders no image instead of logging and succeeding. * chore: merge master into tests-typecheck
93 lines
2.9 KiB
TypeScript
93 lines
2.9 KiB
TypeScript
import { expect, test, useEditorSetup } from '#tests/e2e/fixtures'
|
|
import { CanvasHelper } from '#tests/helpers/canvas'
|
|
|
|
const editor = useEditorSetup()
|
|
|
|
test('autosave triggers after scene changes with a file handle', async () => {
|
|
const writeCount = await editor.page.evaluate(() => {
|
|
let writes = 0
|
|
const mockWritable: Pick<FileSystemWritableFileStream, 'write' | 'close'> = {
|
|
write: async () => {
|
|
writes++
|
|
},
|
|
close: async () => undefined
|
|
}
|
|
const mockHandle = {
|
|
createWritable: async () => mockWritable
|
|
} as FileSystemFileHandle
|
|
|
|
window.openPencil ??= {}
|
|
window.openPencil.test = { writeCount: () => writes, mockHandle }
|
|
|
|
return writes
|
|
})
|
|
|
|
expect(writeCount).toBe(0)
|
|
|
|
// Inject the file handle into the store's internal state
|
|
// We do this by calling a save first to establish the handle
|
|
await editor.page.evaluate(() => {
|
|
// Directly set the fileHandle via a test hook
|
|
// Since fileHandle is a closure variable, we need to trigger the save path
|
|
// The cleanest way: mock showSaveFilePicker to return our handle
|
|
const mockWritable: Pick<FileSystemWritableFileStream, 'write' | 'close'> = {
|
|
write: async () => undefined,
|
|
close: async () => undefined
|
|
}
|
|
const mockHandle = {
|
|
createWritable: async () => mockWritable
|
|
}
|
|
window.showSaveFilePicker = async () => mockHandle as FileSystemFileHandle
|
|
})
|
|
|
|
// Trigger Save As to establish the file handle
|
|
await editor.page.keyboard.press('Meta+Shift+s')
|
|
await editor.page.waitForTimeout(500)
|
|
|
|
// Now draw a shape — this should trigger autosave after 3s
|
|
await editor.canvas.drawRect(400, 400, 60, 60)
|
|
|
|
// Check that the scene version changed
|
|
const versionAfterDraw = await editor.page.evaluate(() => {
|
|
const store = window.openPencil?.getStore?.()
|
|
if (!store) throw new Error('OpenPencil store not initialized')
|
|
return store.state.sceneVersion
|
|
})
|
|
expect(versionAfterDraw).toBeGreaterThan(0)
|
|
|
|
// Wait for autosave debounce (3s) + buffer
|
|
await editor.page.waitForTimeout(4000)
|
|
|
|
// Verify a write happened by checking the mock was called
|
|
const writeHappened = await editor.page.evaluate(() => {
|
|
// The handle's createWritable should have been called
|
|
const handle = window.showSaveFilePicker
|
|
return handle !== undefined
|
|
})
|
|
expect(writeHappened).toBe(true)
|
|
})
|
|
|
|
test('no autosave without file handle', async ({ browser, baseURL }) => {
|
|
const context = await browser.newContext({
|
|
baseURL,
|
|
viewport: { width: 1280, height: 800 },
|
|
deviceScaleFactor: 2
|
|
})
|
|
const freshPage = await context.newPage()
|
|
await freshPage.goto('/')
|
|
const freshCanvas = new CanvasHelper(freshPage)
|
|
await freshCanvas.waitForInit()
|
|
|
|
await freshPage.evaluate(() => {
|
|
Reflect.deleteProperty(window, 'showSaveFilePicker')
|
|
})
|
|
|
|
await freshCanvas.drawRect(100, 100, 50, 50)
|
|
await freshPage.waitForTimeout(4000)
|
|
|
|
freshCanvas.assertNoErrors()
|
|
|
|
await freshPage.close()
|
|
await context.close()
|
|
})
|