e2a3aa3f80
* fix: validate parsed JSON at untrusted boundaries with Valibot Clipboard HTML, library revisions from shared storage, MCP and automation WebSocket messages, the MCP discovery file, sidecar output and AI/MCP tool arguments were JSON.parse'd and cast to their expected types, so a malformed payload reached the document or crashed paste. They now go through v.pipe(v.string(), v.parseJson(), Schema), which reports bad JSON and a wrong shape as the same validation failure. The path_set tool rejects an invalid VectorNetwork and shares its parser with create_vector. The CLI library catalog validates its files and runs revisions through the same size, identity and content-hash checks as the app; reading image bytes as index-keyed records also stops them coming back empty. Hand-rolled typeof readers for plugin data, document metadata, caches and preferences become schemas with their behaviour preserved, and readCacheJSON takes a schema for its payload. open-pencil/no-unvalidated-json-parse rejects type assertions on JSON.parse results other than `as unknown` in src and packages/*/src. * refactor: validate parsed JSON in tests and tooling Extend open-pencil/no-unvalidated-json-parse beyond source: tests, helpers and repo tooling now parse JSON through Valibot schemas instead of asserting a type. The shared fixture reader returns a validated object; its old array annotation never matched the fixtures. * fix: validate clipboard geometry bytes, library images and model catalogs Clipboard geometry blobs and library image bytes must be bytes at contiguous indexes, so out-of-range or gapped values are rejected instead of silently becoming different geometry or images; serialized library nodes must carry source metadata. The models.dev and OpenRouter responses are validated like their cached copies, and activate-tab rejects a CDP frame it cannot read instead of hanging. * refactor: extend the JSON validation lint to .json() results no-unvalidated-json-parse now also rejects type assertions on Response, Bun.file and shell .json() results, the same unchecked parse in another form. MCP server tests read /health through a validated readHealth helper and discovery files through parseDiscoveryInfo; the remaining tooling reads its JSON through schemas. * test: validate the RPC request body in the CLI app export test * test: validate CLI JSON output in the tool and app command tests * test: compare the malformed models.dev fallback with the curated list
44 lines
1.4 KiB
TypeScript
44 lines
1.4 KiB
TypeScript
import { expect, test } from 'bun:test'
|
|
|
|
import { encode } from 'js-base64'
|
|
|
|
import { encodeFigmaClipboard, parseFigmaClipboard } from '@open-pencil/fig/clipboard'
|
|
import { initCodec } from '@open-pencil/kiwi/fig/codec'
|
|
|
|
test('Fig clipboard codec preserves prepared node changes and binary blobs', async () => {
|
|
await initCodec()
|
|
const bytes = new Uint8Array([0, 1, 127, 255])
|
|
const html = encodeFigmaClipboard(
|
|
[
|
|
{
|
|
guid: { sessionID: 0, localID: 10 },
|
|
type: 'RECTANGLE',
|
|
name: 'Prepared rectangle',
|
|
size: { x: 100, y: 80 }
|
|
}
|
|
],
|
|
[bytes],
|
|
123
|
|
)
|
|
const parsed = await parseFigmaClipboard(html)
|
|
expect(parsed?.meta).toEqual({ fileKey: 'openpencil', pasteID: 123, dataType: 'scene' })
|
|
expect(parsed?.nodes[0]).toMatchObject({ name: 'Prepared rectangle', size: { x: 100, y: 80 } })
|
|
expect(parsed?.blobs[0]).toEqual(bytes)
|
|
expect(parsed?.blobs[0]).toBeInstanceOf(Uint8Array)
|
|
})
|
|
|
|
test('Fig clipboard with malformed or mistyped metadata is ignored', async () => {
|
|
await initCodec()
|
|
const html = encodeFigmaClipboard([], [], 123)
|
|
for (const meta of [
|
|
'{not json',
|
|
JSON.stringify({ fileKey: 42, pasteID: 123, dataType: 'scene' })
|
|
]) {
|
|
const tampered = html.replace(
|
|
/\(figmeta\).*?\(\/figmeta\)/,
|
|
`(figmeta)${encode(meta)}(/figmeta)`
|
|
)
|
|
expect(await parseFigmaClipboard(tampered)).toBeNull()
|
|
}
|
|
})
|