openpencil/tests/engine/app/tabs/open-file-dedup.test.ts
Danila Poyarkov aa86873dd7
test: typecheck the test suites and fix what that found (#896)
* build: typecheck the test suites

Tests were in no TypeScript program: no tsconfig included tests/** or
packages/*/tests/**, and bun strips types without checking them, so a
fixture could drop a required field and keep passing until something
read it.

@types/bun moves to the root because it was installed per package only,
and #cli-tests/* joins the paths the root config already carries.

* test: fix the type errors the test suites were hiding

Typechecking the tests turned up 1123 errors. Most were ordinary
strictness, but some were real: `NodeChange` bound to Figma's plugin
typings rather than the Kiwi codec in thirteen .fig tests,
materializeInstance was called with six arguments against five so the
blobs and source children were dropped, CanvasKit pixels were written
to a plain object that never reached WASM, and assertions were made
through accessors that do not exist, so they asserted nothing.

Fixtures that had quietly lost a required field now carry it, nullable
results are narrowed through the existing expectDefined helper rather
than assumed, and stand-ins for CanvasKit and the editor go through one
named helper instead of an unexplained cast at each site.

No test was deleted, skipped, or weakened, and no `any`, non-null
assertion, or ts-expect-error was introduced.

* docs: record what typechecking the tests established

Pins the app program's global types with an assertion rather than a
note, since an unpinned types list lets any root @types package decide
which platform src/** is judged against.

The two environment faults that look like code regressions — Vite's
dependency pre-bundle outliving a package rebuild, and heavy .fig
suites failing under load — go to the development docs, where an
explanation belongs.

* fix: align @types/bun and keep node types resolvable when extended

The root manifest declared a newer @types/bun than every package, which
check:monorepo rejects, and pinning the app program's types left them
unresolvable from a config that extends this one out of tree.

* fix: fail the test typecheck when the compiler itself fails

The gate matched diagnostics by substring, so a compiler or config
failure that named no test file printed a pass while having checked
nothing. Diagnostics are now split by whether they name a file: an
unscoped one is the run failing and stops the gate, a test file's is a
finding, and a source file's stays out by design.

Also drops the parameter planComponentConstruction never read, and
makes the inner-shadow verification script exit non-zero when it
renders no image instead of logging and succeeding.

* chore: merge master into tests-typecheck
2026-10-05 12:42:38 +00:00

285 lines
9.9 KiB
TypeScript

import { afterEach, beforeEach, describe, expect, test, vi } from 'bun:test'
import * as figModule from '@open-pencil/core/io/formats/fig'
import * as layoutModule from '@open-pencil/core/layout'
import { SceneGraph } from '@open-pencil/scene-graph'
import { resolveBrowserFileURL } from '@/app/document/io/browser'
import type { DocumentSourceIdentity } from '@/app/document/io/types'
import {
createDocumentInCurrentTab,
createHomeTab,
createTab,
getActiveStore,
getTabsSnapshot,
openFileInNewTab,
showNewTab,
tabCount
} from '@/app/tabs'
import { fileIdentitiesMatch, findTabByFileIdentity } from '@/app/tabs/open/identity'
import { expectDefined } from '#tests/helpers/assert'
function setupGlobals() {
Reflect.defineProperty(globalThis, 'window', {
value: {
innerWidth: 1024,
innerHeight: 768,
requestAnimationFrame: (callback: FrameRequestCallback) => {
callback(0)
return 0
},
cancelAnimationFrame: vi.fn(),
openPencil: {},
location: { href: 'http://localhost/' },
addEventListener: vi.fn(),
removeEventListener: vi.fn()
},
configurable: true,
writable: true
})
Reflect.defineProperty(globalThis, 'document', {
value: { fonts: { add: vi.fn(), ready: Promise.resolve() } },
configurable: true,
writable: true
})
globalThis.requestAnimationFrame = window.requestAnimationFrame
globalThis.cancelAnimationFrame = window.cancelAnimationFrame
}
function acknowledgePendingPresentation(): void {
for (const tab of getTabsSnapshot()) {
if (tab.store.state.preparation?.phase !== 'preparing-render') continue
tab.store.preparationController.acknowledgePresentation(tab.store.state.sceneVersion)
}
}
type FileOpenOutcome = { status: 'fulfilled' } | { status: 'rejected'; reason: unknown }
async function settleFileOpen(opening: Promise<void>): Promise<void> {
const outcome: Promise<FileOpenOutcome> = opening.then(
() => ({ status: 'fulfilled' }),
(reason: unknown) => ({ status: 'rejected', reason })
)
const awaitOutcome = async (): Promise<FileOpenOutcome> => {
acknowledgePendingPresentation()
const result = await Promise.race([
outcome,
new Promise<null>((resolve) => {
setTimeout(resolve, 0)
})
])
return result ?? awaitOutcome()
}
const result = await awaitOutcome()
if (result.status === 'rejected') throw result.reason
}
function makeHandle(
name: string,
isSameEntry: (other: FileSystemFileHandle) => Promise<boolean>
): FileSystemFileHandle {
return { kind: 'file', name, isSameEntry } as FileSystemFileHandle
}
describe('file identity', () => {
test('matches equivalent handles without using file names as identity', async () => {
const stored = makeHandle('design.fig', async (other) => other.name === 'alias.fig')
const alias = makeHandle('alias.fig', async () => false)
const sameName = makeHandle('design.fig', async () => false)
await expect(
fileIdentitiesMatch({ handle: stored, path: null }, { handle: alias, path: null })
).resolves.toBe(true)
await expect(
fileIdentitiesMatch({ handle: stored, path: null }, { handle: sameName, path: null })
).resolves.toBe(false)
})
test('ignores an asynchronous handle match after the tab source changes', async () => {
const comparison = Promise.withResolvers<boolean>()
const started = Promise.withResolvers<undefined>()
const storedHandle = makeHandle('stored.fig', async () => {
started.resolve(undefined)
return comparison.promise
})
const incomingHandle = makeHandle('incoming.fig', async () => false)
let storedIdentity: DocumentSourceIdentity = { handle: storedHandle, path: null }
const tab = { store: { getSourceIdentity: () => storedIdentity } }
const finding = findTabByFileIdentity([tab], {
handle: incomingHandle,
path: null
})
await started.promise
storedIdentity = { handle: storedHandle, path: '/other.fig' }
comparison.resolve(true)
await expect(finding).resolves.toBeNull()
})
test('finds a tab by path and ignores tabs without stable identity', async () => {
const matchedIdentity = { handle: null, path: '/tmp/design.fig' }
const matched = {
store: { getSourceIdentity: () => matchedIdentity }
}
const unidentifiedIdentity = { handle: null, path: null }
const unidentified = {
store: { getSourceIdentity: () => unidentifiedIdentity }
}
await expect(
findTabByFileIdentity([unidentified, matched], {
handle: null,
path: '/tmp/design.fig'
})
).resolves.toBe(matched)
await expect(
findTabByFileIdentity([unidentified], { handle: null, path: null })
).resolves.toBeNull()
})
})
describe('openFileInNewTab deduplication', () => {
beforeEach(() => {
setupGlobals()
vi.spyOn(layoutModule, 'computeAllLayouts').mockReturnValue(undefined)
vi.spyOn(figModule, 'readFigFile').mockResolvedValue(new SceneGraph())
createTab()
})
afterEach(() => {
vi.restoreAllMocks()
Reflect.deleteProperty(globalThis, 'window')
Reflect.deleteProperty(globalThis, 'document')
Reflect.deleteProperty(globalThis, 'requestAnimationFrame')
Reflect.deleteProperty(globalThis, 'cancelAnimationFrame')
})
test('canonicalizes browser URLs before using them as file identity', () => {
expect(resolveBrowserFileURL('/design.fig#selection').href).toBe('http://localhost/design.fig')
})
test('reuses the existing New tab when navigating to the files workspace', () => {
const initialCount = tabCount()
const initialHomeCount = getTabsSnapshot().filter((tab) => tab.kind === 'home').length
showNewTab()
showNewTab()
expect(tabCount()).toBe(initialCount + (initialHomeCount === 0 ? 1 : 0))
expect(getTabsSnapshot().filter((tab) => tab.kind === 'home')).toHaveLength(1)
})
test('converts the current New tab into a blank document', () => {
createHomeTab()
const home = getTabsSnapshot().at(-1)
const count = tabCount()
const document = createDocumentInCurrentTab()
expect(tabCount()).toBe(count)
expect(document.id).toBe(expectDefined(home, 'home tab').id)
expect(document.kind).toBe('document')
})
test('opens a file in the current New tab', async () => {
createHomeTab()
const home = getTabsSnapshot().at(-1)
const count = tabCount()
await settleFileOpen(
openFileInNewTab(new File([], 'design.fig'), undefined, '/tmp/from-home.fig')
)
expect(tabCount()).toBe(count)
expect(getTabsSnapshot().at(-1)?.id).toBe(home?.id)
expect(getTabsSnapshot().at(-1)?.kind).toBe('document')
})
test('activates the existing tab when the same path is opened again', async () => {
const initialCount = tabCount()
const file = new File([], 'design.fig')
await settleFileOpen(openFileInNewTab(file, undefined, '/tmp/design.fig'))
const openedStore = getActiveStore()
await settleFileOpen(openFileInNewTab(file, undefined, '/tmp/design.fig'))
expect(tabCount()).toBe(initialCount)
expect(getActiveStore()).toBe(openedStore)
expect(figModule.readFigFile).toHaveBeenCalledTimes(1)
})
test('shares one load between concurrent opens of the same path', async () => {
const started = Promise.withResolvers<undefined>()
const read = Promise.withResolvers<SceneGraph>()
;(figModule.readFigFile as ReturnType<typeof vi.fn>).mockImplementation(() => {
started.resolve(undefined)
return read.promise
})
const initialCount = tabCount()
const file = new File([], 'concurrent.fig')
const first = openFileInNewTab(file, undefined, '/tmp/concurrent.fig')
await started.promise
const second = openFileInNewTab(file, undefined, '/tmp/concurrent.fig')
await Promise.resolve()
expect(figModule.readFigFile).toHaveBeenCalledTimes(1)
read.resolve(new SceneGraph())
await Promise.all([settleFileOpen(first), settleFileOpen(second)])
expect(tabCount()).toBe(initialCount)
})
test('allows different files to load concurrently', async () => {
const reads = [Promise.withResolvers<SceneGraph>(), Promise.withResolvers<SceneGraph>()]
const bothStarted = Promise.withResolvers<undefined>()
let readIndex = 0
;(figModule.readFigFile as ReturnType<typeof vi.fn>).mockImplementation(() => {
const read = reads[readIndex++]
if (readIndex === 2) bothStarted.resolve(undefined)
return read?.promise ?? Promise.resolve(new SceneGraph())
})
const initialCount = tabCount()
const first = openFileInNewTab(new File([], 'first.fig'), undefined, '/tmp/first.fig')
const second = openFileInNewTab(new File([], 'second.fig'), undefined, '/tmp/second.fig')
await bothStarted.promise
expect(figModule.readFigFile).toHaveBeenCalledTimes(2)
reads[0].resolve(new SceneGraph())
reads[1].resolve(new SceneGraph())
await Promise.all([settleFileOpen(first), settleFileOpen(second)])
expect(tabCount()).toBe(initialCount + 1)
})
test('removes a failed pending open so the file can be retried', async () => {
;(figModule.readFigFile as ReturnType<typeof vi.fn>)
.mockRejectedValueOnce(new Error('read failed'))
.mockResolvedValueOnce(new SceneGraph())
await expect(
settleFileOpen(openFileInNewTab(new File([], 'retry.fig'), undefined, '/tmp/retry.fig'))
).rejects.toThrow('read failed')
await expect(
settleFileOpen(openFileInNewTab(new File([], 'retry.fig'), undefined, '/tmp/retry.fig'))
).resolves.toBeUndefined()
expect(figModule.readFigFile).toHaveBeenCalledTimes(2)
expect(getActiveStore().getSourceIdentity().path).toBe('/tmp/retry.fig')
})
test('keeps same-named files distinct without a path or handle', async () => {
const initialCount = tabCount()
const file = new File([], 'same-name.fig')
await settleFileOpen(openFileInNewTab(file))
await settleFileOpen(openFileInNewTab(file))
expect(tabCount()).toBe(initialCount + 1)
expect(figModule.readFigFile).toHaveBeenCalledTimes(2)
})
})