openpencil

SemianiakaVY/openpencil

Fork 0

Commit graph

Author	SHA1	Message	Date
Fini	d435fc53a7	Merge branch 'v0.8.0' of github.com:ZSeven-W/openpencil into v0.8.0	2026-05-10 21:37:11 +08:00
Kayshen-X	484c6032b8	feat(shell): step 4-6 chrome — TS-equivalent editor UI + interactions Step 4 (visual lift): - Theme tokens (shadcn-dark palette) in shell-core - Lucide-style icons via stroke_svg_path (skia parse_path::from_svg) - Vertical Toolbar / sectioned LayerPanel (Pages + Layers) / TopBar / floating StatusBar / floating AIChatPanel widgets - Native + web backends: stroke_line / fill_round_rect / stroke_round_rect / stroke_svg_path primitives - CJK fallback typeface: cached PingFang/Noto-CJK on native via match_family_style_character; embedded NotoSansCJK-Subset (8.7 KB) on web alongside Roboto Step 5 (infinite canvas + AI chat input): - Document.viewport (pan + zoom 10–800%) with cursor-centered zoom_at + Hand-tool drag pan + dotted background grid - Trackpad PixelDelta → pan, LineDelta / pinch / Cmd+swipe → zoom (winit MouseScrollDelta + PinchGesture + Modifiers) - Document.chat (input / messages / focused / collapsed / 4-corner anchor) — WidgetHost wires apply_text / apply_backspace / apply_send + DOM keydown listener - AI chat panel drag → 4-corner snap via ChatAnchor::nearest - Collapsed mode: compact pill (MessageSquare + "New Chat" + ChevronUp), entire pill click expands Step 6 (RightPanel + chrome polish): - PropertyPanel rewrite: 设计/代码 tabs, 创建组件, 位置, 弹性布局, 尺寸, 图层, 填充, 描边, 效果, 导出 — file split into property_panel.rs + property_panel_sections.rs (under 800 ea.) - Node::aggregate_bounds for Group / unbounded containers so the panel reports child-union W/H instead of 0×0 - TopBar PanelLeft button toggles Document.ui.sidebar_open - Click empty canvas clears selection (collapses RightPanel) - Native font cache (Roboto + system CJK typeface) bypasses jian-skia textlayout: chrome paint 605 ms → sub-ms Hit-test order = paint order reversed (chat → toolbar → layer panel → canvas) so the topmost overlay always wins, plus toolbar bounding-rect consumes gap clicks so they don't fall through. 64 lib tests + 21 widgets_static green; native + web cargo check clean. Web wasm rebuild gated on EMSDK (tools/check-wasm-bundle.sh runs the bundle ceiling guard).	2026-05-10 17:07:59 +08:00
Fini	761c5202e2	fix(ai): retune contrast thresholds to 2.5/2.0 — kill 35/41 false positives Replayed the 2026-05-08-rank4-gpt55 corpus (104 GPT-5.5 dashboard outputs, 95 applied) through the new detectTextBgContrast and got 41 hits — 43% of designs flagged. Sampling showed almost all of them were industry-standard Tailwind palettes used as intentional tertiary text: - #94A3B8 (slate-400) caption on #FFFFFF, ratio 2.56 ← Linear/Vercel/Notion - #2563EB (blue-600) chip on #DBEAFE, ratio 4.24 ← shadcn/ui tag pattern - #10B981 (emerald-500) delta on #FFFFFF, ratio 2.54 ← stat-positive pattern - #64748B (slate-500) row text on #F1F5F9, ratio 4.34 ← muted-row pattern WCAG-AA 4.5:1 is a compliance threshold, not a design-diagnosis threshold. The user-reported pain point is "white-on-cream" (1.10:1) and "white-on-white" (1.0:1) — disasters that read as obviously broken to anyone, not borderline-WCAG cases that production designers ship on purpose. Drop default normalThreshold to 2.5 and largeThreshold to 2.0. Open both as opts so callers needing a stricter audit (e.g. compliance report) can bring back WCAG-AA without re-implementing the walk. Replay confirms the new thresholds: - 41 hits → 6 hits (signal-to-noise from 50% to 0% on the sample) - All 6 remaining are true positives: * 3 × slate-400 on slate-100 (caption color used on a non-white bg — designer mis-paired the palette) * 3 × white initial on amber-500 avatar (the readability gap the industry routinely ignores; legitimately worth flagging) Codex review (a47ef892f72a2d315) confirmed the direction, the specific numeric pair (2.5 not 3.0 — 3.0 still hits slate-400 at 2.56), parameterization over a mode-flag, and keeping severity at info-only. Side-quest: scripts/ab-corpus/replay-detectors.ts + inspect-contrast-hits.ts ship with this commit so the next detector calibration doesn't have to rebuild the harness from scratch.	2026-05-10 14:45:00 +08:00

Author

SHA1

Message

Date

Fini

d435fc53a7

Merge branch 'v0.8.0' of github.com:ZSeven-W/openpencil into v0.8.0

2026-05-10 21:37:11 +08:00

Kayshen-X

484c6032b8

feat(shell): step 4-6 chrome — TS-equivalent editor UI + interactions

Step 4 (visual lift):
- Theme tokens (shadcn-dark palette) in shell-core
- Lucide-style icons via stroke_svg_path (skia parse_path::from_svg)
- Vertical Toolbar / sectioned LayerPanel (Pages + Layers) /
  TopBar / floating StatusBar / floating AIChatPanel widgets
- Native + web backends: stroke_line / fill_round_rect /
  stroke_round_rect / stroke_svg_path primitives
- CJK fallback typeface: cached PingFang/Noto-CJK on native via
  match_family_style_character; embedded NotoSansCJK-Subset
  (8.7 KB) on web alongside Roboto

Step 5 (infinite canvas + AI chat input):
- Document.viewport (pan + zoom 10–800%) with cursor-centered
  zoom_at + Hand-tool drag pan + dotted background grid
- Trackpad PixelDelta → pan, LineDelta / pinch / Cmd+swipe →
  zoom (winit MouseScrollDelta + PinchGesture + Modifiers)
- Document.chat (input / messages / focused / collapsed /
  4-corner anchor) — WidgetHost wires apply_text /
  apply_backspace / apply_send + DOM keydown listener
- AI chat panel drag → 4-corner snap via ChatAnchor::nearest
- Collapsed mode: compact pill (MessageSquare + "New Chat" +
  ChevronUp), entire pill click expands

Step 6 (RightPanel + chrome polish):
- PropertyPanel rewrite: 设计/代码 tabs, 创建组件, 位置, 弹性布局,
  尺寸, 图层, 填充, 描边, 效果, 导出 — file split into
  property_panel.rs + property_panel_sections.rs (under 800 ea.)
- Node::aggregate_bounds for Group / unbounded containers so
  the panel reports child-union W/H instead of 0×0
- TopBar PanelLeft button toggles Document.ui.sidebar_open
- Click empty canvas clears selection (collapses RightPanel)
- Native font cache (Roboto + system CJK typeface) bypasses
  jian-skia textlayout: chrome paint 605 ms → sub-ms

Hit-test order = paint order reversed (chat → toolbar → layer
panel → canvas) so the topmost overlay always wins, plus
toolbar bounding-rect consumes gap clicks so they don't fall
through.

64 lib tests + 21 widgets_static green; native + web
cargo check clean. Web wasm rebuild gated on EMSDK
(tools/check-wasm-bundle.sh runs the bundle ceiling guard).

2026-05-10 17:07:59 +08:00

Fini

761c5202e2

fix(ai): retune contrast thresholds to 2.5/2.0 — kill 35/41 false positives

Replayed the 2026-05-08-rank4-gpt55 corpus (104 GPT-5.5 dashboard
outputs, 95 applied) through the new detectTextBgContrast and got
41 hits — 43% of designs flagged. Sampling showed almost all of them
were industry-standard Tailwind palettes used as intentional tertiary
text:

  - #94A3B8 (slate-400) caption on #FFFFFF, ratio 2.56  ← Linear/Vercel/Notion
  - #2563EB (blue-600) chip on #DBEAFE, ratio 4.24      ← shadcn/ui tag pattern
  - #10B981 (emerald-500) delta on #FFFFFF, ratio 2.54  ← stat-positive pattern
  - #64748B (slate-500) row text on #F1F5F9, ratio 4.34 ← muted-row pattern

WCAG-AA 4.5:1 is a compliance threshold, not a design-diagnosis
threshold. The user-reported pain point is "white-on-cream" (1.10:1)
and "white-on-white" (1.0:1) — disasters that read as obviously broken
to anyone, not borderline-WCAG cases that production designers ship
on purpose.

Drop default normalThreshold to 2.5 and largeThreshold to 2.0. Open
both as opts so callers needing a stricter audit (e.g. compliance
report) can bring back WCAG-AA without re-implementing the walk.

Replay confirms the new thresholds:
  - 41 hits → 6 hits (signal-to-noise from 50% to 0% on the sample)
  - All 6 remaining are true positives:
    * 3 × slate-400 on slate-100 (caption color used on a non-white
      bg — designer mis-paired the palette)
    * 3 × white initial on amber-500 avatar (the readability gap the
      industry routinely ignores; legitimately worth flagging)

Codex review (a47ef892f72a2d315) confirmed the direction, the
specific numeric pair (2.5 not 3.0 — 3.0 still hits slate-400 at 2.56),
parameterization over a mode-flag, and keeping severity at info-only.

Side-quest: scripts/ab-corpus/replay-detectors.ts +
inspect-contrast-hits.ts ship with this commit so the next detector
calibration doesn't have to rebuild the harness from scratch.

2026-05-10 14:45:00 +08:00

3 commits