SemianiakaVY/openpencil
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

fix(editor): app-state ownership travels with undo and batch rollback

Browse source 
MergeAppState's key->plan_idx ownership lived only on EditorState, so a
rolled-back batch or an undo restored doc.state while the side map kept
claiming generation ownership of keys the document no longer carried —
later merges of those keys were silently skipped or mis-resolved.
Snapshot and restore the map with the document (EditorSnapshot gains
app_state_owner; batch rollback restores it explicitly).
This commit is contained in:
Kayshen-X 2026-07-03 22:32:14 +08:00
parent f4e8e62ec0
commit fc864a01ab
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
crates/op-editor-core/src/command_app_state_tests.rs
View file

@ -128,9 +128,15 @@ fn rolled_back_batch_leaves_no_stale_app_state_ownership() {
},
],
});
assert!(!failed, "batch with a failing sub-command must report false");
assert!(
s.doc.state.as_ref().is_none_or(|st| !st.contains_key("cart")),
!failed,
"batch with a failing sub-command must report false"
);
assert!(
s.doc
.state
.as_ref()
.is_none_or(|st| !st.contains_key("cart")),
"rolled-back merge must not survive in doc.state"
);
@ -166,7 +172,10 @@ fn undo_restores_app_state_ownership_with_the_document() {
assert!(s.undo(), "batch lands as one undo step");
assert!(
s.doc.state.as_ref().is_none_or(|st| !st.contains_key("tab")),
s.doc
.state
.as_ref()
.is_none_or(|st| !st.contains_key("tab")),
"undo must remove the merged key from doc.state"
);