SemianiakaVY/openpencil
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

fix(desktop): restore windows deps and gate mac-only test imports

Browse source 
Adding the SIGTERM handler had introduced the cfg(unix) dependency
section above five cross-platform dependencies, silently making zip,
memmap2, glam, dirs, and skia-safe unix-only — invisible on mac/linux
gates, fatal on the windows runner. Only libc belongs in that section.
The complex-script test file's shared imports and constant now carry
the same macOS gate as every test in it, so linux clippy stops flagging
them as dead.
This commit is contained in:
Kayshen-X 2026-08-09 00:54:48 +08:00
parent af15f6cdee
commit f7afc554f6
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/op-host-native/src/backend/skia/complex_script_tests.rs
View file

@ -8,9 +8,15 @@
//! assert against system typefaces, and a bare Linux CI box has no Arabic
//! face to resolve.
// Everything below is macOS-gated (see the module note), so the shared
// imports and constant must carry the same gate or non-mac builds flag
// them as unused under -D warnings.
#[cfg(target_os = "macos")]
use super::*;
#[cfg(target_os = "macos")]
use op_editor_ui::TextLayout;
#[cfg(target_os = "macos")]
const SIZE: f32 = 40.0;
/// Raw unshaped width — skia's default per-codepoint advances with no

11
crates/op-host-services/Cargo.toml
View file

@ -77,11 +77,6 @@ getrandom = "0.3"
hmac = "0.12"
sha2 = "0.10"
# Unix signal handling for the online daemon's controlled shutdown. Already in
# the dependency graph transitively; named here so the SIGTERM handler can use
# it directly. Unix-only — the online daemon is a container deployment.
[target.'cfg(unix)'.dependencies]
libc = "0.2"
zip = "2"
memmap2 = "0.9"
glam = { version = "0.29", default-features = false, features = ["std"] }
@ -94,6 +89,12 @@ skia-safe = { version = "0.97.0", default-features = false, features = [
"pdf",
] }
# Unix signal handling for the online daemon's controlled shutdown. Already in
# the dependency graph transitively; named here so the SIGTERM handler can use
# it directly. Unix-only — the online daemon is a container deployment.
[target.'cfg(unix)'.dependencies]
libc = "0.2"
[dev-dependencies]
# Controlled collaboration fixtures so the collab_state tests can drive the
# real begin -> install -> reject/fail path instead of asserting on a