SemianiakaVY/openpencil
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

docs(shell-core): refresh property_panel_visible doc-comment

Browse source 
Stale comment said "multi-select hides pending an aggregated-
properties UI" — the aggregated UI landed in 8d51b110 and was
hardened in 38ad5a47, so the comment now contradicts the
implementation. Updated to describe the actual unified gate.
This commit is contained in:
Kayshen-X 2026-05-12 02:54:50 +08:00
parent 59c0c2b667
commit c62709584d
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
crates/openpencil-shell-core/src/document/mutators.rs
View file

@ -356,14 +356,10 @@ impl Document {
/// paint. Single source of truth so the host's
/// `canvas_region` math, the panel's `for_selection_at`
/// gate, and `apply_press` commit-on-blur all stay in lock-
/// step. Today: single-select with a resolvable anchor.
/// Multi-select hides pending an aggregated-properties UI;
/// stale single anchors (e.g. selection points at a node on
/// a non-active page, or an id that's been removed) hide too
/// since the panel itself returns `None` from
/// `for_selection_at` in that case (codex stop-hook fix:
/// reserving the rail when the panel won't paint left a
/// blank strip).
/// step. Visible when at least one id in `selected_set`
/// resolves on the active page — same gate for single and
/// multi-select (multi-select paints an aggregate snapshot
/// via `NodeSnapshot::from_multi_selection`).
pub fn property_panel_visible(&self) -> bool {
// Single + multi treat 0x0 nodes identically: panel shows
// as long as at least one id resolves on the active page.