SemianiakaVY/openpencil
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

fix(ui): keep select triggers unwrapped

Browse source
This commit is contained in:
Danila Poyarkov 2026-07-01 07:53:40 +03:00
parent 2689462ca3
commit bcf18b8022
2 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/components/ui/AppSelect.vue
View file

@ -49,12 +49,10 @@ const indicator = ui?.indicator ?? 'absolute left-1.5 inline-flex items-center j
<template>
<SelectRoot v-model="modelValue">
<Tip :label="label" :disabled="!label">
<SelectTrigger v-test-id="testId" :class="select.trigger">
<SelectValue :placeholder="placeholder" />
<icon-lucide-chevron-down class="ml-1 size-3 shrink-0 text-muted" />
</SelectTrigger>
</Tip>
<SelectTrigger v-test-id="testId" :class="select.trigger" :aria-label="label" :title="label">
<SelectValue :placeholder="placeholder" />
<icon-lucide-chevron-down class="ml-1 size-3 shrink-0 text-muted" />
</SelectTrigger>
<SelectPortal>
<SelectContent position="popper" :side-offset="2" :class="select.content">
<SelectViewport :class="viewport">

9
tests/e2e/export/basic.spec.ts
View file

@ -104,13 +104,14 @@ test('remove export row decreases row count', async () => {
test('format selector changes to JPG', async () => {
const formatTrigger = exportItems().first().getByTestId('app-select-trigger').last()
await formatTrigger.hover()
await expect(page.locator('[role=tooltip]').filter({ hasText: 'Export format' })).toBeVisible()
await expect(formatTrigger).toHaveAttribute('aria-label', 'Export format')
await formatTrigger.click()
await expect(page.locator('[role=tooltip]').filter({ hasText: 'Export format' })).toHaveCount(0)
for (const label of ['PNG', 'JPG', 'WEBP', 'SVG', 'PDF']) {
await expect(page.locator('[role="option"]').filter({ hasText: label })).toBeVisible()
}
const jpgOption = page.locator('[role="option"]').filter({ hasText: 'JPG' })
await expect(jpgOption).toBeVisible()
await expectInViewport(page, jpgOption)
await jpgOption.click()
await canvas.waitForRender()