SemianiakaVY/openpencil
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

fix(sdk): export set_viewport/zoom_to_fit/forward_wheel to wasm

Browse source 
These nav methods were in plain impl blocks, so wasm-bindgen never exported
them — the generated .d.ts (and the JS surface) lacked the spec's primary
navigation API. Move set_viewport/zoom_to_fit into a #[wasm_bindgen] impl and
mark the canvaskit forward_wheel impl #[wasm_bindgen]; keep the tuple
viewport() and pub(crate) push_viewport internal. Verified in the regenerated
.d.ts: set_viewport/zoom_to_fit/forward_wheel now exported.
This commit is contained in:
Kayshen-X 2026-06-19 17:58:33 +08:00
parent fd1516656a
commit a13d2adc53
1 changed files with 23 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
crates/op-web-sdk/src/navigation.rs
View file

@ -7,13 +7,29 @@
use op_editor_core::Viewport as DocViewport;
use op_editor_ui::{Point2D, Rect};
use wasm_bindgen::prelude::wasm_bindgen;
use crate::Viewer;
// ---------------------------------------------------------------------------
// Core viewport accessors (feature-independent).
// Internal viewport accessor (tuple return — not wasm-exportable; JS reads the
// viewport via the exported `viewport_json()`).
// ---------------------------------------------------------------------------
impl Viewer {
/// Return the current viewport as `(pan_x, pan_y, zoom)`.
/// Rust/test-facing; JS callers use `viewport_json()`.
pub fn viewport(&self) -> (f32, f32, f32) {
(self.viewport.pan_x, self.viewport.pan_y, self.viewport.zoom)
}
}
// ---------------------------------------------------------------------------
// JS-facing navigation (feature-independent: set_viewport / zoom_to_fit work
// without the render path, falling back to the no-op push_viewport stub).
// ---------------------------------------------------------------------------
#[wasm_bindgen]
impl Viewer {
/// Set the pan/zoom state and push the update into the live render state.
pub fn set_viewport(&mut self, pan_x: f32, pan_y: f32, zoom: f32) {
@ -25,11 +41,6 @@ impl Viewer {
self.mark_dirty();
}
/// Return the current viewport as `(pan_x, pan_y, zoom)`.
pub fn viewport(&self) -> (f32, f32, f32) {
(self.viewport.pan_x, self.viewport.pan_y, self.viewport.zoom)
}
/// Fit the active page's content into a `w × h` canvas (in CSS px).
///
/// Computes the union AABB of all top-level nodes on the active page
@ -80,6 +91,7 @@ impl Viewer {
// ---------------------------------------------------------------------------
#[cfg(feature = "canvaskit")]
#[wasm_bindgen]
impl Viewer {
/// Process a DOM `wheel` event from JS.
///
@ -99,7 +111,12 @@ impl Viewer {
}
self.push_viewport();
}
}
// push_viewport stays out of the `#[wasm_bindgen]` impl (it is `pub(crate)`
// internal plumbing, not part of the JS surface).
#[cfg(feature = "canvaskit")]
impl Viewer {
/// Push the current `self.viewport` into the live `RenderInner` so the
/// RAF pump reads the updated value on the next frame.
pub(crate) fn push_viewport(&self) {