From 5b151ffc1ea2703c7f68c9063483799e3a75b071 Mon Sep 17 00:00:00 2001 From: Danila Poyarkov Date: Wed, 16 Sep 2026 14:13:34 +0300 Subject: [PATCH] fix(canvas): include component-set members in label catalog --- packages/core/src/canvas/labels/cache.ts | 2 +- tests/e2e/canvas/labels/component.spec.ts | 5 +++++ ...mponent-set-member-label-openpencil-darwin.png | Bin 0 -> 831 bytes 3 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 tests/e2e/canvas/labels/component.spec.ts-snapshots/component-set-member-label-openpencil-darwin.png diff --git a/packages/core/src/canvas/labels/cache.ts b/packages/core/src/canvas/labels/cache.ts index 8e1198106..0998cd643 100644 --- a/packages/core/src/canvas/labels/cache.ts +++ b/packages/core/src/canvas/labels/cache.ts @@ -25,7 +25,7 @@ interface Viewport { } const LABEL_TYPES = new Set(['COMPONENT', 'COMPONENT_SET']) -const COMPONENT_LABEL_PARENT_TYPES = new Set(['CANVAS', 'SECTION']) +const COMPONENT_LABEL_PARENT_TYPES = new Set(['CANVAS', 'SECTION', 'COMPONENT_SET']) function isInViewport(absX: number, absY: number, w: number, h: number, vp: Viewport): boolean { return absX + w >= vp.x && absY + h >= vp.y && absX <= vp.x + vp.w && absY <= vp.y + vp.h diff --git a/tests/e2e/canvas/labels/component.spec.ts b/tests/e2e/canvas/labels/component.spec.ts index 4293da92e..51463f453 100644 --- a/tests/e2e/canvas/labels/component.spec.ts +++ b/tests/e2e/canvas/labels/component.spec.ts @@ -62,6 +62,11 @@ test('component labels in component sets are hit-tested above the component boun const componentTopY = 80 + (100 + 40) * 2 const componentLeftX = 80 + (100 + 20) * 2 + await expect(page).toHaveScreenshot('component-set-member-label.png', { + clip: { x: box.x + componentLeftX, y: box.y + componentTopY - 24, width: 240, height: 24 }, + maxDiffPixels: 0, + threshold: 0 + }) await page.mouse.click(box.x + componentLeftX + 24, box.y + componentTopY - 12) await canvas.waitForRender() diff --git a/tests/e2e/canvas/labels/component.spec.ts-snapshots/component-set-member-label-openpencil-darwin.png b/tests/e2e/canvas/labels/component.spec.ts-snapshots/component-set-member-label-openpencil-darwin.png new file mode 100644 index 0000000000000000000000000000000000000000..f946a6ecd5581050713943aaad91f182d3924dc7 GIT binary patch literal 831 zcmV-F1Hk-=P)F|9KiA4do#PUZWAfCyM~(^FoqKH3jY*af_?XU@kCmubE+kWtz4KD-BgCC&0P{}nypcqF38ob%5bj(V(aX{UZv%_RDVVu=y6)tMkIp&B!*?z?nn{LGd zUGyeC39j%Of@mHTJ;o}(*}dp9q_CN(zeXE>!wvU2LZgJuuDV@d!!sdy^i7*ukgQ1YR)K)oMlC z_27%SMST1Xv7u2N>~ZpLW6dVb;l@o9lm=Q@rPZBETrRU8*+F&+GGIDL*sW4nt%bfN z-v!Sv(b*05vEQ+A53V;*dd#E}n$Bp=%;uvCdt|(O()IiElK<8zX;7tU@Rs5BA4(6I ze`AI1Gd#XxMxD``Q#5ePDf;yCW}Kl>dPw{$SgdJ?P1ukw%?Lxhqd z_)a0R6Z~=#vK0&(*$M`YY~>#S00960Fx6Z%00006Nkl2B5Fc>JYN6+002ov JPDHLkV1j~@hV1|V literal 0 HcmV?d00001