SemianiakaVY/openpencil
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

fix(shell): pen-tool undo restores pre-pen state

Browse source 
`start_pen_path` was pushing the new Path node onto the page first
and only then calling `snapshot_for_history()` — the snapshot ended
up including the new node, so a subsequent undo restored "node
already present" and the path stayed on screen.

Take the snapshot before any mutation; finish_pen_path still
gates the push on `anchor_count >= 2` so single-anchor paths
don't pollute the undo stack.
This commit is contained in:
Kayshen-X 2026-05-12 21:32:07 +08:00
parent d69e9e2eaf
commit 576c2fe4e1
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/openpencil-shell-core/src/document/pen.rs
View file

@ -17,6 +17,10 @@ impl Document {
let raw = (*next_id).max(safe);
*next_id = raw.checked_add(1)?;
let id = NodeId::new(raw);
// Snapshot BEFORE any mutation so a later undo restores the
// pre-pen document state — otherwise the snapshot already
// contains the new path node and undo is a no-op visually.
let pre = self.snapshot_for_history();
let mut node = Node::leaf(raw, NodeKind::Path, "Path")
.with_stroke(crate::Color::BLACK, 2.0)
.with_bounds(crate::Rect {
@ -27,7 +31,7 @@ impl Document {
let active = self.active_page_index;
let page = self.pages.get_mut(active)?;
page.children.push(node);
self.ui.pending_pen_history = Some(self.snapshot_for_history());
self.ui.pending_pen_history = Some(pre);
self.ui.pen_in_progress = Some(id);
self.set_single_selection(id);
Some(id)