From 05d111d2bad1e2d6b1bc864f61e1c7a6dc28c080 Mon Sep 17 00:00:00 2001 From: Fini Date: Sun, 24 May 2026 16:41:36 +0800 Subject: [PATCH] refactor(ai): drop dead node_base_role helper in validation_fixes_apply MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit memory-tagged follow-up — `node_base_role(node) -> Option<&str>` (line 568 of `validation_fixes_apply.rs`) was a thin shim over `node.base().role.as_deref()` with zero call sites anywhere in crates/* or vendor/*. Inlining at the (single, hypothetical) caller is shorter than the helper itself. `cargo test -p op-orchestrator` still 585 passed; workspace 1880 passed; fmt + clippy --workspace -D warnings clean. --- crates/op-orchestrator/src/validation_fixes_apply.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/crates/op-orchestrator/src/validation_fixes_apply.rs b/crates/op-orchestrator/src/validation_fixes_apply.rs index 1fc04da7d..085575db0 100644 --- a/crates/op-orchestrator/src/validation_fixes_apply.rs +++ b/crates/op-orchestrator/src/validation_fixes_apply.rs @@ -565,10 +565,6 @@ fn node_child_count(node: &jian_ops_schema::node::PenNode) -> usize { } } -pub(super) fn node_base_role(node: &jian_ops_schema::node::PenNode) -> Option<&str> { - node.base().role.as_deref() -} - /// A flat snapshot of the properties we need for /// `auto_fix_parent_layout_after_add_child`. struct NodeSnapshot {