SemianiakaVY/openpencil
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

refactor(editor): migrate provider-card connect/disconnect to jian Button

Browse source 
Connect renders through jian Button Primary (centered label, primary
fill) and Disconnect through the new DestructiveOutline variant (red
border + red label) instead of hand-rolled fill_round_rect + centered
draw_text. Bumps vendor/jian to 9e47bd3.
This commit is contained in:
Kayshen-X 2026-06-20 11:38:42 +08:00
parent 9c645584ff
commit 03e37f4613
2 changed files with 28 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

65
crates/op-editor-ui/src/widgets/agent_settings_panel_card.rs
View file

@ -15,6 +15,7 @@ use crate::widgets::brand_icons::{paint_brand_logo, paint_opencode_logo, BrandLo
use crate::widgets::button::tokens_from_theme;
use crate::widgets::PaintCx;
use crate::{Color, Point2D, Rect, TextLayout};
use jian_widgets::components::button::{Button, ButtonVariant};
use jian_widgets::components::card::Card;
use op_editor_core::agent_settings::{AgentProvider, AgentSettings};
use op_editor_core::editor_ui_state::EditorUiState;
@ -160,54 +161,42 @@ pub(super) fn paint_agent_card(
cx.backend
.draw_text(&sub, Point2D::new(text_x, card.origin.y + 38.0));
let hovered = settings.hover_provider == index;
let tokens = tokens_from_theme(theme);
if connected {
// Disconnect only surfaces on card hover — a non-primary destructive
// action, so jian's DestructiveOutline (red border + red label) owns
// the look + feedback instead of a hand-rolled fill+stroke+text.
if hovered {
let btn = disconnect_btn_rect_at(card);
let red = Color {
r: 0.93,
g: 0.30,
b: 0.30,
a: 1.0,
};
cx.backend.fill_round_rect(btn, 6.0, theme.muted);
cx.backend.stroke_round_rect(btn, 6.0, red, 1.0);
let label = t_settings(ui, "settings.agents.disconnect");
let lw = cx.backend.measure_text(label, 12.0);
let layout = TextLayout::single_run(
label,
"system-ui",
12.0,
(red).to_jian(),
Point2D::new(0.0, 0.0),
);
cx.backend.draw_text(
&layout,
Point2D::new(btn.origin.x + (btn.size.x - lw) / 2.0, btn.origin.y + 18.0),
);
Button {
label: t_settings(ui, "settings.agents.disconnect"),
icon_d: None,
variant: ButtonVariant::DestructiveOutline,
enabled: true,
hovered: false,
pressed: false,
font_size: 12.0,
}
.paint(cx.backend, disconnect_btn_rect_at(card), &tokens);
}
} else {
let btn = connect_btn_rect_at(card);
cx.backend.fill_round_rect(btn, 5.0, theme.primary);
// While the probe runs the button reads "…" — the TS card
// swaps the label for a spinner and disables the button
// (the press handler ignores Connect while Probing).
// While the probe runs the button reads "…" and is disabled — the TS
// card swaps the label for a spinner (the press handler ignores
// Connect while Probing). jian Button Primary owns the centered label.
let label = if probing {
"…"
} else {
t_settings(ui, "settings.agents.connect")
};
let lw = cx.backend.measure_text(label, 12.0);
let layout = TextLayout::single_run(
Button {
label,
"system-ui",
12.0,
(theme.primary_foreground).to_jian(),
Point2D::new(0.0, 0.0),
);
cx.backend.draw_text(
&layout,
Point2D::new(btn.origin.x + (btn.size.x - lw) / 2.0, btn.origin.y + 18.0),
);
icon_d: None,
variant: ButtonVariant::Primary,
enabled: !probing,
hovered: false,
pressed: false,
font_size: 12.0,
}
.paint(cx.backend, connect_btn_rect_at(card), &tokens);
}
}

2
vendor/jian vendored

@ -1 +1 @@
Subproject commit 62874ae9f60cc42c1a7c38b082fb68c2ac23a04f
Subproject commit 9e47bd38ec0b146719d972ecd6628a1d67587ef5