openpencil/src/components/properties/StrokeSection.vue

223 lines
7.4 KiB
Vue
Raw Normal View History

<script setup lang="ts">
import { ref } from 'vue'
2026-03-28 17:33:35 +00:00
import {
applySolidStrokeColor,
2026-03-28 17:33:35 +00:00
PropertyListRoot,
useColorVariableBinding,
useStrokeControls,
useOkHCL,
useI18n
} from '@open-pencil/vue'
import ColorStyleRow from '@/components/properties/ColorStyleRow.vue'
import { boundVariableColor } from '@/components/properties/color-style-row'
import AppSelect from '@/components/ui/AppSelect.vue'
Refactor architecture boundaries across core, app, and packages (#234) * refactor(core): decompose editor factory and action modules Split the monolithic editor factory and large action modules into focused domain helpers: - create.ts assembles context through bridge modules (clipboard, components, structure, undo) and delegates to graph-reads, graph-events, layout-runner, component-sync, and state factory - structure.ts delegates to group, container-wrap, auto-layout-wrap, reorder, and state-toggle helpers - selection.ts delegates to hit-test, overlays, container navigation, and read helpers - clipboard.ts delegates to subtree-history, images, export, copy, fonts, and placement helpers - shapes.ts delegates to pen actions and section-adopt - components.ts delegates to focus and instances helpers - alignment.ts delegates to flip-rotate helper - text.ts uses explicit TextEditSession for snapshot comparison New focused modules: nudge, variable-bindings, layout-mode, page-viewports, tool-registry, color-space Undo: history/position and history/snapshot helpers, hardened batch/rollback with nested batch support and configurable limit * refactor(core): split tool definitions by domain Split the monolithic tool registry into domain-specific modules: - read/ — selection, find, pages, fonts, components, nodes, query, jsx - create/ — basic shapes, components, vector, JSX render - modify/ — paint, effects, geometry, layout, state, text, update - structure/ — basic, arrange, batch, hierarchy, replace, tree - variables/ — bindings, collections, read, values - vector/ — boolean, path, export, viewport - analyze/ — colors, typography, spacing, clusters, diff, eval - describe/ — summaries, tree, roles, layout-issues - stock-photo/ — providers, requests, apply - codegen/ — component-map, tokens Split registry into core/extended tiers; refine schema and AI adapter * refactor(core): restructure kiwi codec and instance overrides Reorganize the Kiwi .fig codec into domain subdirectories: - binary/ — codec, schema, protocol - fig/ — file, import, parse (core, worker, transfer) - node-change/ — convert, export-node, serialize, plugin-data - instance-overrides/ — constraints, dsd, populate, props, resolve, symbol-overrides, symbol-props, sync, types Vendored kiwi-schema/ left isolated * refactor(core): split profiler, icons, IO, and add subpath exports Profiler: speedscope-export, capture-session, hud-controller Icons: api, svg, types, render, create-icons tool IO: format registry and subpath exports Canvas/color/text/vector: targeted cleanup Add deliberate subpath exports: random, xpath, vector, color, canvas, scene-graph, kiwi, design-jsx, io, tools, editor, layout, canvaskit, profiler, text, lint, rpc, figma-api, constants * refactor(vue): decompose canvas input, surface lifecycle, and controls Canvas surface: gl-surface, kit-loader, render-loop, resize-observer Canvas input handlers: - move: drop-target, move-snap, duplicate-drag - select: select-move, select-hover, select-hit - resize: resize-rect, resize-vector, resize-start - transform: rotation, marquee, pan, text-selection - text-edit: navigation, clipboard, textarea lifecycle - Shared: click-count, space-key, pan, pan-zoom, draw, raf-scheduler Editor composition: - commands split: actions, context, metadata, edit, selection, view - menu-model split: command-groups, builders, types - Gradient stop composable reuse in primitive root Controls: fill, layout, typography, appearance, effects, stroke, okhcl, prop-scrub, node-props, undo-batch, color-variable-binding Variables/i18n/document/export helpers Organize canvas, primitives, controls, editor, and variables into cohesive module directories with package-local import aliases Expose MenuActionNode/MenuSeparatorNode from public API * refactor(app): split document IO, editor session, and automation bridge Document IO: source-state, naming, writer, reload-source, reload-state, imported-document, watch-targets, save-targets Editor session: create, modules, types, accessors, computed, refs Editor canvas: loader-overlay, collaboration-awareness, context-selection, menu-actions, menu-model Automation bridge: eval, tools, exports, files, selection, RPC fallback AI/ACP: transport, map-update, permission, debug, chat effects/storage Collab: awareness, graph-bindings, yjs-sync, follow, session, types Shell keyboard: actions, bindings, clipboard, focus, nudging, raw-events, registry, reserved, shortcuts, space-tool Shell menu: app-menu, document-name, entry, files Demo: colors, effects, helpers, section builders (components, app-preview, effects, standalone, variables) — document.ts reduced from 981 to 32 lines as pure orchestrator Move app modules under src/app/ with organized domain structure: editor, document, ai, collab, shell, automation, demo, tabs * refactor(app): decompose UI components with provide/inject context Split monolithic components using Reka UI-inspired namespace folders with scoped provide/inject context — no prop drilling: - CollabPanel/ — context, avatars, share, connected, join - ColorPickerPanel/ — context, area, format, field groups, sliders - MobileHud/ — context, action toast, tool badge, file menu, presence - ProviderSettings/ — context, API key/type, endpoint, tokens, photos - Toolbar/ — actions, types, desktop, mobile, tool button, flyout - LayoutSection/ — types, auto-layout, flex, grid, padding, size, clip Properties helpers: fill-okhcl adapter, fill-label, color-style-row Menu: entry helpers, document-name rename, stale type removal * refactor(mcp): split server into focused modules - browser-rpc — WebSocket client management - mcp-sessions — session lifecycle - tool-output — response formatting - tool-schema — Zod schema generation from ToolDefs - jsx-preprocess — JSX source transformation - result — result helpers - tool-registration — MCP tool wiring - auth — API key validation - http-options — CORS/request handling - stdio-bridge — stdio transport adapter * refactor(cli): split analyze subcommands and shared helpers - Analyze subcommands: clusters, colors, spacing, typography - RPC data loading helper - Migrate imports to targeted core subpath exports * refactor(docs): split VitePress config and shared table component Config helpers: sdk-sidebar, seo, labels, sidebars, locale-theme, root-theme, locales Shared SdkDataTable component replaces duplicated table markup in SdkPropsTable, SdkEventsTable, and SdkSlotsTable Update contributing and testing docs * refactor(tauri): decompose desktop entrypoint Split lib.rs into focused service modules: - fig_container.rs — .fig archive/compression commands - fonts.rs — font cache and system font enumeration - menu.rs — native menu construction - menu_events.rs — menu event dispatch and devtools toggle - window.rs — main window show/focus lifecycle * test: share domain test factories and migrate fixtures New shared helpers: - tests/helpers/scene.ts — makeSceneGraph factory - tests/helpers/vector-network.ts — vertex/segment/network builders - tests/helpers/fig-traversal.ts — all-node collection, type counts - tests/helpers/undo.ts — undo test utilities - tests/helpers/editor-history.ts — editor history test helpers Migrate render, vector, fig-roundtrip, and undo tests to use shared factories instead of inline fixture construction * build: add structural lint rules, split vite config, update docs Structural lint (oxlint.structure.json + lint/plugin.js): - 20+ custom rules enforcing package boundaries, lifecycle patterns, naming conventions, and import discipline Vite config split: raw-markdown, canvaskit-assets, pwa, server, aliases, automation plugins Remove legacy shims and utils superseded by SDK/core modules Update AGENTS.md, CONTRIBUTING.md, eval-command docs, tsconfig * fix(vue): normalize canvas directory casing and remove duplicate export - Rename Canvas/ to canvas/ in git index to match #vue/canvas/* imports (PascalCase was correct for component primitives but canvas/ is a non-component domain directory) - Remove duplicate ./random subpath export in core package.json * fix: add #vue and #core Vite resolve aliases for dev server * refactor(core): reduce remaining large modules Split the remaining large core hotspots into cohesive domain modules while preserving public facades and behavior. - Extract scene graph types, variables, node defaults, and vector-network helpers - Decompose canvas renderer orchestration, state, paints, colors, lifecycle, labels, and delegated domain methods into renderer/ and labels/ subfolders - Split Kiwi node-change, binary variable binding, layout, RPC, vector, JSX export, clipboard, design JSX, and Figma proxy helpers - Replace collision-driven *Fn import aliases with namespace imports and enforce the pattern in lint Validation: - bun run check - bun --filter @open-pencil/vue build - bun run test:dupes * fix(app): forward color input attrs * fix(app): cover section drawing errors * fix(editor): undo option-drag duplicates * docs: document domain subfolder convention * fix(app): handle undo redo on keydown * refactor(app): dispatch shortcuts from keydown * refactor: group prefixed domain modules * refactor(app): use tinykeys for shortcuts * refactor(core): group symbol override modules * refactor(core): group fig kiwi container helper * refactor(canvas): split overlay rendering modules * refactor(vue): remove unused internal barrels * fix(app): lay out demo components before instancing * fix(app): restore demo badge spacing * perf(canvas): split scene and overlay rendering * refactor(vue): wrap wheel gesture lifecycle * fix(canvas): wait for fonts before hiding loader * docs: update unreleased changelog
2026-04-30 12:14:19 +00:00
import ColorInput from '@/components/ColorPicker/ColorInput.vue'
import ScrubInput from '@/components/ScrubInput.vue'
import Tip from '@/components/ui/Tip.vue'
import { useIconButtonUI } from '@/components/ui/icon-button'
import { useSectionUI } from '@/components/ui/section'
import type { Color, SceneNode, Stroke } from '@open-pencil/core/scene-graph'
2026-03-23 14:42:58 +00:00
const strokeCtx = useStrokeControls()
const strokeVarCtx = useColorVariableBinding('strokes')
2026-03-28 17:33:35 +00:00
const okhcl = useOkHCL()
2026-03-25 15:47:23 +00:00
const { panels } = useI18n()
const sectionCls = useSectionUI()
const expandedSides = ref(false)
function updateStrokeColor(
activeNode: SceneNode | null | undefined,
index: number,
color: Color,
patch: (index: number, changes: Record<string, unknown>) => void
) {
if (activeNode && strokeVarCtx.getBoundVariable(activeNode.id, index)) {
strokeVarCtx.unbindVariable(activeNode.id, index)
}
patch(index, applySolidStrokeColor(color))
}
function onToggleSides(activeNode: SceneNode) {
const next = !expandedSides.value
expandedSides.value = next
if (next && !activeNode.independentStrokeWeights) {
const weight = activeNode.strokes[0]?.weight ?? 1
2026-03-28 17:33:35 +00:00
strokeCtx.selectSide('CUSTOM', {
...activeNode,
borderTopWeight: weight,
borderRightWeight: weight,
borderBottomWeight: weight,
borderLeftWeight: weight
} as SceneNode)
} else if (!next && activeNode.independentStrokeWeights) {
strokeCtx.selectSide('ALL', activeNode)
}
}
</script>
<template>
2026-03-23 14:42:58 +00:00
<PropertyListRoot
v-slot="{ items, isMixed, activeNode, add, remove, patch, toggleVisibility }"
prop-key="strokes"
2026-03-25 15:47:23 +00:00
:label="panels.stroke"
2026-03-23 14:42:58 +00:00
>
<div data-test-id="stroke-section" :class="sectionCls.wrapper">
2026-03-23 14:42:58 +00:00
<div class="flex items-center justify-between">
<label :class="sectionCls.label">{{ panels.stroke }}</label>
2026-03-23 14:42:58 +00:00
<button
data-test-id="stroke-section-add"
:class="useIconButtonUI().base"
2026-03-23 14:42:58 +00:00
@click="add(strokeCtx.defaultStroke)"
>
+
</button>
</div>
2026-03-25 15:47:23 +00:00
<p v-if="isMixed" class="text-[11px] text-muted">{{ panels.mixedStrokesHelp }}</p>
<ColorStyleRow
2026-03-23 14:42:58 +00:00
v-for="(stroke, i) in items as Stroke[]"
:key="`${i}:${stroke.visible ? 'visible' : 'hidden'}`"
:item="stroke"
:index="i"
:active-node-id="activeNode?.id ?? null"
:binding-api="strokeVarCtx"
:variable-color="stroke.color"
:visibility-test-id="`stroke-visibility-${i}`"
:apply-variable-test-id="`stroke-apply-variable-${i}`"
unbind-test-id="stroke-unbind-variable"
2026-03-23 14:42:58 +00:00
data-test-id="stroke-item"
:data-test-index="i"
@patch="patch(i, $event)"
@toggle-visibility="toggleVisibility(i)"
@remove="remove(i)"
2026-03-23 14:42:58 +00:00
>
2026-03-28 17:33:35 +00:00
<ColorInput
class="min-w-0 flex-1"
:color="
activeNode
? (boundVariableColor(strokeVarCtx, activeNode.id, i) ?? stroke.color)
: stroke.color
"
2026-03-28 17:33:35 +00:00
:okhcl="
activeNode
? {
2026-03-29 15:46:55 +00:00
fieldFormat: okhcl.getFieldFormat(activeNode, i, 'stroke'),
fieldOptions: okhcl.fieldOptions,
2026-03-28 17:33:35 +00:00
okhcl: okhcl.getStrokeOkHCLColor(activeNode, i),
2026-03-29 15:46:55 +00:00
...okhcl.getStrokePreviewInfo(activeNode, i),
setFieldFormat: ($event) => okhcl.setStrokeFieldFormat(activeNode, i, $event),
2026-03-28 17:33:35 +00:00
updateOkHCL: ($event) => okhcl.updateStrokeOkHCL(activeNode, i, $event)
}
: null
"
editable
@update="updateStrokeColor(activeNode, i, $event, patch)"
2026-03-28 17:33:35 +00:00
/>
</ColorStyleRow>
2026-03-24 14:02:01 +00:00
<div
v-if="!isMixed && (items as unknown[]).length > 0"
2026-03-24 14:02:01 +00:00
class="mt-1 flex items-center gap-1.5"
>
2026-03-23 14:42:58 +00:00
<AppSelect
class="w-[72px]"
:model-value="strokeCtx.currentAlign(activeNode)"
:options="strokeCtx.alignOptions"
@update:model-value="strokeCtx.updateAlign($event as Stroke['align'], activeNode!)"
2026-03-23 14:42:58 +00:00
/>
<ScrubInput
v-if="!expandedSides"
2026-03-23 14:42:58 +00:00
class="flex-1"
:model-value="activeNode!.strokes[0]?.weight ?? 1"
2026-03-23 14:42:58 +00:00
:min="0"
@update:model-value="patch(0, { weight: $event })"
>
<template #icon>
<svg
class="size-3"
viewBox="0 0 12 12"
fill="none"
stroke="currentColor"
stroke-width="1.5"
>
<line x1="1" y1="3" x2="11" y2="3" />
<line x1="1" y1="6" x2="11" y2="6" />
<line x1="1" y1="9" x2="11" y2="9" />
</svg>
</template>
</ScrubInput>
<Tip :label="panels.strokeSides">
<button
data-test-id="stroke-sides-toggle"
class="flex size-[26px] shrink-0 cursor-pointer items-center justify-center rounded border border-border bg-input text-muted hover:bg-hover hover:text-surface"
:class="{ '!border-accent !text-accent': expandedSides }"
@click="onToggleSides(activeNode!)"
>
<svg class="size-3.5" viewBox="0 0 14 14" fill="currentColor">
<rect x="1" y="1" width="5" height="5" rx="1" />
<rect x="8" y="1" width="5" height="5" rx="1" />
<rect x="1" y="8" width="5" height="5" rx="1" />
<rect x="8" y="8" width="5" height="5" rx="1" />
</svg>
</button>
</Tip>
2026-03-23 14:42:58 +00:00
</div>
2026-03-23 14:42:58 +00:00
<div
v-if="!isMixed && (items as unknown[]).length > 0 && expandedSides"
2026-03-23 14:42:58 +00:00
class="mt-1.5 grid grid-cols-2 gap-1.5"
>
<ScrubInput
v-for="side in strokeCtx.borderSides"
:key="side"
:model-value="
activeNode![
2026-03-23 14:42:58 +00:00
`border${side[0].toUpperCase()}${side.slice(1)}Weight` as keyof SceneNode
] as number
"
:min="0"
@update:model-value="strokeCtx.updateBorderWeight(side, $event, activeNode!)"
>
2026-03-23 14:42:58 +00:00
<template #icon>
<svg class="size-3" viewBox="0 0 12 12" fill="none" stroke-width="1.5">
<rect
x="1"
y="1"
width="10"
height="10"
rx="1"
stroke="currentColor"
stroke-opacity="0.3"
stroke-dasharray="2 2"
/>
<line v-if="side === 'top'" x1="1" y1="1" x2="11" y2="1" stroke="currentColor" />
<line
v-else-if="side === 'right'"
x1="11"
y1="1"
x2="11"
y2="11"
stroke="currentColor"
/>
<line
v-else-if="side === 'bottom'"
x1="1"
y1="11"
x2="11"
y2="11"
stroke="currentColor"
/>
<line v-else x1="1" y1="1" x2="1" y2="11" stroke="currentColor" />
</svg>
</template>
</ScrubInput>
</div>
2026-03-23 14:42:58 +00:00
</div>
</PropertyListRoot>
</template>