openpencil/src/components/VariablesDialog.vue

281 lines
11 KiB
Vue
Raw Normal View History

<script setup lang="ts">
import { watch, type Component } from 'vue'
import { templateRef } from '@vueuse/core'
import {
DialogClose,
DialogContent,
DialogOverlay,
DialogPortal,
DialogRoot,
DialogTitle,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuPortal,
DropdownMenuRoot,
DropdownMenuTrigger,
TabsContent,
TabsList,
TabsRoot,
TabsTrigger
} from 'reka-ui'
import { FlexRender } from '@tanstack/vue-table'
2026-03-25 15:26:03 +00:00
import { useI18n, useVariablesEditor } from '@open-pencil/vue'
import IconHash from '~icons/lucide/hash'
import IconPalette from '~icons/lucide/palette'
import IconToggleLeft from '~icons/lucide/toggle-left'
import IconType from '~icons/lucide/type'
import IconX from '~icons/lucide/x'
Refactor architecture boundaries across core, app, and packages (#234) * refactor(core): decompose editor factory and action modules Split the monolithic editor factory and large action modules into focused domain helpers: - create.ts assembles context through bridge modules (clipboard, components, structure, undo) and delegates to graph-reads, graph-events, layout-runner, component-sync, and state factory - structure.ts delegates to group, container-wrap, auto-layout-wrap, reorder, and state-toggle helpers - selection.ts delegates to hit-test, overlays, container navigation, and read helpers - clipboard.ts delegates to subtree-history, images, export, copy, fonts, and placement helpers - shapes.ts delegates to pen actions and section-adopt - components.ts delegates to focus and instances helpers - alignment.ts delegates to flip-rotate helper - text.ts uses explicit TextEditSession for snapshot comparison New focused modules: nudge, variable-bindings, layout-mode, page-viewports, tool-registry, color-space Undo: history/position and history/snapshot helpers, hardened batch/rollback with nested batch support and configurable limit * refactor(core): split tool definitions by domain Split the monolithic tool registry into domain-specific modules: - read/ — selection, find, pages, fonts, components, nodes, query, jsx - create/ — basic shapes, components, vector, JSX render - modify/ — paint, effects, geometry, layout, state, text, update - structure/ — basic, arrange, batch, hierarchy, replace, tree - variables/ — bindings, collections, read, values - vector/ — boolean, path, export, viewport - analyze/ — colors, typography, spacing, clusters, diff, eval - describe/ — summaries, tree, roles, layout-issues - stock-photo/ — providers, requests, apply - codegen/ — component-map, tokens Split registry into core/extended tiers; refine schema and AI adapter * refactor(core): restructure kiwi codec and instance overrides Reorganize the Kiwi .fig codec into domain subdirectories: - binary/ — codec, schema, protocol - fig/ — file, import, parse (core, worker, transfer) - node-change/ — convert, export-node, serialize, plugin-data - instance-overrides/ — constraints, dsd, populate, props, resolve, symbol-overrides, symbol-props, sync, types Vendored kiwi-schema/ left isolated * refactor(core): split profiler, icons, IO, and add subpath exports Profiler: speedscope-export, capture-session, hud-controller Icons: api, svg, types, render, create-icons tool IO: format registry and subpath exports Canvas/color/text/vector: targeted cleanup Add deliberate subpath exports: random, xpath, vector, color, canvas, scene-graph, kiwi, design-jsx, io, tools, editor, layout, canvaskit, profiler, text, lint, rpc, figma-api, constants * refactor(vue): decompose canvas input, surface lifecycle, and controls Canvas surface: gl-surface, kit-loader, render-loop, resize-observer Canvas input handlers: - move: drop-target, move-snap, duplicate-drag - select: select-move, select-hover, select-hit - resize: resize-rect, resize-vector, resize-start - transform: rotation, marquee, pan, text-selection - text-edit: navigation, clipboard, textarea lifecycle - Shared: click-count, space-key, pan, pan-zoom, draw, raf-scheduler Editor composition: - commands split: actions, context, metadata, edit, selection, view - menu-model split: command-groups, builders, types - Gradient stop composable reuse in primitive root Controls: fill, layout, typography, appearance, effects, stroke, okhcl, prop-scrub, node-props, undo-batch, color-variable-binding Variables/i18n/document/export helpers Organize canvas, primitives, controls, editor, and variables into cohesive module directories with package-local import aliases Expose MenuActionNode/MenuSeparatorNode from public API * refactor(app): split document IO, editor session, and automation bridge Document IO: source-state, naming, writer, reload-source, reload-state, imported-document, watch-targets, save-targets Editor session: create, modules, types, accessors, computed, refs Editor canvas: loader-overlay, collaboration-awareness, context-selection, menu-actions, menu-model Automation bridge: eval, tools, exports, files, selection, RPC fallback AI/ACP: transport, map-update, permission, debug, chat effects/storage Collab: awareness, graph-bindings, yjs-sync, follow, session, types Shell keyboard: actions, bindings, clipboard, focus, nudging, raw-events, registry, reserved, shortcuts, space-tool Shell menu: app-menu, document-name, entry, files Demo: colors, effects, helpers, section builders (components, app-preview, effects, standalone, variables) — document.ts reduced from 981 to 32 lines as pure orchestrator Move app modules under src/app/ with organized domain structure: editor, document, ai, collab, shell, automation, demo, tabs * refactor(app): decompose UI components with provide/inject context Split monolithic components using Reka UI-inspired namespace folders with scoped provide/inject context — no prop drilling: - CollabPanel/ — context, avatars, share, connected, join - ColorPickerPanel/ — context, area, format, field groups, sliders - MobileHud/ — context, action toast, tool badge, file menu, presence - ProviderSettings/ — context, API key/type, endpoint, tokens, photos - Toolbar/ — actions, types, desktop, mobile, tool button, flyout - LayoutSection/ — types, auto-layout, flex, grid, padding, size, clip Properties helpers: fill-okhcl adapter, fill-label, color-style-row Menu: entry helpers, document-name rename, stale type removal * refactor(mcp): split server into focused modules - browser-rpc — WebSocket client management - mcp-sessions — session lifecycle - tool-output — response formatting - tool-schema — Zod schema generation from ToolDefs - jsx-preprocess — JSX source transformation - result — result helpers - tool-registration — MCP tool wiring - auth — API key validation - http-options — CORS/request handling - stdio-bridge — stdio transport adapter * refactor(cli): split analyze subcommands and shared helpers - Analyze subcommands: clusters, colors, spacing, typography - RPC data loading helper - Migrate imports to targeted core subpath exports * refactor(docs): split VitePress config and shared table component Config helpers: sdk-sidebar, seo, labels, sidebars, locale-theme, root-theme, locales Shared SdkDataTable component replaces duplicated table markup in SdkPropsTable, SdkEventsTable, and SdkSlotsTable Update contributing and testing docs * refactor(tauri): decompose desktop entrypoint Split lib.rs into focused service modules: - fig_container.rs — .fig archive/compression commands - fonts.rs — font cache and system font enumeration - menu.rs — native menu construction - menu_events.rs — menu event dispatch and devtools toggle - window.rs — main window show/focus lifecycle * test: share domain test factories and migrate fixtures New shared helpers: - tests/helpers/scene.ts — makeSceneGraph factory - tests/helpers/vector-network.ts — vertex/segment/network builders - tests/helpers/fig-traversal.ts — all-node collection, type counts - tests/helpers/undo.ts — undo test utilities - tests/helpers/editor-history.ts — editor history test helpers Migrate render, vector, fig-roundtrip, and undo tests to use shared factories instead of inline fixture construction * build: add structural lint rules, split vite config, update docs Structural lint (oxlint.structure.json + lint/plugin.js): - 20+ custom rules enforcing package boundaries, lifecycle patterns, naming conventions, and import discipline Vite config split: raw-markdown, canvaskit-assets, pwa, server, aliases, automation plugins Remove legacy shims and utils superseded by SDK/core modules Update AGENTS.md, CONTRIBUTING.md, eval-command docs, tsconfig * fix(vue): normalize canvas directory casing and remove duplicate export - Rename Canvas/ to canvas/ in git index to match #vue/canvas/* imports (PascalCase was correct for component primitives but canvas/ is a non-component domain directory) - Remove duplicate ./random subpath export in core package.json * fix: add #vue and #core Vite resolve aliases for dev server * refactor(core): reduce remaining large modules Split the remaining large core hotspots into cohesive domain modules while preserving public facades and behavior. - Extract scene graph types, variables, node defaults, and vector-network helpers - Decompose canvas renderer orchestration, state, paints, colors, lifecycle, labels, and delegated domain methods into renderer/ and labels/ subfolders - Split Kiwi node-change, binary variable binding, layout, RPC, vector, JSX export, clipboard, design JSX, and Figma proxy helpers - Replace collision-driven *Fn import aliases with namespace imports and enforce the pattern in lint Validation: - bun run check - bun --filter @open-pencil/vue build - bun run test:dupes * fix(app): forward color input attrs * fix(app): cover section drawing errors * fix(editor): undo option-drag duplicates * docs: document domain subfolder convention * fix(app): handle undo redo on keydown * refactor(app): dispatch shortcuts from keydown * refactor: group prefixed domain modules * refactor(app): use tinykeys for shortcuts * refactor(core): group symbol override modules * refactor(core): group fig kiwi container helper * refactor(canvas): split overlay rendering modules * refactor(vue): remove unused internal barrels * fix(app): lay out demo components before instancing * fix(app): restore demo badge spacing * perf(canvas): split scene and overlay rendering * refactor(vue): wrap wheel gesture lifecycle * fix(canvas): wait for fonts before hiding loader * docs: update unreleased changelog
2026-04-30 12:14:19 +00:00
import ColorInput from '@/components/ColorPicker/ColorInput.vue'
import Tip from './ui/Tip.vue'
import { useDialogUI } from '@/components/ui/dialog'
import { useMenuUI } from '@/components/ui/menu'
import type { VariableType } from '@open-pencil/core/scene-graph'
const open = defineModel<boolean>('open', { default: false })
const cls = useDialogUI({ content: 'flex h-[75vh] w-[800px] max-w-[90vw] flex-col' })
const menuCls = useMenuUI({ content: 'w-44' })
const variableTypeIcons: Record<VariableType, Component> = {
COLOR: IconPalette,
FLOAT: IconHash,
STRING: IconType,
BOOLEAN: IconToggleLeft
}
2026-03-23 14:42:58 +00:00
const { dialogs, panels, variableTypes: variableTypeText } = useI18n()
const variableTypes: Array<{
type: VariableType
label: () => string
description: () => string
}> = [
{
type: 'COLOR',
label: () => variableTypeText.value.color,
description: () => variableTypeText.value.colorHint
},
{
type: 'FLOAT',
label: () => variableTypeText.value.number,
description: () => variableTypeText.value.numberHint
},
{
type: 'STRING',
label: () => variableTypeText.value.text,
description: () => variableTypeText.value.textHint
},
{
type: 'BOOLEAN',
label: () => variableTypeText.value.boolean,
description: () => variableTypeText.value.booleanHint
}
]
2026-03-25 15:26:03 +00:00
2026-03-23 14:42:58 +00:00
const ctx = useVariablesEditor({
colorInput: ColorInput,
icons: variableTypeIcons,
fallbackIcon: IconToggleLeft,
deleteIcon: IconX
})
const collectionInput = templateRef<HTMLInputElement>('collectionInput')
watch(collectionInput, (input) => {
void ctx.focusCollectionInput(input)
})
</script>
<template>
2026-03-24 14:02:01 +00:00
<DialogRoot v-model:open="open">
<DialogPortal>
<DialogOverlay :class="cls.overlay" />
<DialogContent data-test-id="variables-dialog" :class="cls.content">
<div v-if="!ctx.hasCollections" class="flex flex-1 flex-col">
<div class="flex shrink-0 items-center justify-between border-b border-border px-4 py-3">
<DialogTitle class="text-sm font-semibold text-surface">{{
dialogs.localVariables
}}</DialogTitle>
2026-03-24 14:02:01 +00:00
<DialogClose
class="flex size-6 cursor-pointer items-center justify-center rounded border-none bg-transparent text-muted hover:bg-hover hover:text-surface"
>
<icon-lucide-x class="size-4" />
</DialogClose>
</div>
<div class="flex flex-1 items-center justify-center">
<div class="text-center">
2026-03-25 15:26:03 +00:00
<p class="text-sm text-muted">{{ dialogs.noVariableCollections }}</p>
2026-03-24 14:02:01 +00:00
<button
data-test-id="variables-create-collection"
class="mt-2 cursor-pointer rounded bg-hover px-3 py-1.5 text-xs text-surface hover:bg-border"
@click="ctx.addCollection"
>
2026-03-25 15:26:03 +00:00
{{ dialogs.createCollection }}
2026-03-24 14:02:01 +00:00
</button>
</div>
</div>
2026-03-24 14:02:01 +00:00
</div>
2026-03-24 14:02:01 +00:00
<template v-else>
<TabsRoot
v-model="ctx.activeCollectionId.value"
class="flex flex-1 flex-col overflow-hidden"
>
<div class="flex shrink-0 items-center border-b border-border">
<TabsList class="flex flex-1 gap-0.5 overflow-x-auto px-3 py-1">
<template v-for="col in ctx.collections.value" :key="col.id">
<input
v-if="ctx.editingCollectionId.value === col.id"
ref="collectionInput"
2026-03-24 14:02:01 +00:00
class="w-24 rounded border border-accent bg-input px-2 py-0.5 text-xs text-surface outline-none"
:value="col.name"
@blur="ctx.commitRenameCollection(col.id, $event.target as HTMLInputElement)"
@keydown.enter="($event.target as HTMLInputElement).blur()"
@keydown.escape="ctx.editingCollectionId.value = null"
/>
<TabsTrigger
v-else
:value="col.id"
data-test-id="variables-collection-tab"
class="cursor-pointer rounded border-none px-2.5 py-1 text-xs whitespace-nowrap text-muted data-[state=active]:bg-hover data-[state=active]:text-surface"
@dblclick="ctx.startRenameCollection(col.id)"
>
{{ col.name }}
</TabsTrigger>
</template>
</TabsList>
2026-03-24 14:02:01 +00:00
<div class="flex items-center gap-1.5 px-3">
<div class="flex items-center gap-1 rounded border border-border px-2 py-0.5">
<icon-lucide-search class="size-3 text-muted" />
<input
v-model="ctx.searchTerm.value"
data-test-id="variables-search-input"
class="w-24 border-none bg-transparent text-xs text-surface outline-none placeholder:text-muted"
2026-03-25 15:26:03 +00:00
:placeholder="dialogs.search"
2026-03-24 14:02:01 +00:00
/>
</div>
2026-03-25 15:26:03 +00:00
<Tip :label="dialogs.createCollection">
2026-03-24 14:02:01 +00:00
<button
data-test-id="variables-add-collection"
class="flex size-6 cursor-pointer items-center justify-center rounded border-none bg-transparent text-muted hover:bg-hover hover:text-surface"
2026-03-24 14:02:01 +00:00
@click="ctx.addCollection"
>
2026-03-24 14:02:01 +00:00
<icon-lucide-folder-plus class="size-3.5" />
</button>
</Tip>
<DialogClose
class="flex size-6 cursor-pointer items-center justify-center rounded border-none bg-transparent text-muted hover:bg-hover hover:text-surface"
>
<icon-lucide-x class="size-4" />
</DialogClose>
</div>
2026-03-24 14:02:01 +00:00
</div>
2026-03-24 14:02:01 +00:00
<TabsContent
v-for="col in ctx.collections.value"
:key="col.id"
:value="col.id"
class="flex flex-1 flex-col overflow-hidden outline-none"
>
<div class="flex-1 overflow-auto">
<table
class="w-full border-collapse"
:style="{ width: `${ctx.table.getCenterTotalSize()}px` }"
>
<thead class="sticky top-0 z-10 bg-panel">
<tr
v-for="headerGroup in ctx.table.getHeaderGroups()"
:key="headerGroup.id"
class="border-b border-border"
>
<th
v-for="header in headerGroup.headers"
:key="header.id"
class="relative px-4 py-2 text-left text-[11px] font-medium text-muted"
:style="{ width: `${header.getSize()}px` }"
>
2026-03-24 14:02:01 +00:00
<FlexRender
v-if="!header.isPlaceholder"
:render="header.column.columnDef.header"
:props="header.getContext()"
/>
<div
v-if="header.column.getCanResize()"
class="absolute top-0 right-0 h-full w-1 cursor-col-resize touch-none select-none"
:class="
header.column.getIsResizing()
? 'bg-accent'
: 'bg-transparent hover:bg-border'
"
@mousedown="header.getResizeHandler()?.($event)"
@touchstart="header.getResizeHandler()?.($event)"
@dblclick="header.column.resetSize()"
/>
</th>
</tr>
</thead>
<tbody>
<tr
v-for="row in ctx.table.getRowModel().rows"
:key="row.id"
data-test-id="variable-row"
class="group border-b border-border/30 hover:bg-hover/50"
>
<td
v-for="cell in row.getVisibleCells()"
:key="cell.id"
class="px-4 py-1.5"
:style="{ width: `${cell.column.getSize()}px` }"
>
2026-03-24 14:02:01 +00:00
<FlexRender
:render="cell.column.columnDef.cell"
:props="cell.getContext()"
/>
</td>
</tr>
</tbody>
</table>
</div>
<div class="flex w-full shrink-0 items-center justify-between gap-2 border-t border-border px-4 py-2">
<span class="text-xs text-muted">{{ panels.createVariable }}</span>
<DropdownMenuRoot>
<DropdownMenuTrigger as-child>
<button
data-test-id="variables-add-variable"
class="flex cursor-pointer items-center gap-1.5 rounded bg-hover px-2.5 py-1.5 text-xs text-surface hover:bg-border"
>
<icon-lucide-plus class="size-3.5" />
{{ panels.add }}
<icon-lucide-chevron-down class="size-3" />
</button>
</DropdownMenuTrigger>
<DropdownMenuPortal>
<DropdownMenuContent side="top" :side-offset="8" align="end" :class="menuCls.content">
<DropdownMenuItem
v-for="item in variableTypes"
:key="item.type"
:class="menuCls.item"
:data-test-id="`variables-add-${item.type.toLowerCase()}`"
@select="ctx.addVariable(item.type)"
>
<component :is="variableTypeIcons[item.type]" :class="menuCls.icon" />
<span class="flex min-w-0 flex-1 flex-col">
<span>{{ item.label() }}</span>
<span class="truncate text-[10px] text-muted">{{ item.description() }}</span>
</span>
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenuPortal>
</DropdownMenuRoot>
</div>
2026-03-24 14:02:01 +00:00
</TabsContent>
</TabsRoot>
</template>
</DialogContent>
</DialogPortal>
</DialogRoot>
</template>