elsa-core/test/integration/Elsa.Dsl.ElsaScript.IntegrationTests/CompilerTests.cs
Sipke Schoorstra a1d4e541fc
Add Elsa Script DSL (#7076)
* Update packages.yml

* Update elsa-server-and-studio.yml

* Update elsa-server.yml

* Update elsa-studio.yml (#6715)

* Update ListWorkflowDefinitionsRequest.cs (#6761)

Remove unnecessary line breaks

* Correct namespace and import for `ConfigureEngineWithVariableTypes`.

* Resolves build issues, update package versions and restructure project references

- Updated multiple package versions in `Directory.Packages.props` for better dependency management, including `BenchmarkDotNet`, `FastEndpoints`, and `Microsoft.Extensions.Http.Resilience`.
- Minor version upgrade for `System.Formats.Asn1` in `_build.csproj`.
- Replaced project reference to `Elsa.csproj` with `Elsa.IO.Http.csproj` in `Elsa.ServerAndStudio.Web.csproj`, enhancing modularity.
- Added new using directive for `Elsa.IO.Http.Features` in `Program.cs` to support new HTTP functionalities.

* Remove unused project references from Elsa.sln

These changes indicate that the associated projects or dependencies are no longer needed or have been replaced by other components in the solution.

* Rename copilot-setup-steps.yml.yml to copilot-setup-steps.yml

* Update RawStringContent encoding in JsonContentFactory (#6786)

* Update RawStringContent encoding in JsonContentFactory

Modified the instantiation of `RawStringContent` to use a
new `UTF8Encoding` instance with `encoderShouldEmitUTF8Identifier`
set to `false`, affecting the handling of the UTF-8 byte order
mark (BOM) in serialized JSON content. Fixes a bug with content length being different than expected.

* Refactor JsonContentFactory to reuse UTF8Encoding

Introduced a private static readonly field `_utf8Encoding` in the `JsonContentFactory` class to improve code readability and performance. This change replaces the instantiation of `UTF8Encoding` in the `CreateHttpContent` method, allowing for the reuse of the same encoding instance.

---------

Co-authored-by: Max Brooks <Max@compyl.com>

* Enhance thread safety with ConcurrentDictionary usage (#6760)

* Enhance thread safety with ConcurrentDictionary usage

Replaced `IDictionary` with `ConcurrentDictionary` for
both `_scheduledTasks` and `_scheduledTaskKeys` to
improve thread safety in a multi-threaded environment.

Updated methods `RegisterScheduledTask`,
`RemoveScheduledTask`, and `RemoveScheduledTasks` to
utilize the `Remove` method of `ConcurrentDictionary`,
ensuring safe and efficient removal of scheduled tasks.

* Refactor task registration and removal logic

Updated `RegisterScheduledTask` to use `AddOrUpdate` for streamlined task management. This change simplifies the addition and updating of scheduled tasks by consolidating logic into a single operation. Introduced `RemoveScheduledTask` method to handle task removal by name, improving code organization and clarity.

* Improve task removal handling in LocalScheduler

Modified the `LocalScheduler` class to enhance the removal process of scheduled tasks from the `_scheduledTaskKeys` collection. The removal operation now captures the result in a variable and includes a conditional check to log a warning if the task was not found, improving error handling and debugging capabilities.

* Refactor task removal in LocalScheduler

Updated the removal process for scheduled tasks in `_scheduledTasks`.
The new implementation collects all corresponding keys and attempts to remove them individually, logging warnings for any failures. This enhances error handling and provides better debugging information.

---------

Co-authored-by: Max Brooks <Max@compyl.com>

* Add IAsyncEnumerable check to ItemSourceActivityExecutionContextExtensions.GetItemSource (#6897)

* Use FullName in WorkflowDictionary (#6923)

* Fixed ParentWorkflowInstanceId not being set (#7029)

Co-authored-by: Peter Klooster <peter.klooster@autotaalglas.nl>

* Remove unused solution projects and update package references

- Deleted several project references from `Elsa.sln` to clean up the solution.
- Updated `Directory.Packages.props` for consistency and alignment with the latest package versions.

* Simplify CI pipeline by removing `Test` step from `Compile+Test+Pack` process.

* Initial plan

* Add ElsaScript DSL module with parser and compiler

Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

* Add integration tests for ElsaScript DSL

Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

* Add comprehensive documentation for ElsaScript DSL

Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

* Refactor workflow activity instantiation logic

- Removed `ActivityFactory` and its related interfaces and extensions.
- Introduced `ActivityActivator` for handling activity creation.
- Extended AST with support for comprehensive workflow structures:
  - Added nodes for flowcharts, if/else, loops, and variable declarations.
- Updated `IElsaScriptCompiler` to use asynchronous methods.
- Expanded `ElsaScriptParser` to simplify syntax for `UseNode` and argument parsing.
- Adjusted compiler and parser for compatibility with new workflow AST model.

* Refactor test method names for clarity and add new compiler and parser tests

- Updated method names in `CompilerTests` and `ParserTests` for better readability and description of test intent.
- Added tests for compiler and parser:
  - Support for workflows without the `workflow` keyword.

* Refactor `ElsaScriptParser` to improve statement parsing and introduce a tokenizer

- Added `TokenizeStatements` method to split source into statements for enhanced parsing accuracy.
- Updated logic to process statements instead of raw lines, reducing parsing complexity and improving reliability.
- Improved handling of workflow and statement parsing, including edge cases with braces, parentheses, and string literals.

* Introduce ElsaScript support for BlobStorage workflow provider

- Added the `Elsa.WorkflowProviders.BlobStorage.ElsaScript` module to enable ElsaScript-based workflow definitions for BlobStorage.
- Implemented `ElsaScriptBlobWorkflowFormatHandler` for parsing ElsaScript workflows stored in BlobStorage.
- Extended `ElsaScriptParser` to leverage Parlot for improved DSL parsing.
- Introduced `IBlobWorkflowFormatHandler` to centralize workflow format handling and parsing.
- Updated `Elsa.Server.Web` to reference the new module and include an ElsaScript "Hello World" example workflow.

* Refactor ElsaScript services, update logging, and improve workflow handling

- Changed `ElsaScriptCompiler` service registration from `Singleton` to `Scoped` for better dependency management.
- Enhanced the "Hello World" example workflow and added `CopyToOutputDirectory` configuration.
- Removed unused namespaces and adjusted references in multiple projects to improve maintainability.
- Updated logging levels in `appsettings.json` to reduce unnecessary debug output.
- Improved `PolymorphicObjectConverter` by removing redundant dependencies.
- Added missing references to enhance feature support and ensure compatibility.

* Refactor activity instantiation and improve argument handling in `ElsaScriptCompiler`

- Added support for positional arguments with constructor matching logic.
- Refactored `InstantiateActivityUsingConstructor` to enhance activity creation.
- Updated `ActivityDescriptor` and related types to include `ClrType` for streamlined activity resolution.
- Simplified `TypedActivityProvider` by annotating it with `[UsedImplicitly]`.
- Adjusted `ElsaScriptParser` to remove unnecessary options from string literal definitions.

* Add HTTP-enabled "Hello World" workflow and support for additional HTTP activity constructors

- Introduced a new ElsaScript example workflow `hello-world-http.elsa` with an HTTP endpoint and response.
- Enhanced `HttpEndpoint` and `WriteHttpResponse` activities with additional constructors for improved flexibility.
- Updated project to include the new workflow in the output directory.

* Enhance `ElsaScriptParser` with a custom parser to handle nested raw expressions for ElsaScript workflows

- Introduced `RawExpressionParser` to parse raw text after `=>` up to a matching closing parenthesis.
- Updated `elsaExpressionWithLang` and `elsaExpressionWithoutLang` to use `RawExpressionParser`.
- Trimmed whitespace in parsed expressions.
- Added integration and parser tests for complex workflows with variables and expressions.
- Updated example workflow `hello-world-http.elsa` to demonstrate expression usage.
- Added `Elsa.Http` module reference to enable HTTP-based activities.

* Update "Hello World" workflow to simplify naming and enhance response logic

- Renamed workflow from `HelloWorldHttpDsl2` to `HelloWorldHttpDsl`.
- Updated HTTP endpoint path to `/hello-world-dsl` for consistency.
- Improved response logic by utilizing `getMessage()` JavaScript function.

* Add support for `OriginalSource` in workflow materialization and enhance ElsaScript materializer

- Introduced `OriginalSource` property in `WorkflowDefinition` and `MaterializedWorkflow` for preserving original source representation (e.g., ElsaScript, JSON, YAML).
- Added `ElsaScriptWorkflowMaterializer` implementation to materialize workflows directly from ElsaScript source.
- Updated `DefaultWorkflowDefinitionStorePopulator` to determine `StringData` or `OriginalSource` based on materialized workflow format.
- Enhanced `WorkflowDefinitionMapper` to support symmetric round-tripping with `OriginalSource`.
- Registered `ElsaScriptWorkflowMaterializer` in `ElsaScriptFeature` for dependency injection.
- Updated `JsonBlobWorkflowFormatHandler` and added `OriginalSource` support for round-trip preservation.
- Simplified `ElsaScriptParser` by aligning variable and parser naming.

* Update V3_6 migrations for PostgreSQL, MySQL, and Oracle databases and associated designer files.

* Handle disposal and race conditions in `ScheduledCronTask`

- Added `_disposed` flag to prevent accessing disposed resources.
- Updated `_executionSemaphore` and `_scopeFactory` logic to safely handle `ObjectDisposedException`.
- Enhanced task scheduling and timer disposal with additional safeguards against race conditions.
- Modified tests to ensure proper disposal and logging behavior when handling edge cases.

* Add support for metadata in ElsaScript workflows and enhance parser and compiler functionality

- Introduced metadata syntax in ElsaScript workflows (e.g., `DisplayName`, `Description`, `Version`) to enable metadata-driven behavior.
- Enhanced `ElsaScriptCompiler` to process metadata and properly integrate it into `Workflow` objects.
- Updated `ElsaScriptParser` to parse program-level AST with support for multiple workflows and global use statements.
- Refactored tests to validate metadata parsing and ensure backward compatibility with existing workflows.
- Added new test cases to cover scenarios like metadata parsing, compilation, and multi-workflow programs.

* Add support for `foreach` loops in ElsaScript and remove `let` keyword

- Introduced `foreach` loop syntax in `ElsaScriptParser` and `ElsaScriptCompiler`, enabling iteration over collections with optional variable declaration.
- Updated `ForNode` and `ForEachNode` to include a `DeclaresVariable` flag for improved variable handling.
- Removed support for the `let` keyword in variable declarations, streamlining syntax to use `var` and `const` only.
- Enhanced `for` loop syntax to support optional `var` declaration and block or single-statement bodies.
- Refactored test cases to validate `foreach` and `for` loop enhancements and ensure backward compatibility.

* Simplify ElsaScript workflow syntax by removing redundant quotes in workflow identifiers and updating `for` loop syntax for clarity and consistency.

* Remove redundant quotes from workflow identifiers in integration tests

* Simplify Elsa scripts and improve error handling

- Removed redundant braces in workflow declarations for streamlined syntax.
- Enhanced logging in `JsonBlobWorkflowFormatHandler` and `ElsaScriptBlobWorkflowFormatHandler` to warn on parsing errors and provide context.
- Updated configuration to log errors for `Elsa.Workflows.ActivityRegistry`.
- Refined "Hello World" and "For Loop" workflows for clarity and added improved loop handling.

* Refine Elsa workflows and update compiler logic

- Simplified "Hello World" workflow by adding braces and improving consistency.
- Adjusted "For Loop" workflow to rename and clarify logic, including expression updates and variable handling.
- Fixed compiler mapping of `"cs"` to `"CSharp"` for better clarity.
- Enhanced "Hello World HTTP" workflow to correctly reference `variables.message` in expressions.

* Add flowchart support in ElsaScript parser, compiler, and integration tests

- Introduced `flowchart` syntax in `ElsaScriptParser` to support flowchart-based workflows.
- Updated `ElsaScriptCompiler` to compile `flowchart` nodes with labeled activities, connections, entry points, and variables.
- Added integration tests for parsing and compiling empty and simple flowcharts.
- Enhanced `FlowchartNode` and `LabeledActivityNode` for better representation of flowchart structures.
- Improved error handling and logging for invalid flowchart configurations.

* Add tests for compiling and parsing flowcharts with nodes, connections, and block nodes in ElsaScript

- Added integration tests for compiling and validating flowchart structures, including activities, connections, and entry points.
- Implemented parser tests for parsing flowcharts with node connections and block nodes.
- Updated project files to include new workflow examples for testing.

* Add Parlot package and update project file in integration tests

- Added `Parlot` package version `0.0.27` to `Directory.Packages.props`.
- Updated integration test project file to include a new `Include` directive for better targeting.

* Update Parlot package to version 1.5.2 in Directory.Packages.props

* Remove `elsa-server-and-studio.yml` workflow and update solution file

- Deleted `elsa-server-and-studio.yml` workflow as it's no longer needed.
- Updated `Elsa.sln` to remove reference to the deleted workflow.

* Remove `elsa-studio.yml` workflow and update solution and packages

- Deleted `elsa-studio.yml` workflow as it's no longer used.
- Updated `Elsa.sln` to remove reference to the deleted workflow.
- Changed `base_version` in `packages.yml` from `3.7.0` to `3.6.0`.

* Downgrade Docker image in `elsa-server.yml` workflow from `v3.7.0-preview` to `v3.6.0-preview`

* Update Docker image tag in `elsa-server.yml` workflow from `v3.6.0-preview` to `v3.6-preview`

* Add logging support to `LocalScheduler` and replace `Debug.WriteLine` with `ILogger`

* Remove unused `System.Collections.Generic` and `Elsa.Extensions` imports in `LocalScheduler`

- Cleaned up unnecessary using directives to improve code readability and maintainability.
- Minor whitespace adjustment for consistent formatting.

* Remove unnecessary whitespace in `LocalScheduler` for consistent formatting

* Improve exception handling in blob workflow format handlers

- Updated exception handling in `ElsaScriptBlobWorkflowFormatHandler` and `JsonBlobWorkflowFormatHandler` to gracefully catch and log all exceptions during workflow parsing.
- Adjusted comments to clarify behavior for invalid user-provided files, ensuring the workflow loading process is not disrupted.

* Refactor blob workflow format handlers to use `SupportedExtensions` for improved file filtering

- Added `SupportedExtensions` property to all blob format handlers to optimize blob storage browsing.
- Simplified `CanHandle` logic by removing extension checks, leveraging `SupportedExtensions` for initial filtering.
- Updated comments for clarity and consistency across handlers.

* Refactor `DefaultWorkflowDefinitionStorePopulator` to simplify `stringData` assignment logic and improve readability

* Remove outdated comment in `CompilerTests` about skipped tests

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Refactor `ElsaScriptCompiler` to streamline type conversion logic, improve language mapping, and enhance asynchronous flowchart compilation

* [WIP] Update ParseError printing based on feedback (#7082)

* Initial plan

* Fix ParseError formatting to use Message and Position properties

Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

* Replace `as` casts with direct casts in ParserTests for null safety (#7083)

* Initial plan

* Replace 'as' casts with direct casts in ParserTests for better null safety

Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

* Fix Oracle column types for OriginalSource and other large text fields (#7079)

* Initial plan

* Fix Oracle OriginalSource and StringData column types to handle large data

Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

* Refactor tests to replace type checks with `Assert.IsType` for improved clarity and type safety

* Initial plan (#7080)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* Add `Parlot` package reference and update solution structure by removing and reorganizing projects and workflows.

* Set default expression language to "JavaScript" in `ElsaScriptCompiler`.

* Add integration test to verify default expression language resets between ElsaScript compilations

* Simplify UTF-8 encoding in JsonContentFactory (#7081)

* Initial plan

* Remove explicit UTF8Encoding in JsonContentFactory and use Encoding.UTF8

Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

* Fix test to use Encoding.UTF8.GetByteCount for multi-byte character support

Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

---------

Co-authored-by: Ender <37611092+zengande@users.noreply.github.com>
Co-authored-by: Matt <knibbsy10@live.com>
Co-authored-by: Max Brooks <45081361+MaxBrooks114@users.noreply.github.com>
Co-authored-by: Max Brooks <Max@compyl.com>
Co-authored-by: FuJa0815 <30809803+FuJa0815@users.noreply.github.com>
Co-authored-by: Peter Klooster <crashkonijn@gmail.com>
Co-authored-by: Peter Klooster <peter.klooster@autotaalglas.nl>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-25 19:57:50 +01:00

416 lines
13 KiB
C#

using Elsa.Dsl.ElsaScript.Contracts;
using Elsa.Extensions;
using Elsa.Http;
using Elsa.Testing.Shared;
using Elsa.Workflows.Activities;
using Elsa.Workflows.Models;
using Microsoft.Extensions.DependencyInjection;
using Xunit.Abstractions;
namespace Elsa.Dsl.ElsaScript.IntegrationTests;
/// <summary>
/// Integration tests for the ElsaScript compiler.
/// </summary>
public class CompilerTests
{
private readonly IElsaScriptCompiler _compiler;
public CompilerTests(ITestOutputHelper testOutputHelper)
{
var services = new TestApplicationBuilder(testOutputHelper)
.ConfigureElsa(elsa =>
{
elsa.UseElsaScript();
elsa.AddActivitiesFrom<HttpEndpoint>();
})
.Build();
_compiler = services.GetRequiredService<IElsaScriptCompiler>();
}
[Fact(DisplayName = "Compiler can compile a simple workflow from source")]
public async Task CompileAsync_WithSimpleWorkflowSource_ShouldCreateWorkflowWithCorrectName()
{
// Arrange
var source = @"
use Elsa.Activities.Console;
use expressions js;
workflow HelloWorld {
WriteLine(""Hello World"");
}";
// Act
var workflow = await _compiler.CompileAsync(source);
// Assert - verify the workflow is correctly compiled
Assert.NotNull(workflow);
Assert.Equal("HelloWorld", workflow.Name);
Assert.NotNull(workflow.Root);
}
[Fact(DisplayName = "Compiler can compile workflow with variable declarations")]
public async Task CompileAsync_WithVariableDeclarations_ShouldCreateWorkflowWithAllVariables()
{
// Arrange
var source = @"
use expressions js;
workflow VariableTest {
var message = ""Hello from variable"";
var count = 42;
const pi = 3.14;
}";
// Act
var workflow = await _compiler.CompileAsync(source);
// Assert - verify variables are compiled correctly
Assert.NotNull(workflow);
Assert.Equal("VariableTest", workflow.Name);
Assert.Equal(3, workflow.Variables.Count);
Assert.Contains(workflow.Variables, v => v.Name == "message");
Assert.Contains(workflow.Variables, v => v.Name == "count");
Assert.Contains(workflow.Variables, v => v.Name == "pi");
}
[Fact(DisplayName = "Compiler can compile workflow without workflow keyword")]
public async Task CompileAsync_WithoutWorkflowKeyword_ShouldCreateWorkflow()
{
// Arrange
var source = @"WriteLine(""Hello World"");";
// Act
var workflow = await _compiler.CompileAsync(source);
// Assert
Assert.NotNull(workflow);
Assert.NotNull(workflow.Root);
}
[Fact(DisplayName = "Compiler can compile complex workflow with variables, listen statements, and expressions")]
public async Task CompileAsync_WithComplexWorkflow_ShouldCreateWorkflowWithCorrectStructure()
{
// Arrange
var source = @"
use expressions js;
workflow HelloWorldHttpDsl {
var message = ""Hello World from DSL via Expressions!"";
listen HttpEndpoint(""/hello-world-dsl"");
WriteLine(js => `Message: ${message}`);
WriteHttpResponse(message);
}";
// Act
var workflow = await _compiler.CompileAsync(source);
// Assert
Assert.NotNull(workflow);
Assert.Equal("HelloWorldHttpDsl", workflow.Name);
// Verify workflow has the message variable
Assert.Single(workflow.Variables);
var messageVar = workflow.Variables.First();
Assert.Equal("message", messageVar.Name);
Assert.Equal("Hello World from DSL via Expressions!", messageVar.Value);
// Verify root is a Sequence with 3 activities (HttpEndpoint, WriteLine, WriteHttpResponse)
var sequence = Assert.IsType<Sequence>(workflow.Root);
Assert.Equal(3, sequence.Activities.Count);
// Verify HttpEndpoint activity (from listen statement)
var httpEndpoint = sequence.Activities.ElementAt(0);
Assert.Equal("Elsa.HttpEndpoint", httpEndpoint.Type);
// Verify HttpEndpoint can start workflow (CanStartWorkflow property should be true)
var canStartWorkflowProp = httpEndpoint.GetType().GetProperty("CanStartWorkflow");
Assert.NotNull(canStartWorkflowProp);
var canStartWorkflow = (bool)canStartWorkflowProp.GetValue(httpEndpoint)!;
Assert.True(canStartWorkflow);
// Verify WriteLine activity with JavaScript expression
var writeLine = sequence.Activities.ElementAt(1);
Assert.Equal("Elsa.WriteLine", writeLine.Type);
var textProp = writeLine.GetType().GetProperty("Text");
Assert.NotNull(textProp);
var textInput = Assert.IsType<Input<string>>(textProp.GetValue(writeLine));
// Verify it's a JavaScript expression
var expression = textInput.Expression;
Assert.NotNull(expression);
Assert.Equal("JavaScript", expression.Type);
Assert.Contains("Message:", expression.Value?.ToString());
Assert.Contains("message", expression.Value?.ToString());
// Verify WriteHttpResponse activity with variable reference
var writeHttpResponse = sequence.Activities.ElementAt(2);
Assert.Equal("Elsa.WriteHttpResponse", writeHttpResponse.Type);
var contentProp = writeHttpResponse.GetType().GetProperty("Content");
Assert.NotNull(contentProp);
var contentInput = Assert.IsType<Input<object>>(contentProp.GetValue(writeHttpResponse));
// Verify it references the message variable
var memoryBlockReference = contentInput.MemoryBlockReference();
Assert.NotNull(memoryBlockReference);
Assert.Equal(messageVar.Id, memoryBlockReference.Id);
}
[Fact(DisplayName = "Compiler can compile for loop with 'to' keyword (exclusive)")]
public async Task CompileAsync_WithForLoopExclusive_ShouldCreateForActivity()
{
// Arrange
var source = @"
use expressions js;
workflow ForLoopTest {
for (var i = 0 to 10 step 1)
{
WriteLine(js => `Step: ${i}`)
}
}";
// Act
var workflow = await _compiler.CompileAsync(source);
// Assert
Assert.NotNull(workflow);
Assert.Equal("ForLoopTest", workflow.Name);
// Verify the For activity is created
var forActivity = Assert.IsType<For>(workflow.Root);
Assert.NotNull(forActivity);
// Verify Start, End, Step values
Assert.NotNull(forActivity.Start);
Assert.NotNull(forActivity.End);
Assert.NotNull(forActivity.Step);
// Verify OuterBoundInclusive is false (exclusive 'to')
Assert.NotNull(forActivity.OuterBoundInclusive);
var outerBoundInput = forActivity.OuterBoundInclusive;
var outerBoundExpr = outerBoundInput.Expression;
Assert.NotNull(outerBoundExpr);
Assert.False((bool?)outerBoundExpr.Value);
// Verify loop variable exists
Assert.Single(workflow.Variables);
var loopVar = workflow.Variables.First();
Assert.Equal("i", loopVar.Name);
// Verify body exists
Assert.NotNull(forActivity.Body);
}
[Fact(DisplayName = "Compiler can compile for loop with 'through' keyword (inclusive)")]
public async Task CompileAsync_WithForLoopInclusive_ShouldCreateForActivity()
{
// Arrange
var source = @"
use expressions js;
workflow ForLoopInclusiveTest {
for (var i = 0 through 10 step 1)
{
WriteLine(js => `Step: ${i}`)
}
}";
// Act
var workflow = await _compiler.CompileAsync(source);
// Assert
Assert.NotNull(workflow);
Assert.Equal("ForLoopInclusiveTest", workflow.Name);
// Verify the For activity is created
var forActivity = Assert.IsType<For>(workflow.Root);
Assert.NotNull(forActivity);
// Verify OuterBoundInclusive is true (inclusive 'through')
Assert.NotNull(forActivity.OuterBoundInclusive);
var outerBoundInput = forActivity.OuterBoundInclusive;
var outerBoundExpr = outerBoundInput.Expression;
Assert.NotNull(outerBoundExpr);
Assert.True((bool?)outerBoundExpr.Value);
// Verify loop variable exists
Assert.Single(workflow.Variables);
var loopVar = workflow.Variables.First();
Assert.Equal("i", loopVar.Name);
}
[Fact(DisplayName = "Compiler can compile workflow with metadata")]
public async Task CompileAsync_WithWorkflowMetadata_ShouldCreateWorkflowWithCorrectMetadata()
{
// Arrange
var source = @"
use Elsa.Activities.Console;
workflow HelloWorldDsl(
DisplayName: ""Hello World DSL"",
Description: ""Demonstrates ElsaScript with metadata"",
DefinitionId: ""hello-world-dsl"",
DefinitionVersionId: ""hello-world-dsl-v1"",
Version: 2,
UsableAsActivity: true
) {
use expressions js;
WriteLine(""Hello World from Elsa DSL!"");
}";
// Act
var workflow = await _compiler.CompileAsync(source);
// Assert
Assert.NotNull(workflow);
// Check identity
Assert.Equal("hello-world-dsl", workflow.Identity.DefinitionId);
Assert.Equal(2, workflow.Identity.Version);
Assert.Equal("hello-world-dsl-v1", workflow.Identity.Id);
// Check metadata
Assert.Equal("Hello World DSL", workflow.WorkflowMetadata.Name);
Assert.Equal("Demonstrates ElsaScript with metadata", workflow.WorkflowMetadata.Description);
// Check options
Assert.True(workflow.Options.UsableAsActivity);
// Check root activity
Assert.NotNull(workflow.Root);
}
[Fact(DisplayName = "Compiler can compile empty flowchart")]
public async Task CompileAsync_WithEmptyFlowchart_ShouldCreateFlowchartActivity()
{
// Arrange
var source = @"
workflow FlowchartTest {
flowchart {
}
}";
// Act
var workflow = await _compiler.CompileAsync(source);
// Assert
Assert.NotNull(workflow);
Assert.NotNull(workflow.Root);
Assert.IsType<Workflows.Activities.Flowchart.Activities.Flowchart>(workflow.Root);
}
[Fact(DisplayName = "Compiler can compile flowchart with node and connection")]
public async Task CompileAsync_WithFlowchartNodeAndConnection_ShouldCreateFlowchartWithCorrectStructure()
{
// Arrange
var source = @"
workflow FlowchartTest {
flowchart {
entry Start;
Start: WriteLine();
End: WriteLine();
Start -> End;
}
}";
// Act
var workflow = await _compiler.CompileAsync(source);
// Assert
Assert.NotNull(workflow);
Assert.NotNull(workflow.Root);
var flowchart = Assert.IsType<Workflows.Activities.Flowchart.Activities.Flowchart>(workflow.Root);
// Check that flowchart has 2 activities
Assert.Equal(2, flowchart.Activities.Count);
// Check connections
Assert.Single(flowchart.Connections);
// Check entry point is set
Assert.NotNull(flowchart.Start);
}
[Fact(DisplayName = "Compiler can compile flowchart with block node")]
public async Task CompileAsync_WithFlowchartBlockNode_ShouldCreateSequenceActivity()
{
// Arrange
var source = @"
workflow FlowchartWithBlock {
flowchart {
entry Start;
Start: {
WriteLine(""First"");
WriteLine(""Second"");
}
}
}";
// Act
var workflow = await _compiler.CompileAsync(source);
// Assert
Assert.NotNull(workflow);
Assert.NotNull(workflow.Root);
var flowchart = Assert.IsType<Workflows.Activities.Flowchart.Activities.Flowchart>(workflow.Root);
// Should have one activity
Assert.Single(flowchart.Activities);
// The activity should be a Sequence (from the block)
var sequenceActivity = Assert.IsType<Sequence>(flowchart.Activities.First());
// Sequence should have 2 activities
Assert.Equal(2, sequenceActivity.Activities.Count);
}
[Fact(DisplayName = "Compiler resets default expression language between compilations")]
public async Task CompileAsync_WithSecondWorkflowAfterLiquid_ShouldResetToJavaScript()
{
// Arrange - First workflow sets Liquid as default
var firstSource = @"
use expressions liquid;
workflow FirstWorkflow {
WriteLine(liquid => ""{{ 'test' }}"");
}";
// Second workflow with no 'use expressions' directive
var secondSource = @"
workflow SecondWorkflow {
WriteLine(js => ""test"");
}";
// Act - Compile first workflow (sets default to Liquid)
var firstWorkflow = await _compiler.CompileAsync(firstSource);
// Act - Compile second workflow (should reset to JavaScript)
var secondWorkflow = await _compiler.CompileAsync(secondSource);
// Assert - Verify first workflow used Liquid
Assert.NotNull(firstWorkflow);
var firstWriteLine = firstWorkflow.Root;
var firstTextProp = firstWriteLine.GetType().GetProperty("Text");
var firstTextInput = Assert.IsType<Input<string>>(firstTextProp!.GetValue(firstWriteLine));
Assert.Equal("Liquid", firstTextInput.Expression?.Type);
// Assert - Verify second workflow uses JavaScript (not leaked Liquid)
Assert.NotNull(secondWorkflow);
var secondWriteLine = secondWorkflow.Root;
var secondTextProp = secondWriteLine.GetType().GetProperty("Text");
var secondTextInput = Assert.IsType<Input<string>>(secondTextProp!.GetValue(secondWriteLine));
Assert.Equal("JavaScript", secondTextInput.Expression?.Type);
}
}