elsa-core/test/integration/Elsa.Workflows.IntegrationTests
Sipke Schoorstra 5ab383ce86
fix: stop requeuing Finished+Interrupted workflow instances (#8052)
* fix: stop requeuing Finished+Interrupted workflow instances

InterruptedRecoveryScanner now requires Status=Running, matching the
sibling crash-recovery task. DrainOrchestrator skips already-terminal
instances so a runner-clobber race cannot stamp Interrupted onto a
Finished row. Fixes #8052.

Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>

* fix: conditionally mark Interrupted so drain cannot clobber Finished

PersistInterruptedAsync no longer SaveAsync-es the Find snapshot. The
store now applies Interrupted only when Status is still non-terminal
(EF: ExecuteUpdate WHERE Status != Finished; memory: mutate the live
row). A runner that commits Finished between read and write keeps its
terminal state, so startup recovery cannot requeue completed work.

Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>

* test: disambiguate NSubstitute Returns for TryMarkInterruptedAsync

Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>

* fix: make in-memory Interrupted mark atomic against completion

Lock the memory-store check and mutations together, then abort if Status
became Finished in-place so drain cannot record Interrupted on a
completed instance.

Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>

* fix: share memory-store lock between Interrupted mark and Save

TryMarkInterruptedAsync now serializes with Save/Update/SaveMany so a
runner's terminal persist cannot land between the non-terminal check
and the Interrupted mutations. A finishing Save therefore cannot leave
Finished+Interrupted.

Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-09-11 23:05:43 -07:00
..
Activities test: refactor with WorkflowTestFixture (#7394) 2026-04-15 14:04:49 +02:00
Api/Bookmarks [codex] Harden initial security remediation slice (#7495) 2026-05-22 00:45:47 +02:00
Core Merge remote-tracking branch 'origin/patch/3.5.4' into release/3.6.0 2025-12-29 20:00:03 +01:00
Evaluation Add Elsa Script DSL (#7076) 2025-11-25 19:57:50 +01:00
GracefulShutdown fix: stop requeuing Finished+Interrupted workflow instances (#8052) 2026-09-11 23:05:43 -07:00
Scenarios Use last version for revert version allocation 2026-08-11 12:39:55 +05:30
Security [codex] Harden C# expression host-code execution (#7519) 2026-05-21 00:50:25 +02:00
Serialization Refactor: Overhauls workflow JSON type serialization (#7549) 2026-05-31 11:09:39 +02:00
SharedHelpers Refactor commit strategy resolution for improved clarity and efficiency; remove unused example files and add a new CommitTracker helper for testing. 2025-12-16 08:01:49 -05:00
Elsa.Workflows.IntegrationTests.csproj Harden Python expression execution (#7507) 2026-05-20 14:19:47 +02:00
Elsa.Workflows.IntegrationTests.csproj.DotSettings
Usings.cs Refactor Workflow Runtimes (#5444) 2024-06-10 19:36:51 +02:00