2fa1a9ef8e
* Harden C# expression host-code execution * Address script authorization review feedback * Harden script authorization failure responses * Address code quality review feedback * Use explicit failure filter in script authorization * Centralize script activity type names * Address script authorization review feedback
55 lines
2.1 KiB
C#
55 lines
2.1 KiB
C#
using Elsa.Expressions.Contracts;
|
|
using Elsa.Expressions.CSharp.Contracts;
|
|
using Elsa.Expressions.CSharp.Options;
|
|
using Elsa.Expressions.CSharp.Services;
|
|
using Elsa.Expressions.Models;
|
|
using Elsa.Testing.Shared;
|
|
using Elsa.Workflows.Activities;
|
|
using Microsoft.Extensions.Caching.Memory;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using NSubstitute;
|
|
|
|
namespace Elsa.Expressions.UnitTests.CSharp;
|
|
|
|
public class CSharpHostCodeExecutionTests
|
|
{
|
|
[Fact]
|
|
public async Task Evaluator_BlocksExecution_WhenHostHasNotOptedIn()
|
|
{
|
|
using var memoryCache = new MemoryCache(new MemoryCacheOptions());
|
|
var evaluator = new CSharpEvaluator(
|
|
Substitute.For<Elsa.Mediator.Contracts.INotificationSender>(),
|
|
Microsoft.Extensions.Options.Options.Create(new CSharpOptions()),
|
|
memoryCache);
|
|
var context = await new ActivityTestFixture(new WriteLine("test")).BuildAsync();
|
|
|
|
var exception = await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
|
evaluator.EvaluateAsync("\"hello\"", typeof(string), context.ExpressionExecutionContext, new ExpressionEvaluatorOptions()));
|
|
|
|
Assert.Contains(nameof(CSharpOptions.AllowHostCodeExecution), exception.Message);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(false)]
|
|
[InlineData(true)]
|
|
public void Descriptor_Browsability_FollowsHostOptIn(bool allowHostCodeExecution)
|
|
{
|
|
var services = new ServiceCollection();
|
|
services.AddOptions();
|
|
services.AddMemoryCache();
|
|
new Elsa.Expressions.CSharp.ShellFeatures.CSharpFeature
|
|
{
|
|
CSharpOptions = options => options.AllowHostCodeExecution = allowHostCodeExecution
|
|
}.ConfigureServices(services);
|
|
services.AddSingleton<IExpressionDescriptorRegistry, Elsa.Workflows.Management.Services.ExpressionDescriptorRegistry>();
|
|
|
|
var serviceProvider = services.BuildServiceProvider();
|
|
var registry = serviceProvider.GetRequiredService<IExpressionDescriptorRegistry>();
|
|
|
|
var descriptor = registry.Find("CSharp");
|
|
|
|
Assert.NotNull(descriptor);
|
|
Assert.Equal(allowHostCodeExecution, descriptor.IsBrowsable);
|
|
}
|
|
}
|