c2fb027c41
* Avoid null endpoint DTO metadata in tests * Enforce console logs hub read permission * Remove unused console logs hub import * Support mapped endpoint metadata in auth tests * Reduce console log capture throughput impact * Address Copilot console logs review * Refactor task scheduling to support tenant-level background work and enhance logging functionality. * Introduce ConsoleStreamHook for stdout/stderr tee and enhance logging validation. Adjust test cases and startup warnings for distributed lock provider usage. * Refactor console logging pipeline with capture optimization and new ConsoleLogsHost; update tests accordingly. * Add Ansi SGR parser for console logs and associated unit tests * Remove ANSI color renderings and parsers; integrate ConsoleLogScopeAccessor for improved logging context with workflow instance ID support. * Address console logs code quality feedback * Address PR review feedback * Preserve console logs extension points * Stabilize console logs host lifecycle * Address final automated review comments * Tighten console log capture shutdown * Address console log review feedback * Address follow-up review feedback * Cover final review feedback * Avoid recursive console provider initialization * Guard console host lease shutdown * Preserve console log scope and provider lifetime * Correlate console log scope fallback * Tighten console scope correlation * Expose host services during provider construction * Redact ANSI-normalized console lines * Remove `ConsoleCaptureTee` and related services and tests * Use pipeline contributors for console log context * Update CShells package versions to 0.0.24-preview.132 * Filter live console logs by workflow instance * Enhance console logging with activity execution metadata and extend test coverage. * Address console logs stream consumption comment * Add diagnostics OpenTelemetry backend * Introduce dedicated workflow JSON type registry and hardening This change addresses GitHub issue #7541 by establishing a separate type registry (`IWorkflowJsonTypeRegistry`) for workflow JSON serialization. This decouples workflow type resolution from expression type aliases, enforcing a strict trust boundary. Key aspects: - New workflow JSON emits preferred aliases for registered types. - Existing persisted workflows can be loaded via registered legacy names. - Unknown, abstract, interface, open generic, or inappropriate collection types are rejected during deserialization, enhancing security. - Public APIs (e.g., incident strategies) now expose consistent workflow JSON type identifiers. This ensures secure, predictable, and backward-compatible handling of types within workflow definitions and payloads. * Remove unused project references and streamline console log endpoint * Move serialization type aliases to Elsa.Common * Update serialization integration fixtures for aliases * Stabilize missing rate limiter policy test
75 lines
3 KiB
C#
75 lines
3 KiB
C#
using Elsa.Common.Features;
|
|
using Elsa.Common.Multitenancy;
|
|
using Elsa.Extensions;
|
|
using Elsa.Features.Abstractions;
|
|
using Elsa.Features.Attributes;
|
|
using Elsa.Features.Services;
|
|
using Elsa.Scheduling.Bookmarks;
|
|
using Elsa.Scheduling.Handlers;
|
|
using Elsa.Scheduling.Services;
|
|
using Elsa.Scheduling.StartupTasks;
|
|
using Elsa.Scheduling.TriggerPayloadValidators;
|
|
using Elsa.Workflows.Management.Features;
|
|
using Elsa.Workflows.Options;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Elsa.Common.Serialization;
|
|
|
|
namespace Elsa.Scheduling.Features;
|
|
|
|
/// <summary>
|
|
/// Provides scheduling features to the system.
|
|
/// </summary>
|
|
[DependsOn(typeof(SystemClockFeature))]
|
|
public class SchedulingFeature : FeatureBase
|
|
{
|
|
/// <inheritdoc />
|
|
public SchedulingFeature(IModule module) : base(module)
|
|
{
|
|
}
|
|
|
|
/// <summary>
|
|
/// Gets or sets the trigger scheduler.
|
|
/// </summary>
|
|
public Func<IServiceProvider, IWorkflowScheduler> WorkflowScheduler { get; set; } = sp => sp.GetRequiredService<DefaultWorkflowScheduler>();
|
|
|
|
/// <summary>
|
|
/// Gets or sets the CRON parser.
|
|
/// </summary>
|
|
public Func<IServiceProvider, ICronParser> CronParser { get; set; } = sp => sp.GetRequiredService<CronosCronParser>();
|
|
|
|
/// <inheritdoc />
|
|
public override void Apply()
|
|
{
|
|
Services
|
|
.AddSingleton<UpdateTenantSchedules>()
|
|
.AddSingleton<ITenantDeletedEvent>(sp => sp.GetRequiredService<UpdateTenantSchedules>())
|
|
.AddSingleton<IScheduler, LocalScheduler>()
|
|
.AddSingleton<CronosCronParser>()
|
|
.AddSingleton(CronParser)
|
|
.AddScoped<ITriggerScheduler, DefaultTriggerScheduler>()
|
|
.AddScoped<IBookmarkScheduler, DefaultBookmarkScheduler>()
|
|
.AddScoped<DefaultWorkflowScheduler>()
|
|
.AddScoped(WorkflowScheduler)
|
|
.AddStartupTask<CreateSchedulesStartupTask>()
|
|
.AddHandlersFrom<ScheduleWorkflows>()
|
|
|
|
//Trigger payload validators.
|
|
.AddTriggerPayloadValidator<CronTriggerPayloadValidator, CronTriggerPayload>()
|
|
|
|
// Graceful shutdown: register scheduled-trigger ingress for diagnostic visibility (FR-006).
|
|
.AddSingleton<Elsa.Workflows.Runtime.IIngressSource, Elsa.Scheduling.IngressSources.ScheduledTriggerIngressSource>();
|
|
|
|
Services.Configure<SerializationTypeOptions>(options =>
|
|
{
|
|
options.RegisterTypeAlias(typeof(CronBookmarkPayload), nameof(CronBookmarkPayload));
|
|
options.RegisterTypeAlias(typeof(CronTriggerPayload), nameof(CronTriggerPayload));
|
|
options.RegisterTypeAlias(typeof(DelayPayload), nameof(DelayPayload));
|
|
options.RegisterTypeAlias(typeof(StartAtPayload), nameof(StartAtPayload));
|
|
options.RegisterTypeAlias(typeof(TimerBookmarkPayload), nameof(TimerBookmarkPayload));
|
|
options.RegisterTypeAlias(typeof(TimerTriggerPayload), nameof(TimerTriggerPayload));
|
|
});
|
|
|
|
Module.Configure<WorkflowManagementFeature>(management => management.AddActivitiesFrom<SchedulingFeature>());
|
|
}
|
|
}
|