elsa-core/test/unit/Elsa.Activities.UnitTests/Scheduling/CronTests.cs
Sipke Schoorstra f51f1e918e
Add extensive unit and component tests for scheduling activities (#7036)
* Add DispatchWorkflow tests with new workflow definitions

- Introduced multiple workflow definitions with varied scenarios including input handling, correlation IDs, and fault handling.
- Enhanced `DispatchWorkflowsTests` with comprehensive test cases to validate `DispatchWorkflow` behavior under different configurations.
- Updated existing workflows and tests for improved structure, readability, and accuracy.
- Refactored and renamed related workflows for consistency across test suites.

* Update test/component/Elsa.Workflows.ComponentTests/Scenarios/Activities/DispatchWorkflows/DispatchWorkflowsTests.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Refactor DispatchWorkflowsTests for readability and maintainability

- Replaced hardcoded constants with named variables for improved clarity.
- Enhanced assertions using utility methods like `Assert.Single` for cleaner code.
- Updated WriteLine activity tests to handle null values reliably.
- Introduced timeout handling for child workflow execution.

* Update GUID length validation in JintJavaScriptFunctionBehaviorTests

- Adjusted `shortGuid` length assertion to accommodate a range of 19-22 characters instead of 20-22.

* Add extensive unit and component tests for scheduling activities

- Introduced unit tests for `Cron`, `Delay`, `Timer`, and `StartAt` scheduling activities, covering general usage and corner cases.
- Added component tests validating `Cron`, `Delay`, `Timer`, and `StartAt` workflows within broader scenarios, focusing on workflow execution, blocking, and resumption of activities.
- Enhanced test project structures with new folder setups aligning to activity categories.
- Updated namespaces and project files to match the new structure and added validation for scheduling logic.

* Refactor Timer activity tests for consistency and reusability

- Extracted shared logic for timer activity tests into `TimerActivityTestBase`.
- Refactored `DelayTests`, `TimerTests`, `CronTests`, and `StartAtTests` to inherit from `TimerActivityTestBase`.
- Removed redundant code and improved test consistency across all timer activity test cases.
- Cleaned up unused imports and optimized namespaces.

* Remove unused folder references from test project files

* [WIP] Update unit and component tests for scheduling activities (#7037)

* Initial plan

* Replace ContainsKey + indexer with TryGetValue in CronTests

Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>

* Fixing build after merge

* Remove DispatchWorkflowsTests and related references from the test suite

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com>
Co-authored-by: lucas.hipolito <lukhipolito@yahoo.com.br>
2025-11-07 21:54:50 +01:00

110 lines
3.6 KiB
C#

using Elsa.Scheduling;
using Elsa.Scheduling.Activities;
using Elsa.Scheduling.Bookmarks;
using Elsa.Testing.Shared;
using Elsa.Workflows;
using Microsoft.Extensions.DependencyInjection;
using NSubstitute;
namespace Elsa.Activities.UnitTests.Scheduling;
public class CronTests
{
[Theory]
[InlineData("0 0 0 * * *")] // Daily at midnight
[InlineData("0 0 */6 * * *")] // Every 6 hours
[InlineData("0 0 9 * * MON-FRI")] // Weekdays at 9 AM
public async Task WhenNotTrigger_CreatesBookmarkWithParsedTime(string cronExpression)
{
// Arrange
var expectedTime = new DateTimeOffset(2025, 1, 7, 0, 0, 0, TimeSpan.Zero);
var cronParser = CreateCronParser(expectedTime);
var activity = Cron.FromCronExpression(cronExpression);
// Act
var context = await ExecuteAsync(activity, cronParser);
// Assert
Assert.Equal(ActivityStatus.Running, context.Status);
var payload = GetCronPayload(context);
Assert.Equal(expectedTime, payload.ExecuteAt);
Assert.Equal(cronExpression, payload.CronExpression);
}
[Fact]
public async Task WhenIsTrigger_CompletesImmediately()
{
// Arrange
var activity = Cron.FromCronExpression("0 0 0 * * *");
// Act
var context = await ExecuteAsTriggerAsync(activity);
// Assert
Assert.Equal(ActivityStatus.Completed, context.Status);
Assert.Empty(context.WorkflowExecutionContext.Bookmarks);
}
[Fact]
public async Task RecordsExecuteAtInJournal()
{
// Arrange
var expectedTime = new DateTimeOffset(2025, 1, 7, 0, 0, 0, TimeSpan.Zero);
var cronParser = CreateCronParser(expectedTime);
var activity = Cron.FromCronExpression("0 0 0 * * *");
// Act
var context = await ExecuteAsync(activity, cronParser);
// Assert
Assert.True(context.JournalData.TryGetValue("ExecuteAt", out var executeAt));
Assert.Equal(expectedTime, executeAt);
}
[Fact]
public async Task FactoryMethod_CreatesWithExpression()
{
// Arrange
var cronExpression = "0 0 12 * * *";
var expectedTime = new DateTimeOffset(2025, 1, 7, 12, 0, 0, TimeSpan.Zero);
var cronParser = CreateCronParser(expectedTime);
var activity = Cron.FromCronExpression(cronExpression);
// Act
var context = await ExecuteAsync(activity, cronParser);
// Assert
var payload = GetCronPayload(context);
Assert.Equal(cronExpression, payload.CronExpression);
}
private static async Task<ActivityExecutionContext> ExecuteAsync(Cron activity, ICronParser cronParser)
{
return await new ActivityTestFixture(activity)
.ConfigureServices(services => services.AddSingleton(cronParser))
.ExecuteAsync();
}
private static async Task<ActivityExecutionContext> ExecuteAsTriggerAsync(Cron activity)
{
return await new ActivityTestFixture(activity)
.ConfigureContext(ctx => ctx.WorkflowExecutionContext.TriggerActivityId = ctx.Activity.Id)
.ExecuteAsync();
}
private static ICronParser CreateCronParser(DateTimeOffset returnValue)
{
var parser = Substitute.For<ICronParser>();
parser.GetNextOccurrence(Arg.Any<string>()).Returns(returnValue);
return parser;
}
private static CronBookmarkPayload GetCronPayload(ActivityExecutionContext context)
{
var bookmark = Assert.Single(context.WorkflowExecutionContext.Bookmarks);
return Assert.IsType<CronBookmarkPayload>(bookmark.Payload);
}
}