* Refactor workflow instance deletion to use `IWorkflowRuntime` for enhanced coordination and separation of concerns. * Remove `EnumerableTypeConverter` and update related usages for serialization. - Deleted the `EnumerableTypeConverter` class and its JSON serialization logic. - Removed associated type descriptor attribute in `DefaultFormattersFeature`. - Updated `ObjectFormatter` to handle collection serialization directly with JSON. * Remove `EnumerableTypeConverter` tests and consolidate serialization logic into `ObjectFormatter`. - Deleted `EnumerableTypeConverterTests` as the related functionality was removed. - Added comprehensive tests in `ObjectFormatterTests` to handle serialization of collections and arrays with JSON. * Add integration tests for `TriggerIndexer` to handle workflows with failing materialization - Introduced comprehensive test scenarios verifying `DeleteTriggersAsync` behavior when workflows fail to load or partially succeed. - Enhanced error handling in `TriggerIndexer` to skip failed workflows while ensuring remaining workflows are processed. * Add exception handling in `TriggerIndexer.DeleteTriggersAsync` and integration tests - Enhanced `DeleteTriggersAsync` with exception handling to skip failed workflows while processing others. - Logged warnings for failed workflows without halting execution. - Added comprehensive integration tests to verify behavior across success, failure, and mixed scenarios. - Refactored tests for improved clarity, maintainability, and consistency. * Add exception handling for `ResumeWorkflowTask` to skip deleted workflow instances - Enhanced `ResumeWorkflowTask.ExecuteAsync` to handle `WorkflowInstanceNotFoundException` gracefully when a scheduled workflow instance is missing. - Logged warnings for skipped executions to improve observability. - Ensured remaining workflows and scheduled tasks are processed seamlessly without disruption. * Add thread safety to `LocalScheduler` to prevent race conditions during concurrent scheduling - Introduced a `lock` object to synchronize access to internal dictionaries. - Resolved `IndexOutOfRangeException` caused by concurrent modifications during startup. - Ensured thread-safe operations in `ScheduleAsync`, `ClearScheduleAsync`, and related methods. - Improved reliability and stability of scheduling under concurrent workloads. * Improve exception handling, thread safety, and workflow instance deletion - Added exception handling in `TriggerIndexer.DeleteTriggersAsync` to skip failed workflows while continuing processing. - Enhanced `ResumeWorkflowTask` to handle missing workflow instances gracefully and log warnings. - Introduced thread synchronization in `LocalScheduler` with `lock` to prevent concurrent access issues. - Implemented and refactored tests to ensure behavior consistency and improve maintainability. - Added component tests for workflow deletion scenarios, covering running, completed, and non-existent workflows. * Add component tests for workflow instance deletion and refactor bulk delete logic - Added comprehensive component tests for workflow instance deletion scenarios (running, completed, bulk, and non-existent instances). - Refactored `BulkDelete` API to use `IWorkflowInstanceManager` for proper cleanup of related records (execution logs, activity executions, bookmarks). * Add integration tests and fakes for `TriggerIndexer` to verify behavior with failing and successful workflows - Introduced `FailingMaterializer` and `WorkingMaterializer` for simulating failing and successful workflow materializations. - Added `TriggerDeletionTestScenario`, `TriggerTestDataBuilder`, and related test data classes to define comprehensive test cases. - Updated `DeleteTriggersAsync` tests with scenarios for materialization failures and mixed success. - Improved test coverage and maintainability with reusable test data builders and utilities. * Refactor `ActivityExecutionContextExtensions` to use instance methods for improved readability and encapsulation * Refactor extension methods to use instance methods for improved encapsulation and readability in core workflow modules * Add component tests for event-based workflows and update usages of `Event` activity - Added `BlockingEventWorkflow` and `TriggerEventWorkflow` for testing event-based workflow scenarios. - Added `EventTests` to verify workflow behavior with event publishing and triggering. - Refactored existing integration tests to use `Runtime.Activities.Event` for consistency. * Add unit tests for `EventBase` functionality - Introduced `EventBaseTests` to validate core `EventBase` logic, including bookmark creation, event stimulus handling, and callback invocation. - Added tests for scenarios involving event payloads, trigger indexing, and result output determination. - Verified behavior consistency with various event names and callback executions. * Add tests and workflows to validate event publishing and consumption - Introduced `ConsumerWorkflow`, `PublishGlobalEventWorkflow`, and `PublishAndConsumeEventWorkflow` to test global and local event publishing scenarios. - Added component tests (`PublishEventTests`) to verify event propagation and workflow triggering mechanisms. - Implemented unit tests for `PublishEvent` with various parameters (event name, payload, correlation ID). * Remove unused `using` directives in event-related component tests and workflows * Refactor `PublishEventTests` and `EventBaseTests` to improve test coverage, simplify test logic, and consolidate duplicate code. * Add `NullIfWhiteSpace` extension method and update `PublishEvent` logic to use it in correlation ID handling - Refactored `PublishEventTests` to account for cases where correlation ID is whitespace. - Improved test coverage for `PublishEvent` activity with additional inline test cases. * Refactor `PublishEventTests` to verify payload transmission and enhance `ConsumerWorkflow` to capture and validate event payloads. * Refactor `PublishEventTests` to add timeout mechanism for workflow instance retrieval; enhance `ConsumerWorkflow` to declare output variable for payload validation. * Update test/component/Elsa.Workflows.ComponentTests/Scenarios/Activities/Primitives/Event/PublishEventTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove `EventBaseTests` and `CancelInboundAncestorsAsync` for cleanup and redundant logic removal. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
149 lines
4.9 KiB
C#
149 lines
4.9 KiB
C#
using Elsa.Testing.Shared;
|
|
using Elsa.Workflows;
|
|
using Elsa.Workflows.Runtime;
|
|
using Elsa.Workflows.Runtime.Activities;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using NSubstitute;
|
|
|
|
namespace Elsa.Activities.UnitTests.Primitives;
|
|
|
|
public class PublishEventTests
|
|
{
|
|
[Theory]
|
|
[InlineData("OrderCreated", null, null, false)]
|
|
[InlineData("OrderCreated", "correlation-123", "correlation-123", false)]
|
|
[InlineData("OrderEvent", "", null, true)]
|
|
[InlineData("OrderEvent", " ", null, true)]
|
|
public async Task ExecuteAsync_PublishesEvent_WithParameters(string eventName, string? correlationId, string? expectedCorrelationId, bool expectNullCorrelation)
|
|
{
|
|
// Arrange
|
|
var publisher = Substitute.For<IEventPublisher>();
|
|
|
|
// Act
|
|
await ExecuteAsync(CreateActivity(eventName, correlationId), publisher);
|
|
|
|
// Assert
|
|
await AssertPublishedAsync(
|
|
publisher,
|
|
eventName,
|
|
correlationId: expectedCorrelationId,
|
|
expectNullCorrelationId: expectNullCorrelation);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(true, false)]
|
|
[InlineData(false, true)]
|
|
public async Task ExecuteAsync_LocalEvent_PassesCorrectWorkflowInstanceId(bool isLocalEvent, bool expectNull)
|
|
{
|
|
// Arrange
|
|
const string eventName = "TestEvent";
|
|
var publisher = Substitute.For<IEventPublisher>();
|
|
|
|
// Act
|
|
var context = await ExecuteAsync(CreateActivity(eventName, isLocalEvent: isLocalEvent), publisher);
|
|
|
|
// Assert
|
|
await AssertPublishedAsync(
|
|
publisher,
|
|
eventName,
|
|
workflowInstanceId: expectNull ? null : context.WorkflowExecutionContext.Id,
|
|
expectNullWorkflowInstanceId: expectNull);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ExecuteAsync_PublishesEvent_WithPayload()
|
|
{
|
|
// Arrange
|
|
const string eventName = "OrderCreated";
|
|
var payload = new { OrderId = 123, Amount = 99.99m };
|
|
var publisher = Substitute.For<IEventPublisher>();
|
|
|
|
// Act
|
|
await ExecuteAsync(CreateActivity(eventName, payload: payload), publisher);
|
|
|
|
// Assert
|
|
await AssertPublishedAsync(publisher, eventName, payload: payload);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ExecuteAsync_CompletesActivity()
|
|
{
|
|
// Arrange
|
|
var publisher = Substitute.For<IEventPublisher>();
|
|
|
|
// Act
|
|
var context = await ExecuteAsync(CreateActivity("TestEvent"), publisher);
|
|
|
|
// Assert
|
|
Assert.Equal(ActivityStatus.Completed, context.Status);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ExecuteAsync_WithAllParameters_PassesAllValuesToPublisher()
|
|
{
|
|
// Arrange
|
|
const string eventName = "CompleteOrderEvent";
|
|
const string correlationId = "correlation-456";
|
|
var payload = new { Status = "Shipped" };
|
|
var publisher = Substitute.For<IEventPublisher>();
|
|
|
|
// Act
|
|
var context = await ExecuteAsync(CreateActivity(eventName, correlationId, isLocalEvent: true, payload: payload), publisher);
|
|
|
|
// Assert
|
|
await publisher.Received(1).PublishAsync(
|
|
eventName,
|
|
correlationId,
|
|
context.WorkflowExecutionContext.Id,
|
|
null,
|
|
payload,
|
|
true,
|
|
Arg.Any<CancellationToken>());
|
|
}
|
|
|
|
private static PublishEvent CreateActivity(
|
|
string eventName,
|
|
string? correlationId = null,
|
|
bool? isLocalEvent = null,
|
|
object? payload = null) =>
|
|
new()
|
|
{
|
|
EventName = new(eventName),
|
|
CorrelationId = correlationId != null ? new(correlationId) : null!,
|
|
IsLocalEvent = isLocalEvent.HasValue ? new(isLocalEvent.Value) : null!,
|
|
Payload = payload != null ? new(payload) : null!
|
|
};
|
|
|
|
private static async Task<ActivityExecutionContext> ExecuteAsync(PublishEvent activity, IEventPublisher publisher) =>
|
|
await new ActivityTestFixture(activity)
|
|
.ConfigureServices(services => services.AddSingleton(publisher))
|
|
.ExecuteAsync();
|
|
|
|
private static async Task AssertPublishedAsync(
|
|
IEventPublisher publisher,
|
|
string eventName,
|
|
string? correlationId = null,
|
|
string? workflowInstanceId = null,
|
|
object? payload = null,
|
|
bool expectNullCorrelationId = false,
|
|
bool expectNullWorkflowInstanceId = false)
|
|
{
|
|
var correlationIdArg = expectNullCorrelationId
|
|
? Arg.Is<string?>(x => x == null)
|
|
: correlationId ?? Arg.Any<string?>();
|
|
|
|
var workflowInstanceIdArg = expectNullWorkflowInstanceId
|
|
? Arg.Is<string?>(x => x == null)
|
|
: workflowInstanceId ?? Arg.Any<string?>();
|
|
|
|
await publisher.Received(1).PublishAsync(
|
|
eventName,
|
|
correlationIdArg,
|
|
workflowInstanceIdArg,
|
|
Arg.Any<string?>(),
|
|
payload ?? Arg.Any<object?>(),
|
|
Arg.Any<bool>(),
|
|
Arg.Any<CancellationToken>());
|
|
}
|
|
}
|