* Implement Weaver AI Copilot core * Address Greptile review feedback * Address Greptile persistence feedback * Address Greptile orchestration feedback * Address Greptile tool isolation feedback * Wire chat audit events * Stream chat events over SSE * Use server identity for AI endpoints * Validate AI proposal persistence * Isolate AI audit failures * Enforce AI tool lookup scope * Support AI tool result continuations * Handle AI chat reconnects safely * Tighten AI context and reconnect behavior * Guard AI conversation and persistence setup * Persist AI tool-loop progress * Tighten AI tool registry and reconnect cleanup * Handle AI preparation failures cleanly * Order AI tool messages after assistant turns * Initialize AI provider sessions * Align AI context capabilities * Prevent completed AI reconnect replay * Enforce AI conversation ownership * Default AI proposal creation time * Persist AI session and retention defaults * Allow AI context provider overrides * Scope AI tool results per turn * Apply AI provider configuration * Scope AI proposal reads * Avoid duplicate AI tool continuations * Resolve AI tool registry scopes * Tighten AI reconnect cleanup * Honor default AI proposal tools * Pass AI provider session to turns * Close AI observability gaps * Fix AI capabilities options alias * Harden AI orchestration lifetimes * Track actual AI reconnect conversation * Address AI audit and context review findings * Fix AI reconnect and persistence capabilities * Handle AI session startup failures * Tighten AI orchestration review gaps * Warn on placeholder AI context * Filter disabled AI provider tools * Add durable AI conversation persistence * Fix AI orchestrator persistence lifetime * Handle failed AI reconnect edge cases * Harden AI reconnect failure handling * Address AI reconnect and cleanup review gaps * Tighten AI audit and cleanup persistence * Keep expired AI cleanup best effort * Tighten AI tool lookup and cleanup fallback * Handle AI provider and tenant edge cases * Tighten AI proposal and agent authorization * Address AI tool scope cleanup review * Close remaining AI greptile findings * Harden AI stores and tool defaults * Harden AI conversation persistence edge cases * Cover AI proposal and tool visibility guards * Fix AI capabilities and audit batch resilience * Fix AI conversation truncation for unicode * Resolve remaining AI persistence review nits * Wire AI conversation persistence option * Address AI audit and proposal style review * Fix AI stream truncation surrogate handling * Address AI context and cleanup review * Preserve AI titles and tenant tool defaults * Guard AI conversation user ownership * Align in-memory AI conversation ownership * Fix expired AI conversation cleanup tracking * Harden AI proposal persistence retry * Tighten AI proposal reads and cleanup SQL * Harden AI reconnect and provider defaults * Optimize AI tool listing and message trimming * Preserve AI conversation timestamps * Address final AI persistence review nits * Normalize AI acronym casing * Address Copilot AI review comments * Normalize default tenant handling for AI stores * Harden AI registry and message truncation * Make AI tool filtering explicit * Align AI contracts with implementation * Align remaining AI review contracts * address greptile ai persistence feedback * Address Copilot AI persistence feedback * Address Copilot AI host feedback * Order persisted AI conversation messages * Address Copilot chat and cleanup feedback * Release unused AI reconnect reservations * Address Copilot AI review feedback * Address Copilot tool and conversation feedback * Address Copilot governance feedback * Address Copilot tool test feedback * Address AI review follow-ups * Address Copilot AI follow-ups * Clean up AI persistence tests * Address IAITool disposal review * Address AI integration review follow-ups * Address AI chat persistence review * Address AI registry and truncation review * Enable read-only AI tools by default * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
375 lines
14 KiB
C#
375 lines
14 KiB
C#
using Elsa.AI.Abstractions.Contracts;
|
|
using Elsa.AI.Abstractions.Models;
|
|
using Elsa.AI.Host.Options;
|
|
using Elsa.Extensions;
|
|
using Elsa.AI.Host.Services;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Microsoft.Extensions.Hosting;
|
|
using Microsoft.Extensions.Options;
|
|
using MicrosoftOptions = Microsoft.Extensions.Options.Options;
|
|
|
|
namespace Elsa.AI.Host.UnitTests;
|
|
|
|
public class AIRegistrationTests
|
|
{
|
|
[Fact(DisplayName = "AddAIHostServices registers default host services and options")]
|
|
public void AddAIHostServicesRegistersDefaults()
|
|
{
|
|
var services = new ServiceCollection();
|
|
|
|
services.AddAIHostServices(options => options.ReconnectGrace = TimeSpan.FromSeconds(30));
|
|
|
|
using var provider = services.BuildServiceProvider();
|
|
Assert.NotNull(provider.GetRequiredService<IAIConversationStore>());
|
|
Assert.NotNull(provider.GetRequiredService<AIToolEnablementService>());
|
|
Assert.NotNull(provider.GetRequiredService<IAIAuditSink>());
|
|
Assert.Equal(TimeSpan.FromSeconds(30), provider.GetRequiredService<IOptions<AIHostOptions>>().Value.ReconnectGrace);
|
|
}
|
|
|
|
[Fact(DisplayName = "AI audit sink resolves scoped handlers per record call")]
|
|
public async Task AIAuditSinkResolvesScopedHandlersPerRecordCall()
|
|
{
|
|
var services = new ServiceCollection();
|
|
services.AddAIHostServices();
|
|
services.AddScoped<ScopedAuditHandler>();
|
|
services.AddScoped<IAIAuditEventHandler>(sp => sp.GetRequiredService<ScopedAuditHandler>());
|
|
ScopedAuditHandler.RecordedCount = 0;
|
|
|
|
using var provider = services.BuildServiceProvider(new ServiceProviderOptions { ValidateScopes = true });
|
|
var sink = provider.GetRequiredService<IAIAuditSink>();
|
|
|
|
await sink.RecordAsync(new AIAuditEvent { Type = "chat.started", ActorId = "user-1" });
|
|
|
|
Assert.Equal(1, ScopedAuditHandler.RecordedCount);
|
|
}
|
|
|
|
[Fact(DisplayName = "AI audit sink isolates handler failures")]
|
|
public async Task AIAuditSinkIsolatesHandlerFailures()
|
|
{
|
|
var services = new ServiceCollection();
|
|
services.AddAIHostServices();
|
|
services.AddScoped<IAIAuditEventHandler, ThrowingAuditHandler>();
|
|
services.AddScoped<ScopedAuditHandler>();
|
|
services.AddScoped<IAIAuditEventHandler>(sp => sp.GetRequiredService<ScopedAuditHandler>());
|
|
ScopedAuditHandler.RecordedCount = 0;
|
|
|
|
using var provider = services.BuildServiceProvider(new ServiceProviderOptions { ValidateScopes = true });
|
|
var sink = provider.GetRequiredService<IAIAuditSink>();
|
|
|
|
await sink.RecordAsync(new AIAuditEvent { Type = "chat.started", ActorId = "user-1" });
|
|
|
|
Assert.Equal(1, ScopedAuditHandler.RecordedCount);
|
|
}
|
|
|
|
[Fact(DisplayName = "AI audit sink propagates cancellation")]
|
|
public async Task AIAuditSinkPropagatesCancellation()
|
|
{
|
|
var services = new ServiceCollection();
|
|
services.AddAIHostServices();
|
|
services.AddScoped<IAIAuditEventHandler, CancellingAuditHandler>();
|
|
|
|
using var provider = services.BuildServiceProvider(new ServiceProviderOptions { ValidateScopes = true });
|
|
var sink = provider.GetRequiredService<IAIAuditSink>();
|
|
|
|
await Assert.ThrowsAsync<OperationCanceledException>(async () => await sink.RecordAsync(new AIAuditEvent { Type = "chat.started", ActorId = "user-1" }));
|
|
}
|
|
|
|
|
|
[Fact(DisplayName = "Tool enablement supports concurrent access")]
|
|
public void ToolEnablementSupportsConcurrentAccess()
|
|
{
|
|
var service = new AIToolEnablementService();
|
|
var definition = new AIToolDefinition
|
|
{
|
|
Name = "workflow.propose",
|
|
Mutability = AIToolMutability.Proposal
|
|
};
|
|
|
|
Parallel.For(0, 1000, index =>
|
|
{
|
|
if (index % 2 == 0)
|
|
service.Enable(definition.Name);
|
|
else
|
|
service.Disable(definition.Name);
|
|
|
|
_ = service.IsEnabled(definition);
|
|
});
|
|
|
|
service.Enable(definition.Name);
|
|
Assert.True(service.IsEnabled(definition));
|
|
}
|
|
|
|
[Fact(DisplayName = "Tool enablement requires explicit proposal tool enablement")]
|
|
public void ToolEnablementRequiresExplicitProposalToolEnablement()
|
|
{
|
|
var service = new AIToolEnablementService();
|
|
var definition = new AIToolDefinition
|
|
{
|
|
Name = "workflow.propose",
|
|
Mutability = AIToolMutability.Proposal,
|
|
EnabledByDefault = true
|
|
};
|
|
|
|
Assert.False(service.IsEnabled(definition));
|
|
|
|
service.Enable(definition.Name);
|
|
|
|
Assert.True(service.IsEnabled(definition));
|
|
}
|
|
|
|
[Fact(DisplayName = "Tool enablement enables read-only tools by default")]
|
|
public void ToolEnablementEnablesReadOnlyToolsByDefault()
|
|
{
|
|
var service = new AIToolEnablementService();
|
|
var definition = new AIToolDefinition
|
|
{
|
|
Name = "workflow.inspect",
|
|
Mutability = AIToolMutability.ReadOnly
|
|
};
|
|
|
|
Assert.True(service.IsEnabled(definition));
|
|
}
|
|
|
|
[Fact(DisplayName = "AI host allows context provider overrides on startup")]
|
|
public async Task AIHostAllowsContextProviderOverridesOnStartup()
|
|
{
|
|
var services = new ServiceCollection();
|
|
services.AddAIHostServices();
|
|
services.AddSingleton<IAIContextProvider>(new DuplicateContextProvider("WorkflowDefinition"));
|
|
|
|
using var provider = services.BuildServiceProvider();
|
|
var validator = provider.GetServices<IHostedService>().OfType<AIContextProviderValidationHostedService>().Single();
|
|
|
|
await validator.StartAsync(CancellationToken.None);
|
|
}
|
|
|
|
[Fact(DisplayName = "AI host validates scoped context providers from a startup scope")]
|
|
public async Task AIHostValidatesScopedContextProvidersFromStartupScope()
|
|
{
|
|
var services = new ServiceCollection();
|
|
services.AddAIHostServices();
|
|
services.AddScoped<ScopedContextProviderDependency>();
|
|
services.AddScoped<IAIContextProvider, ScopedContextProvider>();
|
|
|
|
using var provider = services.BuildServiceProvider(new ServiceProviderOptions { ValidateScopes = true });
|
|
var validator = provider.GetServices<IHostedService>().OfType<AIContextProviderValidationHostedService>().Single();
|
|
|
|
await validator.StartAsync(CancellationToken.None);
|
|
}
|
|
|
|
[Fact(DisplayName = "In-memory conversation store evicts expired conversations")]
|
|
public async Task InMemoryConversationStoreEvictsExpiredConversations()
|
|
{
|
|
var store = new InMemoryAIConversationStore();
|
|
|
|
await store.SaveAsync(new AIConversation
|
|
{
|
|
Id = "conversation-1",
|
|
UserId = "user-1",
|
|
CreatedAt = DateTimeOffset.UtcNow.AddMinutes(-10),
|
|
UpdatedAt = DateTimeOffset.UtcNow.AddMinutes(-10),
|
|
RetentionExpiresAt = DateTimeOffset.UtcNow.AddMinutes(-5)
|
|
});
|
|
|
|
var result = await store.FindAsync("conversation-1");
|
|
|
|
Assert.Null(result);
|
|
}
|
|
|
|
[Fact(DisplayName = "In-memory conversation store retains ephemeral conversations in process")]
|
|
public async Task InMemoryConversationStoreRetainsEphemeralConversationsInProcess()
|
|
{
|
|
var store = new InMemoryAIConversationStore();
|
|
|
|
await store.SaveAsync(new AIConversation
|
|
{
|
|
Id = "conversation-1",
|
|
UserId = "user-1",
|
|
RetentionMode = AIRetentionMode.Ephemeral,
|
|
CreatedAt = DateTimeOffset.UtcNow,
|
|
UpdatedAt = DateTimeOffset.UtcNow
|
|
});
|
|
|
|
var result = await store.FindAsync("conversation-1");
|
|
|
|
Assert.NotNull(result);
|
|
}
|
|
|
|
[Fact(DisplayName = "In-memory conversation store prunes completed ephemeral conversations")]
|
|
public async Task InMemoryConversationStorePrunesCompletedEphemeralConversations()
|
|
{
|
|
var store = new InMemoryAIConversationStore();
|
|
|
|
await store.SaveAsync(new AIConversation
|
|
{
|
|
Id = "conversation-1",
|
|
UserId = "user-1",
|
|
Status = AIConversationStatus.Completed,
|
|
RetentionMode = AIRetentionMode.Ephemeral,
|
|
CreatedAt = DateTimeOffset.UtcNow,
|
|
UpdatedAt = DateTimeOffset.UtcNow
|
|
});
|
|
|
|
var result = await store.FindAsync("conversation-1");
|
|
|
|
Assert.Null(result);
|
|
}
|
|
|
|
[Fact(DisplayName = "In-memory conversation store rejects cross-tenant overwrites")]
|
|
public async Task InMemoryConversationStoreRejectsCrossTenantOverwrites()
|
|
{
|
|
var store = new InMemoryAIConversationStore();
|
|
await store.SaveAsync(new AIConversation
|
|
{
|
|
Id = "conversation-1",
|
|
TenantId = "tenant-1",
|
|
UserId = "user-1",
|
|
CreatedAt = DateTimeOffset.UtcNow,
|
|
UpdatedAt = DateTimeOffset.UtcNow
|
|
});
|
|
|
|
var exception = await Assert.ThrowsAsync<InvalidOperationException>(async () => await store.SaveAsync(new AIConversation
|
|
{
|
|
Id = "conversation-1",
|
|
TenantId = "tenant-2",
|
|
UserId = "user-1",
|
|
CreatedAt = DateTimeOffset.UtcNow,
|
|
UpdatedAt = DateTimeOffset.UtcNow
|
|
}));
|
|
|
|
Assert.Equal("Cannot overwrite an AI conversation that belongs to another tenant.", exception.Message);
|
|
}
|
|
|
|
[Fact(DisplayName = "In-memory conversation store treats null and empty tenant IDs as default tenant")]
|
|
public async Task InMemoryConversationStoreTreatsNullAndEmptyTenantIdsAsDefaultTenant()
|
|
{
|
|
var store = new InMemoryAIConversationStore();
|
|
await store.SaveAsync(new AIConversation
|
|
{
|
|
Id = "conversation-1",
|
|
TenantId = null,
|
|
UserId = "user-1",
|
|
CreatedAt = DateTimeOffset.UtcNow,
|
|
UpdatedAt = DateTimeOffset.UtcNow
|
|
});
|
|
|
|
await store.SaveAsync(new AIConversation
|
|
{
|
|
Id = "conversation-1",
|
|
TenantId = "",
|
|
UserId = "user-1",
|
|
CreatedAt = DateTimeOffset.UtcNow,
|
|
UpdatedAt = DateTimeOffset.UtcNow
|
|
});
|
|
|
|
var conversation = await store.FindAsync("conversation-1");
|
|
|
|
Assert.NotNull(conversation);
|
|
Assert.Equal("", conversation.TenantId);
|
|
}
|
|
|
|
[Fact(DisplayName = "In-memory conversation store treats conversation IDs case-insensitively")]
|
|
public async Task InMemoryConversationStoreTreatsConversationIdsCaseInsensitively()
|
|
{
|
|
var store = new InMemoryAIConversationStore();
|
|
await store.SaveAsync(new AIConversation
|
|
{
|
|
Id = "Conversation-1",
|
|
UserId = "user-1",
|
|
CreatedAt = DateTimeOffset.UtcNow,
|
|
UpdatedAt = DateTimeOffset.UtcNow
|
|
});
|
|
|
|
var conversation = await store.FindAsync("conversation-1");
|
|
|
|
Assert.NotNull(conversation);
|
|
Assert.Equal("Conversation-1", conversation.Id);
|
|
}
|
|
|
|
[Fact(DisplayName = "In-memory conversation store rejects cross-user overwrites")]
|
|
public async Task InMemoryConversationStoreRejectsCrossUserOverwrites()
|
|
{
|
|
var store = new InMemoryAIConversationStore();
|
|
await store.SaveAsync(new AIConversation
|
|
{
|
|
Id = "conversation-1",
|
|
TenantId = "tenant-1",
|
|
UserId = "user-1",
|
|
CreatedAt = DateTimeOffset.UtcNow,
|
|
UpdatedAt = DateTimeOffset.UtcNow
|
|
});
|
|
|
|
var exception = await Assert.ThrowsAsync<InvalidOperationException>(async () => await store.SaveAsync(new AIConversation
|
|
{
|
|
Id = "conversation-1",
|
|
TenantId = "tenant-1",
|
|
UserId = "user-2",
|
|
CreatedAt = DateTimeOffset.UtcNow,
|
|
UpdatedAt = DateTimeOffset.UtcNow
|
|
}));
|
|
|
|
Assert.Equal("Cannot overwrite an AI conversation that belongs to another user.", exception.Message);
|
|
}
|
|
|
|
[Fact(DisplayName = "In-memory conversation store validates required conversation fields")]
|
|
public async Task InMemoryConversationStoreValidatesRequiredConversationFields()
|
|
{
|
|
var store = new InMemoryAIConversationStore();
|
|
var conversation = new AIConversation
|
|
{
|
|
Id = "conversation-invalid"
|
|
};
|
|
|
|
var exception = await Assert.ThrowsAsync<ArgumentException>(async () => await store.SaveAsync(conversation));
|
|
|
|
Assert.Equal("conversation", exception.ParamName);
|
|
Assert.Equal("A conversation user ID is required. (Parameter 'conversation')", exception.Message);
|
|
}
|
|
|
|
private class ScopedAuditHandler : IAIAuditEventHandler
|
|
{
|
|
public static int RecordedCount { get; set; }
|
|
|
|
public ValueTask RecordAsync(AIAuditEvent auditEvent, CancellationToken cancellationToken = default)
|
|
{
|
|
RecordedCount++;
|
|
return ValueTask.CompletedTask;
|
|
}
|
|
}
|
|
|
|
private class ThrowingAuditHandler : IAIAuditEventHandler
|
|
{
|
|
public ValueTask RecordAsync(AIAuditEvent auditEvent, CancellationToken cancellationToken = default) =>
|
|
throw new InvalidOperationException("Audit sink unavailable.");
|
|
}
|
|
|
|
private class CancellingAuditHandler : IAIAuditEventHandler
|
|
{
|
|
public ValueTask RecordAsync(AIAuditEvent auditEvent, CancellationToken cancellationToken = default) =>
|
|
throw new OperationCanceledException();
|
|
}
|
|
|
|
private class DuplicateContextProvider(string kind) : IAIContextProvider
|
|
{
|
|
public string Kind { get; } = kind;
|
|
|
|
public ValueTask<AIResolvedContext> ResolveAsync(AIContextResolutionRequest request, CancellationToken cancellationToken = default) =>
|
|
ValueTask.FromResult(new AIResolvedContext { Kind = Kind });
|
|
}
|
|
|
|
private class ScopedContextProviderDependency
|
|
{
|
|
}
|
|
|
|
private class ScopedContextProvider(ScopedContextProviderDependency dependency) : IAIContextProvider
|
|
{
|
|
public string Kind => "WorkflowDefinition";
|
|
|
|
public ValueTask<AIResolvedContext> ResolveAsync(AIContextResolutionRequest request, CancellationToken cancellationToken = default)
|
|
{
|
|
_ = dependency;
|
|
return ValueTask.FromResult(new AIResolvedContext { Kind = Kind });
|
|
}
|
|
}
|
|
}
|