f969cd61e8
* refactor(auth)!: retire the legacy permission constants and duplicate descriptors Completes the cutover started in #7980. Seven `<Module>Permissions` classes holding `verb:resource` strings are removed: AIPermissions, ConsoleLogs, Dashboard, ExternalAuthentication, OpenTelemetry, Secrets and StructuredLogs. AIPermissions was not in #7982's list, which was written before the cutover finished; it is dead by the same measure as the rest. Removed rather than marked obsolete, which #7982 asked to be an explicit decision. Every string these classes held carries two colons, so it does not parse under the new grammar and authorizes nothing. Keeping them obsolete would leave code that compiles, still reads as a permission check, and silently grants no access -- a warning that is easy to suppress in front of a runtime failure that is invisible. A compile error names the call site and can be fixed against the migration guide's mapping table. Classes their own modules still reference, WorkflowPermissions and IdentityPermissions among them, are untouched. External Authentication's parallel descriptor system is collapsed onto the core types: its own PermissionDescriptor record, its IPermissionDescriptorProvider and IPermissionDescriptorRegistry, and DefaultPermissionDescriptorRegistry. That was not only tidiness. The module's registry was fed exclusively by its legacy names, so after the cutover every well-formed grant failed the `unknown_permission_descriptor` check and the warning fired constantly for correct configuration. The resolver now consults the core catalog, which is keyed by resource and lists the verbs each accepts, and a wildcard is treated as advertised because it names a pattern rather than a resource to look up. The descriptor endpoint serves the core catalog too: choosing what an external mapping may confer means choosing from everything Elsa declares. The module contributes its resource descriptors explicitly rather than relying on the host's assembly scan, for the same reason it registers AddElsaAuthorization itself. The two naming tests now pin the new resource name instead of the legacy string. The convention worth holding was always that the module is called 'diagnostics/console-logs', not that a retired constant kept its old value. Refs #7982 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(client): match the permission descriptor client model to the catalog Moving the descriptor endpoint onto the core catalog changed its shape from a single permission string to a resource plus the verbs that resource accepts, and the Refit client model kept the old one. It still deserialized and still compiled, handing callers a blank Name and no way to reach the verbs -- the data went missing without anything failing. The client model now mirrors the served descriptor, and a contract test compares the two property sets so the next divergence is a test failure rather than an empty field. NonCoreVerbs is excluded: the server derives it from SupportedVerbs, so a client holding the verbs can compute it. Found by review, not by the suites: nothing here throws. Refs #7982 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
35 lines
1.9 KiB
C#
35 lines
1.9 KiB
C#
using Elsa.Api.Client.Resources.ExternalAuthentication.Descriptors.Models;
|
|
using Elsa.Permissions;
|
|
|
|
namespace Elsa.ExternalAuthentication.IntegrationTests.Compatibility;
|
|
|
|
/// <summary>
|
|
/// Pins the permission descriptor the API serves to the one its client deserializes.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// The endpoint used to serve a descriptor private to the External Authentication module, keyed by a single
|
|
/// permission string. Moving it onto the core catalog changed the shape to a resource plus the verbs that
|
|
/// resource accepts, and the client model kept the old one — so it still deserialized, still compiled, and
|
|
/// handed callers blank identifiers with no way to reach the verbs. Nothing failed; the data just went
|
|
/// missing. Comparing the two property sets is what turns that back into a test failure.
|
|
/// </remarks>
|
|
public class PermissionDescriptorContractTests
|
|
{
|
|
[Fact]
|
|
public void ClientModelCarriesEveryFieldTheCatalogServes()
|
|
{
|
|
var served = typeof(PermissionDescriptor).GetProperties().Select(x => x.Name).ToHashSet(StringComparer.Ordinal);
|
|
var deserialized = typeof(ExternalAuthenticationPermissionDescriptor).GetProperties().Select(x => x.Name).ToHashSet(StringComparer.Ordinal);
|
|
|
|
// NonCoreVerbs is derived from SupportedVerbs on the server, so a client that has the verbs can
|
|
// compute it and does not need it sent.
|
|
served.Remove(nameof(PermissionDescriptor.NonCoreVerbs));
|
|
|
|
var missing = served.Except(deserialized).OrderBy(x => x, StringComparer.Ordinal).ToArray();
|
|
var unknown = deserialized.Except(served).OrderBy(x => x, StringComparer.Ordinal).ToArray();
|
|
|
|
Assert.True(missing.Length == 0, $"The client model would silently drop: {string.Join(", ", missing)}.");
|
|
Assert.True(unknown.Length == 0, $"The client model expects fields the catalog does not serve, which will deserialize empty: {string.Join(", ", unknown)}.");
|
|
}
|
|
}
|