Commit graph

6663 commits

Author SHA1 Message Date
lukhipolito-nexxbiz f6caad19fb
Update doc/qa/test-guidelines.md
Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
2025-10-13 16:11:10 +02:00
lucas.hipolito d0aafe6d4e Removing out of scope tests 2025-10-13 15:02:38 +02:00
lucas.hipolito 09b66430a2 Unit test coverage for SendHttpRequest + useful extensions 2025-10-10 15:33:55 +02:00
lucas.hipolito fe80505f21 Unit testing coverage for WriteLine activity 2025-10-10 10:30:24 +02:00
Sipke Schoorstra a74502d3ad
Fix trigger indexing logic and add tests for trigger persistence after workflow reload. (#6958)
* Fix outbound connection processing logic

Corrected `completedActivityExcecutedByBackwardConnection` to `completedActivityExecutedByBackwardConnection`. Improved flowgraph outbound connection handling by separating visitation and processing logic, ensuring skipped connections are propagated consistently.

* Add tests for decision implicit join workflows

Introduce new integration tests to verify workflows with implicit joins on both decision outcomes. Added corresponding workflow definitions and updated the test project to ensure compatibility. Refactored connection visit logic for better readability and maintainability.

* Refactor trigger indexing logic and add tests for trigger persistence after workflow reload.

Streamlined conditional trigger indexing in `DefaultWorkflowDefinitionStorePopulator`. Introduced a test to validate trigger persistence across reloads after publishing a new workflow version.
2025-10-10 09:21:11 +02:00
Sipke Schoorstra dc429700ab
Fixes deadlock issue with implicit joins (#6955)
* Fix outbound connection processing logic

Corrected `completedActivityExcecutedByBackwardConnection` to `completedActivityExecutedByBackwardConnection`. Improved flowgraph outbound connection handling by separating visitation and processing logic, ensuring skipped connections are propagated consistently.

* Add tests for decision implicit join workflows

Introduce new integration tests to verify workflows with implicit joins on both decision outcomes. Added corresponding workflow definitions and updated the test project to ensure compatibility. Refactored connection visit logic for better readability and maintainability.
2025-10-09 21:33:23 +02:00
lucas.hipolito f1e69a1536 Small wording improvement 2025-10-09 16:55:12 +02:00
lukhipolito-nexxbiz e9ae53c4c6
Update doc/qa/test-guidelines.md
Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
2025-10-09 14:49:49 +02:00
lukhipolito-nexxbiz c9be7f0d13
Update doc/qa/test-guidelines.md
Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
2025-10-09 14:49:00 +02:00
lucas.hipolito 8ec29358b5 Equalizing with 3.6.0 2025-10-09 14:45:33 +02:00
lucas.hipolito 9ab15d3d15 Reverting wrong commits 2025-10-09 14:36:56 +02:00
lucas.hipolito e22ecf83a0 Merge branch 'develop/3.6.0' into feat/test-guidelines 2025-10-09 14:02:08 +02:00
lukhipolito-nexxbiz 695a33cb02
Merge pull request #6951 from elsa-workflows/feature/unit-test-suite
Feature/unit test suite
2025-10-09 13:34:29 +02:00
Sipke Schoorstra 5b014c7566
Apply suggestion from @Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-09 13:31:06 +02:00
lucas.hipolito 19b5ab94dd Workaround for using correct overoad - build fix 2025-10-09 09:59:04 +02:00
lucas.hipolito f407463238 Merge remote-tracking branch 'origin/feature/unit-test-suite' into feature/unit-test-suite 2025-10-09 09:41:31 +02:00
lucas.hipolito 9ea3f49e0f Small improvement for generic Variable type evaluation 2025-10-09 09:41:27 +02:00
lukhipolito-nexxbiz c7df5619e5
Update test/unit/Elsa.Activities.UnitTests/Primitives/SetVariableTests.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-09 09:40:36 +02:00
lukhipolito-nexxbiz c02484fd4d
Update src/modules/Elsa.Workflows.Core/Activities/SetVariable.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-09 09:40:01 +02:00
lukhipolito-nexxbiz abfaad85cb
Update test/unit/Elsa.Activities.UnitTests/Helpers/ActivityTestHelper.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-09 09:39:07 +02:00
lucas.hipolito c773d83733 Merge branch 'develop/3.6.0' into feature/unit-test-suite 2025-10-09 08:48:04 +02:00
lukhipolito-nexxbiz 2cbfa279c7
Merge pull request #6952 from elsa-workflows/feature/unit-test-suite-suggestions
PR suggestions from Sipke
2025-10-09 08:44:16 +02:00
Sipke Schoorstra 58cede9ca1
Merge remote-tracking branch 'origin/patch/3.5.2' into patch/3.5.2 2025-10-08 21:15:48 +02:00
Sipke Schoorstra 2abb937fc1
Add integration test for implicit join behavior with merge mode set to None 2025-10-08 21:10:35 +02:00
Sipke Schoorstra b5cc5f7ca5
Update coverlet.msbuild version to 6.0.4 in Directory.Packages.props 2025-10-08 20:36:06 +02:00
Sipke Schoorstra b3c1defd3d
Fix incorrect test method name to reflect expected throwing behavior when variable is null in SetVariableTests. 2025-10-08 20:27:18 +02:00
Sipke Schoorstra 8eb2b11f6e
Refactor SetVariable activity: add null safety checks, update variable property to nullable type, and enhance unit tests for edge cases. 2025-10-08 20:23:25 +02:00
lucas.hipolito e6df8ea954 More unit tests for set variable 2025-10-08 14:59:59 +02:00
lucas.hipolito 5bd037928c Helper for isolated activity testing + few SetVariable tests 2025-10-08 14:38:19 +02:00
lucas.hipolito 2fde7ef048 Merge branch 'develop/3.6.0' into feature/unit-test-suite 2025-10-08 09:07:53 +02:00
Sipke Schoorstra bbbf13c58c
Allow tests to run on all events
Remove condition to run tests only on pull requests.
2025-10-07 20:10:38 +02:00
Sipke Schoorstra fe4d74189a
Add coverage enforcement for test projects (#6950)
* Add coverage enforcement for test projects

* Expand GitHub Actions triggers to include additional branch patterns

* Update `coverlet.msbuild` configuration and centralize dependency version management

- Removed inline version specification for `coverlet.msbuild` in `test/Directory.Build.props`.
- Centralized `coverlet.msbuild` version definition in `Directory.Packages.props` for consistency and maintainability.

* Remove `Elsa.Common.Core` unit test project and related test files

* Add Directory.Build.props for test project organization and update property configurations

- Introduced `Directory.Build.props` files for `test/unit` and `test/integration` to define project-specific properties.
- Updated `test/Directory.Build.props` to include new coverage formats and an exclusion for `Elsa.Testing.Shared`.
- Adjusted solution file to link new `Directory.Build.props` files.
- Configured threshold properties for `unit`, `integration`, and `component` test directories.

* Disable coverage collection for performance tests in project file

* Expand GitHub Actions workflow triggers and add PR-specific condition for test job
2025-10-07 19:59:53 +02:00
lucas.hipolito 4a26819ed7 (WIP) Initial context helper + provisional unit tests for setvariable 2025-10-07 15:56:08 +02:00
lucas.hipolito 9ac605fbb5 Renaming guideline file 2025-10-07 09:03:16 +02:00
lucas.hipolito 3d9cefa894 Better and revised general testing guidelines 2025-10-06 17:54:11 +02:00
Sipke Schoorstra 42753359d2 Adjust recurring task schedules and bookmark queue TTL for optimized performance. 2025-10-06 15:39:16 +02:00
lucas.hipolito 4d17f869a3 Merge branch 'develop/3.6.0' into feat/test-guidelines 2025-10-06 13:45:41 +02:00
Sipke Schoorstra fcdb6f5499 Refactor WorkflowDefinitionManager: streamline constructor, remove unused field, and improve consistency in method calls. 2025-10-06 10:33:09 +02:00
Sipke Schoorstra 95b17135a9
Add support for reverting workflow definitions to a specific version and refactor WorkflowDefinitionFilter initialization for consistency 2025-10-05 15:08:42 +02:00
Sipke Schoorstra b52a07f46a
Refactor FlowchartNextActivity tests: reduce unused cases, update switch behaviors, and improve consistency. 2025-10-05 10:51:29 +02:00
Sipke Schoorstra d1051f3194
Remove unused connection definition in FlowchartNextActivity integration test. 2025-10-05 10:41:51 +02:00
Sipke Schoorstra 6847ce5f55
Merge remote-tracking branch 'origin/develop/3.6.0' into develop/3.6.0 2025-10-04 19:34:31 +02:00
Sipke Schoorstra 1ef057068d
Fix typo in AddTriggerPaylodValidator method name across Scheduling, Http, and Runtime modules 2025-10-04 19:34:19 +02:00
Matt 5daff43cac Resolve FlowChart merge errors. 2025-10-03 23:40:23 +01:00
Matt 60d01f8892 Merge remote-tracking branch 'origin/patch/3.5.2' into develop/3.6.0 2025-10-03 22:17:01 +01:00
Sipke Schoorstra c586c690d3
Refactor scheduling feature: remove unused CronParser, improve error handling in ScheduledRecurringTask. 2025-10-03 20:46:29 +02:00
Sipke Schoorstra a375e5613a
Update bookmark payloads to public records for broader accessibility 2025-10-03 20:03:28 +02:00
Matt 32d6f903c5
Resolves Workflow Execution Bodiless Requests Issue. (#6944)
* Resolves workflow execution bodiless requests issue.

Removed content length check when processing JSON requests, relying solely on content type validation. Added a null-check for deserialized requests to handle cases where the request body is missing or invalid, providing a specific error message.

* Refactor JSON request handling in PostEndpoint

Updated to get unit tests to pass.
2025-10-03 19:44:38 +02:00
lukhipolito-nexxbiz 071d8eb2a8
Update doc/qa/test-guidelines-collaborators.md
Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
2025-10-03 12:45:25 +02:00
lukhipolito-nexxbiz 50ce9054a0
Update doc/qa/test-guidelines-collaborators.md
Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
2025-10-03 12:45:07 +02:00