Commit graph

7 commits

Author SHA1 Message Date
Sipke Schoorstra f6d2d38536
test(user-tasks): add a persistence conformance suite with fault injection (#7986)
Runs one suite unchanged against every implementation of IUserTaskRepository,
IUserTaskGuestSessionIssuer, and IUserTaskInvitationOutbox, plus a fault-injection
suite driving the real DefaultUserTaskManager and DefaultUserTaskInvitationService
against a real store. Gated providers report as skipped with a reason rather than
passing vacuously; ConformanceCoverageTests fails when a provider that must run is
unreachable or its variable is set but empty.

The suite found three defects, fixed here:

- VNextUserTaskRepository supplied no index values for WorkflowDefinitionId,
  WorkflowInstanceId, ActivityInstanceId, CreatedAt, or CompletedAt, all declared by
  its own schema provider, so every write through the VNext provider threw.
- The same provider resolved invitation token hashes by scanning on Status alone,
  which matched no declared index, so anonymous invitation verification always threw.
- EFCoreUserTaskInvitationOutbox persisted the delivery recipient but never read it
  back, so durably queued invitations reached the dispatcher with no address.

Also switches new ADRs to date-prefixed identifiers and generates doc/adr/toc.md via
scripts/adr/generate-toc.sh, with a --check mode and pull-request workflow so the
index is never hand-edited again.
2026-08-25 04:36:18 +02:00
Sipke Schoorstra 6e870d9861
Enhance CONTRIBUTING.md with feature request guidelines
Added a section on feature requests and prioritization criteria to guide contributors.
2026-04-14 11:37:12 +02:00
Sipke Schoorstra df8fe2b33b
Enhance contributing guidelines for clarity and process
Expanded contributing guidelines to emphasize clarity, discipline, and maintainability. Added sections on pull requests, bug reporting, and development workflow.
2026-02-18 18:51:42 +01:00
Sipke Schoorstra 0785fa6e42
Create CONTRIBUTING.md 2024-01-03 16:22:03 +01:00
Sipke Schoorstra 42ce946d64 Reset 2022-01-04 09:38:11 +01:00
Rafael Carnucci 720ad7fe6c
edit contributing.md (#549)
Co-authored-by: Rafael Carnucci <rafael.carnucci@icn.de>
2021-01-04 10:49:58 +01:00
Sipke Schoorstra 0a5a88d546 Add CONTRIBUTING.md 2020-03-28 22:55:09 +01:00