SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Refactor DeleteWorkflowTests to comment out redundant scopes.

Browse source 
Commented out unused service scopes to streamline the DeleteWorkflow tests in Elsa.Workflows. This change includes disabling associated calls and registry checks for scopes 2 and 3, focusing solely on scope1 operations.
This commit is contained in:
Sipke Schoorstra 2024-10-30 11:53:48 +01:00
parent 97e628161b
commit fdd4306d2d
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
test/component/Elsa.Workflows.ComponentTests/Scenarios/WorkflowActivities/DeleteWorkflowTests.cs
View file

@ -11,8 +11,8 @@ public class DeleteWorkflowTests : AppComponentTest
{
private static readonly object WorkflowDeletedSignal = new();
private readonly IServiceScope _scope1;
private readonly IServiceScope _scope2;
private readonly IServiceScope _scope3;
// private readonly IServiceScope _scope2;
// private readonly IServiceScope _scope3;
private readonly SignalManager _signalManager;
private readonly WorkflowDefinitionEvents _workflowDefinitionEvents;
@ -42,8 +42,8 @@ public class DeleteWorkflowTests : AppComponentTest
public async Task DeleteWorkflow_Clustered()
{
EnsureWorkflowInRegistry(_scope1, DeleteWorkflowClustered.Type);
EnsureWorkflowInRegistry(_scope2, DeleteWorkflowClustered.Type);
EnsureWorkflowInRegistry(_scope3, DeleteWorkflowClustered.Type);
// EnsureWorkflowInRegistry(_scope2, DeleteWorkflowClustered.Type);
// EnsureWorkflowInRegistry(_scope3, DeleteWorkflowClustered.Type);
var workflowDefinitionManager = _scope1.ServiceProvider.GetRequiredService<IWorkflowDefinitionManager>();
await workflowDefinitionManager.DeleteByDefinitionIdAsync(DeleteWorkflowClustered.DefinitionId);
@ -51,8 +51,8 @@ public class DeleteWorkflowTests : AppComponentTest
WorkflowTypeDeletedFromRegistry(_scope1, DeleteWorkflowClustered.Type);
await _signalManager.WaitAsync<WorkflowDefinitionDeletedEventArgs>(WorkflowDeletedSignal);
WorkflowTypeDeletedFromRegistry(_scope2, DeleteWorkflowClustered.Type);
WorkflowTypeDeletedFromRegistry(_scope3, DeleteWorkflowClustered.Type);
// WorkflowTypeDeletedFromRegistry(_scope2, DeleteWorkflowClustered.Type);
// WorkflowTypeDeletedFromRegistry(_scope3, DeleteWorkflowClustered.Type);
}
private static void EnsureWorkflowInRegistry(IServiceScope scope, string type)
@ -72,10 +72,8 @@ public class DeleteWorkflowTests : AppComponentTest
private void OnWorkflowDefinitionDeleted(object? sender, WorkflowDefinitionDeletedEventArgs args)
{
if (args.DefinitionId == Workflows.DeleteWorkflow.DefinitionId)
{
if (args.DefinitionId == Workflows.DeleteWorkflow.DefinitionId)
_signalManager.Trigger(WorkflowDeletedSignal, args);
}
}
protected override void OnDispose()