Merge remote-tracking branch 'origin/patch/3.2.x'

This commit is contained in:
Sipke Schoorstra 2024-10-25 20:19:01 +02:00
commit fd92557469
6 changed files with 167 additions and 21 deletions

View file

@ -177,11 +177,12 @@
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="8.0.1" />
<PackageVersion Include="Microsoft.Extensions.Options" Version="8.0.2" />
<PackageVersion Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="8.0.0" />
<PackageVersion Include="Npgsql" Version="8.0.4" />
<PackageVersion Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="8.0.8" />
<PackageVersion Include="Oracle.EntityFrameworkCore" Version="8.23.60" />
<PackageVersion Include="Npgsql" Version="8.0.5" />
<PackageVersion Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="8.0.10" />
<PackageVersion Include="Polly" Version="8.4.2" />
<PackageVersion Include="Pomelo.EntityFrameworkCore.MySql" Version="8.0.2" />
<PackageVersion Include="Microsoft.Extensions.DependencyModel" Version="8.0.2" />
<PackageVersion Include="System.Text.Json" Version="$(SystemTextJsonVersion)" />
</ItemGroup>
</Project>

View file

@ -19,16 +19,16 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Nuke.Components" Version="8.1.0" />
<PackageReference Include="Nuke.Components" Version="8.1.2" />
</ItemGroup>
<!--Overridden for vulnerability reasons with dependencies referencing older versions.-->
<ItemGroup>
<PackageReference Include="Azure.Identity" Version="1.12.0" />
<PackageReference Include="Microsoft.Identity.Client" Version="4.61.3" />
<PackageReference Include="NuGet.Packaging" Version="6.10.1" />
<PackageReference Include="System.Formats.Asn1" Version="8.0.1" />
<PackageReference Include="System.Text.Json" Version="8.0.5" />
<PackageReference Include="Microsoft.Identity.Client" VersionOverride="4.65.0" />
</ItemGroup>
</Project>

View file

@ -1,4 +1,5 @@
using System.Text.Json;
using System.Text.Json.Nodes;
using Elsa.Features.Abstractions;
using Elsa.Features.Services;
using Elsa.KeyValues.Entities;
@ -8,6 +9,7 @@ using Elsa.MongoDb.Options;
using Elsa.MongoDb.Serializers;
using Elsa.Workflows.Memory;
using Elsa.Workflows.Runtime.Entities;
using Elsa.Workflows.Services;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.DependencyInjection.Extensions;
using Microsoft.Extensions.Options;
@ -67,6 +69,7 @@ public class MongoDbFeature : FeatureBase
TryRegisterSerializerOrSkipWhenExist(typeof(Variable), new VariableSerializer());
TryRegisterSerializerOrSkipWhenExist(typeof(Version), new VersionSerializer());
TryRegisterSerializerOrSkipWhenExist(typeof(JsonElement), new JsonElementSerializer());
TryRegisterSerializerOrSkipWhenExist(typeof(JsonNode), new JsonNodeBsonConverter());
}
private static void RegisterClassMaps()

View file

@ -0,0 +1,135 @@
using System.Text.Json.Nodes;
using MongoDB.Bson;
using MongoDB.Bson.IO;
using MongoDB.Bson.Serialization;
namespace Elsa.MongoDb.Serializers;
/// <summary>
/// Serializes a <see cref="JsonNode"/>.
/// </summary>
public class JsonNodeBsonConverter : IBsonSerializer<JsonNode>
{
/// <inheritdoc />
public Type ValueType => typeof(JsonNode);
/// <inheritdoc />
public void Serialize(BsonSerializationContext context, BsonSerializationArgs args, JsonNode value)
{
if (value == null!)
{
context.Writer.WriteNull();
return;
}
context.Writer.WriteStartDocument();
context.Writer.WriteName("type");
switch (value)
{
case JsonObject jsonObject:
context.Writer.WriteString("JsonObject");
context.Writer.WriteName("value");
context.Writer.WriteString(jsonObject.ToJsonString());
break;
case JsonArray jsonArray:
context.Writer.WriteString("JsonArray");
context.Writer.WriteName("value");
context.Writer.WriteString(jsonArray.ToJsonString());
break;
case JsonValue jsonValue:
context.Writer.WriteString("JsonValue");
context.Writer.WriteName("value");
if (jsonValue.TryGetValue(out string? stringValue))
context.Writer.WriteString(stringValue);
else if (jsonValue.TryGetValue(out int intValue))
context.Writer.WriteInt32(intValue);
else if (jsonValue.TryGetValue(out int longValue))
context.Writer.WriteInt64(longValue);
else if (jsonValue.TryGetValue(out double doubleValue))
context.Writer.WriteDouble(doubleValue);
else if (jsonValue.TryGetValue(out bool boolValue))
context.Writer.WriteBoolean(boolValue);
else if (jsonValue.TryGetValue(out DateTimeOffset dateTimeOffsetValue))
context.Writer.WriteDateTime(dateTimeOffsetValue.ToUnixTimeMilliseconds());
else if (jsonValue.TryGetValue(out DateTime dateTimeValue))
context.Writer.WriteDateTime(new DateTimeOffset(dateTimeValue).ToUnixTimeMilliseconds());
else
throw new BsonSerializationException("Unsupported JsonValue type");
break;
default:
throw new BsonSerializationException($"Unexpected JsonNode type: {value.GetType()}");
}
context.Writer.WriteEndDocument();
}
public JsonNode Deserialize(BsonDeserializationContext context, BsonDeserializationArgs args)
{
context.Reader.ReadStartDocument();
var type = context.Reader.ReadString();
context.Reader.ReadName(Utf8NameDecoder.Instance);
JsonNode result;
switch (type)
{
case "JsonObject":
var jsonObjectString = context.Reader.ReadString();
result = JsonNode.Parse(jsonObjectString);
break;
case "JsonArray":
var jsonArrayString = context.Reader.ReadString();
result = JsonNode.Parse(jsonArrayString);
break;
case "JsonValue":
var bsonType = context.Reader.GetCurrentBsonType();
switch (bsonType)
{
case BsonType.String:
result = JsonValue.Create(context.Reader.ReadString());
break;
case BsonType.Int32:
result = JsonValue.Create(context.Reader.ReadInt32());
break;
case BsonType.Int64:
result = JsonValue.Create(context.Reader.ReadInt64());
break;
case BsonType.Double:
result = JsonValue.Create(context.Reader.ReadDouble());
break;
case BsonType.Boolean:
result = JsonValue.Create(context.Reader.ReadBoolean());
break;
case BsonType.DateTime:
result = JsonValue.Create(context.Reader.ReadDateTime());
break;
default:
throw new BsonSerializationException($"Unsupported BSON type: {bsonType}");
}
break;
default:
throw new BsonSerializationException($"Unsupported JsonNode type: {type}");
}
context.Reader.ReadEndDocument();
return result!;
}
/// <inheritdoc />
public void Serialize(BsonSerializationContext context, BsonSerializationArgs args, object value)
{
Serialize(context, args, (JsonNode)value);
}
object IBsonSerializer.Deserialize(BsonDeserializationContext context, BsonDeserializationArgs args)
{
return Deserialize(context, args);
}
}

View file

@ -72,7 +72,7 @@ internal class Export : ElsaEndpoint<Request>
foreach (var definition in definitions)
{
var model = await CreateWorkflowModelAsync(definition, cancellationToken);
var binaryJson = SerializeWorkflowDefinition(model);
var binaryJson = await SerializeWorkflowDefinitionAsync(model, cancellationToken);
var fileName = GetFileName(model);
var entry = zipArchive.CreateEntry(fileName, CompressionLevel.Optimal);
await using var entryStream = entry.Open();
@ -101,7 +101,7 @@ internal class Export : ElsaEndpoint<Request>
}
var model = await CreateWorkflowModelAsync(definition, cancellationToken);
var binaryJson = SerializeWorkflowDefinition(model);
var binaryJson = await SerializeWorkflowDefinitionAsync(model, cancellationToken);
var fileName = GetFileName(model);
await SendBytesAsync(binaryJson, fileName, cancellation: cancellationToken);
@ -115,10 +115,25 @@ internal class Export : ElsaEndpoint<Request>
return fileName;
}
private byte[] SerializeWorkflowDefinition(WorkflowDefinitionModel model)
private async Task<byte[]> SerializeWorkflowDefinitionAsync(WorkflowDefinitionModel model, CancellationToken cancellationToken)
{
JsonSerializerOptions serializerOptions = _serializer.GetOptions();
var binaryJson = JsonSerializer.SerializeToUtf8Bytes(model, serializerOptions);
var serializerOptions = _serializer.GetOptions();
var document = JsonSerializer.SerializeToDocument(model, serializerOptions);
var rootElement = document.RootElement;
using var output = new MemoryStream();
await using var writer = new Utf8JsonWriter(output);
writer.WriteStartObject();
writer.WriteString("$schema", "https://elsaworkflows.io/schemas/workflow-definition/v3.0.0/schema.json");
foreach (var property in rootElement.EnumerateObject())
property.WriteTo(writer);
writer.WriteEndObject();
await writer.FlushAsync(cancellationToken);
var binaryJson = output.ToArray();
return binaryJson;
}

View file

@ -1,6 +1,7 @@
using System.Text.Json;
using System.Text.Json.Serialization;
using Elsa.Workflows.Serialization.Converters;
using JetBrains.Annotations;
using Microsoft.Extensions.DependencyInjection;
namespace Elsa.Workflows.Serialization.Configurators;
@ -8,23 +9,14 @@ namespace Elsa.Workflows.Serialization.Configurators;
/// <summary>
/// Add additional <see cref="JsonConverter"/> objects.
/// </summary>
public class AdditionalConvertersConfigurator : SerializationOptionsConfiguratorBase
[UsedImplicitly]
public class AdditionalConvertersConfigurator(IServiceProvider serviceProvider) : SerializationOptionsConfiguratorBase
{
private readonly IServiceProvider _serviceProvider;
/// <summary>
/// Initializes a new instance of the <see cref="AdditionalConvertersConfigurator"/> class.
/// </summary>
public AdditionalConvertersConfigurator(IServiceProvider serviceProvider)
{
_serviceProvider = serviceProvider;
}
/// <inheritdoc />
public override void Configure(JsonSerializerOptions options)
{
options.Converters.Add(Create<VariableConverterFactory>());
}
private T Create<T>() => ActivatorUtilities.CreateInstance<T>(_serviceProvider);
private T Create<T>() => ActivatorUtilities.CreateInstance<T>(serviceProvider);
}