SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Fixing Stream variable saved in instance issue (#6785)

Browse source
This commit is contained in:
Lucas Hipólito 2025-07-15 13:59:39 +02:00 committed by GitHub
parent fd5579e551
commit f9b9c84cf0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/modules/Elsa.Workflows.Core/VariableStorageDrivers/WorkflowInstanceStorageDriver.cs
View file

@ -4,6 +4,7 @@ using System.Text.Json.Nodes;
using Elsa.Expressions.Helpers;
using Elsa.Extensions;
using JetBrains.Annotations;
using Microsoft.Extensions.Logging;
namespace Elsa.Workflows;
@ -12,7 +13,7 @@ namespace Elsa.Workflows;
/// </summary>
[Display(Name = "Workflow Instance")]
[UsedImplicitly]
public class WorkflowInstanceStorageDriver(IPayloadSerializer payloadSerializer) : IStorageDriver
public class WorkflowInstanceStorageDriver(IPayloadSerializer payloadSerializer, ILogger<WorkflowInstanceStorageDriver> logger) : IStorageDriver
{
/// <summary>
/// The key used to store the variables in the workflow state.
@ -29,8 +30,18 @@ public class WorkflowInstanceStorageDriver(IPayloadSerializer payloadSerializer)
{
UpdateVariablesDictionary(context, dictionary =>
{
var node = JsonSerializer.SerializeToNode(value);
dictionary[id] = node;
try
{
var node = JsonSerializer.SerializeToNode(value);
dictionary[id] = node;
}
catch (Exception ex) when (ex is JsonException or NotSupportedException or ObjectDisposedException)
{
logger.LogWarning(ex, "Failed to serialize variable '{VariableId}' of type '{VariableType}' for workflow instance storage. The variable will be skipped.",
id, value?.GetType().FullName ?? "null");
dictionary.Remove(id);
}
});
return ValueTask.CompletedTask;
}