From f6f4a49b45688a95d2c43908474c18dfade5ce24 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=BCrkan=20G=C3=BCran?= Date: Sun, 15 Jan 2023 11:04:04 +0100 Subject: [PATCH] Refactor --- .../src/modules/workflow-definitions/components/editor.tsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/designer/elsa-workflows-designer/src/modules/workflow-definitions/components/editor.tsx b/src/designer/elsa-workflows-designer/src/modules/workflow-definitions/components/editor.tsx index ee91e1041..f3c318633 100644 --- a/src/designer/elsa-workflows-designer/src/modules/workflow-definitions/components/editor.tsx +++ b/src/designer/elsa-workflows-designer/src/modules/workflow-definitions/components/editor.tsx @@ -193,10 +193,8 @@ export class WorkflowDefinitionEditor { private saveChanges = async (): Promise => { const updatedWorkflowDefinition = this.workflowDefinitionState; - // This function is called everytime graphUpdated event is published which does not necessarily mean workflow is updated. - // To prevent redundant post requests to server, save changes only if there is a difference - // between existing workflow definition on server side and updated workflow definition on client side. if (await this.hasWorkflowDefinitionAnyUpdatedData(updatedWorkflowDefinition)) { + // If workflow definition is published, override the latest version. if (updatedWorkflowDefinition.isPublished) { updatedWorkflowDefinition.version = this.workflowVersions.find(v => v.isLatest).version; } @@ -204,6 +202,9 @@ export class WorkflowDefinitionEditor { } }; + // This function is called everytime graphUpdated event is published which does not necessarily mean workflow is updated. + // To prevent redundant post requests to server, save changes only if there is a difference + // between existing workflow definition on server side and updated workflow definition on client side. private hasWorkflowDefinitionAnyUpdatedData = async (updatedWorkflowDefinition : WorkflowDefinition): Promise => { const existingWorkflowDefinition = await this.workflowDefinitionApi.get({definitionId: updatedWorkflowDefinition.definitionId, versionOptions: {version: updatedWorkflowDefinition.version}});