From f6caad19fb9229908996048902e22db7961018aa Mon Sep 17 00:00:00 2001 From: lukhipolito-nexxbiz Date: Mon, 13 Oct 2025 16:11:10 +0200 Subject: [PATCH] Update doc/qa/test-guidelines.md Co-authored-by: Sipke Schoorstra --- doc/qa/test-guidelines.md | 22 +++------------------- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/doc/qa/test-guidelines.md b/doc/qa/test-guidelines.md index 2edc1e97e..3183cbf28 100644 --- a/doc/qa/test-guidelines.md +++ b/doc/qa/test-guidelines.md @@ -210,25 +210,9 @@ public async Task Workflow_Persists_Instance_And_Journal() .UseRealPersistenceForTests() .Build(); - var runner = sp.GetRequiredService(); - var store = sp.GetRequiredService(); - - var result = await runner.RunAsync(workflow); - var instanceId = result.WorkflowInstance!.Id; - - // deterministic lookup: query store until terminal state - var deadline = DateTime.UtcNow + TimeSpan.FromSeconds(10); - WorkflowInstance? instance = null; - while (DateTime.UtcNow < deadline) - { - instance = await store.FindByIdAsync(instanceId); - if (instance is not null && instance.Status is WorkflowStatus.Finished or WorkflowStatus.Faulted) - break; - await Task.Delay(150); - } - - instance.Should().NotBeNull(); - instance!.Status.Should().Be(WorkflowStatus.Finished); + var runner = sp.GetRequiredService(); +var result = await runner.RunAndAwaitWorkflowCompletionAsync(WorkflowDefinitionHandle.ByDefinitionId(someDefinitionId, VersionOptions.Published)); + result.WorkflowExecutionContext.Status.Should().Be(WorkflowStatus.Finished); } ``` ---