SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Remove SendHttpRequestTests unit test class

Browse source 
This commit removes the `SendHttpRequestTests` test class, eliminating outdated or redundant tests to improve test coverage clarity and streamline the test suite.
This commit is contained in:
Sipke Schoorstra 2025-10-20 21:24:20 +02:00
parent 52a70e5d00
commit f4fe14a8db
No known key found for this signature in database
GPG key ID: 5C10502B28A4268F
1 changed files with 0 additions and 367 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

367
test/unit/Elsa.Activities.UnitTests/Http/SendHttpRequestTests.cs
View file

@ -1,367 +0,0 @@
using System.Net;
using System.Text;
using Elsa.Activities.UnitTests.Helpers;
using Elsa.Extensions;
using Elsa.Http;
using Elsa.Testing.Shared;
using Elsa.Workflows;
using Elsa.Workflows.Attributes;
using Microsoft.Extensions.DependencyInjection;
using NSubstitute;
namespace Elsa.Activities.UnitTests.HTTP;
public class SendHttpRequestTests
{
[Fact]
public async Task Should_Send_GET_Request_And_Handle_Success_Response()
{
// Arrange
var expectedUrl = new Uri("https://api.example.com/data");
var mockHttpClientFactory = Substitute.For<IHttpClientFactory>();
var responseContent = new StringContent("{\"result\": \"success\"}", Encoding.UTF8, "application/json");
var httpResponse = new HttpResponseMessage(HttpStatusCode.OK)
{
Content = responseContent
};
HttpRequestMessage? capturedRequest = null;
var testHandler = new TestHttpMessageHandler((request, _) =>
{
capturedRequest = request;
return Task.FromResult(httpResponse);
});
var httpClient = new HttpClient(testHandler);
mockHttpClientFactory.CreateClient(Arg.Any<string>()).Returns(httpClient);
var sendHttpRequest = new SendHttpRequest
{
Url = new(expectedUrl),
Method = new("GET"),
// Note: Setting ExpectedStatusCodes can cause workflow scheduling issues in test environments,
// because the activity may attempt to schedule additional branches for each expected status code,
// which can interfere with the test's control flow and assertions. To avoid this, we leave
// ExpectedStatusCodes empty in this test.
ExpectedStatusCodes = new List<HttpStatusCodeCase>()
};
// Act
var context = await ExecuteAsync(sendHttpRequest, mockHttpClientFactory);
// Assert
Assert.NotNull(capturedRequest);
Assert.Equal(HttpMethod.Get, capturedRequest.Method);
Assert.Equal(expectedUrl, capturedRequest.RequestUri);
var statusCodeOutput = context.GetActivityOutput(() => sendHttpRequest.StatusCode);
Assert.Equal(200, statusCodeOutput);
}
[Fact]
public async Task Should_Send_POST_Request_With_JSON_Content()
{
// Arrange
var expectedUrl = new Uri("https://api.example.com/create");
var requestContent = new { name = "test", value = 42 };
var contentType = "application/json";
var mockHttpClientFactory = Substitute.For<IHttpClientFactory>();
var httpResponse = new HttpResponseMessage(HttpStatusCode.Created);
HttpRequestMessage? capturedRequest = null;
var testHandler = new TestHttpMessageHandler((request, _) =>
{
capturedRequest = request;
return Task.FromResult(httpResponse);
});
var httpClient = new HttpClient(testHandler);
mockHttpClientFactory.CreateClient(Arg.Any<string>()).Returns(httpClient);
var sendHttpRequest = new SendHttpRequest
{
Url = new(expectedUrl),
Method = new("POST"),
Content = new(requestContent),
ContentType = new(contentType),
ExpectedStatusCodes = new List<HttpStatusCodeCase>()
};
// Act
await ExecuteAsync(sendHttpRequest, mockHttpClientFactory);
// Assert
Assert.NotNull(capturedRequest);
Assert.Equal(HttpMethod.Post, capturedRequest.Method);
Assert.Equal(expectedUrl, capturedRequest.RequestUri);
Assert.NotNull(capturedRequest.Content);
}
[Fact]
public async Task Should_Add_Authorization_Header()
{
// Arrange
var expectedUrl = new Uri("https://api.example.com/secure");
var authorizationHeader = "Bearer token123";
var mockHttpClientFactory = Substitute.For<IHttpClientFactory>();
var httpResponse = new HttpResponseMessage(HttpStatusCode.OK);
HttpRequestMessage? capturedRequest = null;
var testHandler = new TestHttpMessageHandler((request, _) =>
{
capturedRequest = request;
return Task.FromResult(httpResponse);
});
var httpClient = new HttpClient(testHandler);
mockHttpClientFactory.CreateClient(Arg.Any<string>()).Returns(httpClient);
var sendHttpRequest = new SendHttpRequest
{
Url = new(expectedUrl),
Method = new("GET"),
Authorization = new(authorizationHeader),
ExpectedStatusCodes = new List<HttpStatusCodeCase>()
};
// Act
await ExecuteAsync(sendHttpRequest, mockHttpClientFactory);
// Assert
Assert.NotNull(capturedRequest);
Assert.NotNull(capturedRequest.Headers.Authorization);
Assert.Equal(authorizationHeader, capturedRequest.Headers.Authorization.ToString());
}
[Fact]
public Task Should_Execute_Matching_Status_Code_Activity()
{
// Arrange
var mockHttpClientFactory = Substitute.For<IHttpClientFactory>();
var mockHttpClient = Substitute.For<HttpClient>();
var mockActivity404 = Substitute.For<IActivity>();
var mockActivity200 = Substitute.For<IActivity>();
var httpResponse = new HttpResponseMessage(HttpStatusCode.NotFound);
mockHttpClientFactory.CreateClient(Arg.Any<string>()).Returns(mockHttpClient);
mockHttpClient.SendAsync(Arg.Any<HttpRequestMessage>(), Arg.Any<CancellationToken>())
.Returns(Task.FromResult(httpResponse));
var sendHttpRequest = new SendHttpRequest
{
Url = new(new Uri("https://api.example.com/notfound")),
Method = new("GET"),
// Test the configuration without actually scheduling activities
ExpectedStatusCodes = new List<HttpStatusCodeCase>
{
new(200, mockActivity200),
new(404, mockActivity404)
}
};
// Act & Assert - This will fail due to scheduling, so we'll just test the configuration
var matchingCase = sendHttpRequest.ExpectedStatusCodes.FirstOrDefault(x => x.StatusCode == 404);
Assert.NotNull(matchingCase);
Assert.Equal(mockActivity404, matchingCase.Activity);
// Test that we can identify the correct status code without execution
Assert.Equal(2, sendHttpRequest.ExpectedStatusCodes.Count);
return Task.CompletedTask;
}
[Fact]
public Task Should_Execute_UnmatchedStatusCode_Activity_When_No_Match()
{
// Arrange
var mockUnmatchedActivity = Substitute.For<IActivity>();
var mockActivity200 = Substitute.For<IActivity>();
var sendHttpRequest = new SendHttpRequest
{
Url = new(new Uri("https://api.example.com/error")),
Method = new("GET"),
ExpectedStatusCodes = new List<HttpStatusCodeCase>
{
new(200, mockActivity200)
},
UnmatchedStatusCode = mockUnmatchedActivity
};
// Act & Assert - Test configuration without execution
var matchingCase = sendHttpRequest.ExpectedStatusCodes.FirstOrDefault(x => x.StatusCode == 500);
Assert.Null(matchingCase);
// Verify UnmatchedStatusCode activity is set
Assert.Equal(mockUnmatchedActivity, sendHttpRequest.UnmatchedStatusCode);
return Task.CompletedTask;
}
[Fact]
public Task Should_Handle_HttpRequestException_And_Execute_FailedToConnect_Activity()
{
// Arrange
var mockFailedToConnectActivity = Substitute.For<IActivity>();
var sendHttpRequest = new SendHttpRequest
{
Url = new(new Uri("https://unreachable.example.com")),
Method = new("GET"),
FailedToConnect = mockFailedToConnectActivity
};
// Act & Assert - Test configuration without execution
Assert.Equal(mockFailedToConnectActivity, sendHttpRequest.FailedToConnect);
return Task.CompletedTask;
}
[Fact]
public Task Should_Handle_TaskCanceledException_And_Execute_Timeout_Activity()
{
// Arrange
var mockTimeoutActivity = Substitute.For<IActivity>();
var sendHttpRequest = new SendHttpRequest
{
Url = new(new Uri("https://slow.example.com")),
Method = new("GET"),
Timeout = mockTimeoutActivity
};
// Act & Assert - Test configuration without execution
Assert.Equal(mockTimeoutActivity, sendHttpRequest.Timeout);
return Task.CompletedTask;
}
[Fact]
public async Task Should_Set_Response_Headers_Output()
{
// Arrange
var mockHttpClientFactory = Substitute.For<IHttpClientFactory>();
var httpResponse = new HttpResponseMessage(HttpStatusCode.OK);
httpResponse.Headers.Add("Custom-Header", "CustomValue");
httpResponse.Headers.Add("X-Rate-Limit", "100");
var testHandler = new TestHttpMessageHandler((_, _) =>
Task.FromResult(httpResponse));
var httpClient = new HttpClient(testHandler);
mockHttpClientFactory.CreateClient(Arg.Any<string>()).Returns(httpClient);
var sendHttpRequest = new SendHttpRequest
{
Url = new(new Uri("https://api.example.com/headers")),
Method = new("GET"),
ExpectedStatusCodes = new List<HttpStatusCodeCase>()
};
// Act
var context = await ExecuteAsync(sendHttpRequest, mockHttpClientFactory);
// Assert
var responseHeadersObj = context.GetActivityOutput(() => sendHttpRequest.ResponseHeaders);
var responseHeaders = responseHeadersObj as HttpHeaders;
Assert.NotNull(responseHeaders);
Assert.True(responseHeaders.ContainsKey("Custom-Header"));
Assert.True(responseHeaders.ContainsKey("X-Rate-Limit"));
}
[Fact]
public async Task Should_Parse_JSON_Response_Content()
{
// Arrange
var mockHttpClientFactory = Substitute.For<IHttpClientFactory>();
var jsonContent = "{\"id\": 123, \"name\": \"test\"}";
var responseContent = new StringContent(jsonContent, Encoding.UTF8, "application/json");
var httpResponse = new HttpResponseMessage(HttpStatusCode.OK)
{
Content = responseContent
};
var testHandler = new TestHttpMessageHandler((_, _) =>
Task.FromResult(httpResponse));
var httpClient = new HttpClient(testHandler);
mockHttpClientFactory.CreateClient(Arg.Any<string>()).Returns(httpClient);
var sendHttpRequest = new SendHttpRequest
{
Url = new(new Uri("https://api.example.com/json")),
Method = new("GET"),
ExpectedStatusCodes = new List<HttpStatusCodeCase>()
};
// Act
var context = await ExecuteAsync(sendHttpRequest, mockHttpClientFactory);
// Assert
var parsedContent = context.GetActivityOutput(() => sendHttpRequest.ParsedContent);
var statusCode = context.GetActivityOutput(() => sendHttpRequest.StatusCode);
var httpResponseResult = (HttpResponseMessage)context.GetActivityOutput(() => sendHttpRequest.Result)!;
Assert.NotNull(parsedContent);
Assert.Equal(200, statusCode);
// Verify the response was received and stored
Assert.NotNull(httpResponseResult);
Assert.Equal(HttpStatusCode.OK, httpResponseResult.StatusCode);
}
[Fact]
public void Should_Have_Correct_Activity_Attributes()
{
// Arrange & Act
var activityType = typeof(SendHttpRequest);
var activityAttribute = activityType.GetCustomAttributes(typeof(ActivityAttribute), false)
.Cast<ActivityAttribute>().FirstOrDefault();
// Assert
Assert.NotNull(activityAttribute);
Assert.Equal("Elsa", activityAttribute.Namespace);
Assert.Equal("HTTP", activityAttribute.Category);
Assert.Equal("Send an HTTP request.", activityAttribute.Description);
Assert.Equal("HTTP Request", activityAttribute.DisplayName);
Assert.Equal(ActivityKind.Task, activityAttribute.Kind);
}
[Fact]
public void Should_Inherit_From_SendHttpRequestBase()
{
// Arrange & Act
var sendHttpRequest = new SendHttpRequest();
// Assert
Assert.IsAssignableFrom<SendHttpRequestBase>(sendHttpRequest);
}
[Fact]
public void Should_Create_HttpStatusCodeCase_With_Status_And_Activity()
{
// Arrange
const int statusCode = 200;
var mockActivity = Substitute.For<IActivity>();
// Act
var httpStatusCodeCase = new HttpStatusCodeCase(statusCode, mockActivity);
// Assert
Assert.Equal(statusCode, httpStatusCodeCase.StatusCode);
Assert.Equal(mockActivity, httpStatusCodeCase.Activity);
}
private static Task<ActivityExecutionContext> ExecuteAsync(IActivity activity, IHttpClientFactory httpClientFactory)
{
return new ActivityTestFixture(activity)
.WithHttpServices()
.ConfigureServices(services =>
{
services.AddSingleton(httpClientFactory);
services.AddLogging();
})
.ExecuteAsync();
}
}