From efbfe8ea9a2aad27eccca3f0f2392b07460dd3aa Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Wed, 29 May 2024 23:49:40 +0200 Subject: [PATCH] Add validation for empty cron expression This commit adds validation for cron expressions in the DefaultTriggerScheduler class. The system now checks if the cron expression provided is empty and issues a warning if that's the case. This prevents attempts to schedule triggers with an empty cron expression, which would fail. --- .../Elsa.Scheduling/Services/DefaultTriggerScheduler.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/modules/Elsa.Scheduling/Services/DefaultTriggerScheduler.cs b/src/modules/Elsa.Scheduling/Services/DefaultTriggerScheduler.cs index d63098bca..83ded5091 100644 --- a/src/modules/Elsa.Scheduling/Services/DefaultTriggerScheduler.cs +++ b/src/modules/Elsa.Scheduling/Services/DefaultTriggerScheduler.cs @@ -70,6 +70,13 @@ public class DefaultTriggerScheduler(IWorkflowScheduler workflowScheduler, ISyst { var payload = trigger.GetPayload(); var cronExpression = payload.CronExpression; + + if (string.IsNullOrWhiteSpace(cronExpression)) + { + _logger.LogWarning("Cron expression is empty. TriggerId: {TriggerId}. Skipping scheduling of this trigger", trigger.Id); + continue; + } + var input = new { CronExpression = cronExpression }.ToDictionary(); var request = new DispatchWorkflowDefinitionRequest {