SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Fix null handling for cancellation tokens and string fields

Browse source 
Updated `_linkedTokenSource` initialization to allow null values and improved string field handling by applying `NullIfEmpty()` for `CorrelationId`, `TriggerActivityId`, and `ParentWorkflowInstanceId`. These changes ensure proper null-state management and eliminate potential discrepancies in downstream operations.
This commit is contained in:
Sipke Schoorstra 2025-03-28 20:56:47 +01:00
parent fdc57945e8
commit ede5d5cad2
No known key found for this signature in database
GPG key ID: 5C10502B28A4268F
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/modules/Elsa.Workflows.Runtime.ProtoActor/Actors/WorkflowInstance.cs
View file

@ -21,7 +21,7 @@ internal class WorkflowInstance(
private string? _workflowInstanceId;
private WorkflowGraph? _workflowGraph;
private WorkflowState? _workflowState;
private CancellationTokenSource _linkedTokenSource = default!;
private CancellationTokenSource _linkedTokenSource = null!;
private CancellationToken _linkedCancellationToken;
private readonly Queue<RunWorkflowOptions> _queuedRunWorkflowOptions = new();
private bool _isRunning;
@ -137,8 +137,8 @@ internal class WorkflowInstance(
ActivityHandle = mappers.ActivityHandleMapper.Map(request.ActivityHandle),
Properties = request.Properties.DeserializeProperties(),
Input = request.Input.DeserializeInput(),
CorrelationId = request.CorrelationId,
TriggerActivityId = request.TriggerActivityId
CorrelationId = request.CorrelationId.NullIfEmpty(),
TriggerActivityId = request.TriggerActivityId.NullIfEmpty()
};
var result = await RunAsync(runWorkflowOptions);
@ -266,7 +266,7 @@ internal class WorkflowInstance(
CorrelationId = request.CorrelationId.NullIfEmpty(),
Input = request.Input.DeserializeInput(),
Properties = request.Properties.DeserializeProperties(),
ParentWorkflowInstanceId = request.ParentId
ParentWorkflowInstanceId = request.ParentId.NullIfEmpty()
};
await using var scope = scopeFactory.CreateAsyncScope();